test_usage_tracker.py 40 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019
  1. """Unit tests for the filament usage tracker.
  2. Tests 3MF-primary tracking (Path 1) and AMS remain% delta fallback
  3. (Path 2) for spools not covered by 3MF data.
  4. """
  5. from datetime import datetime, timezone
  6. from unittest.mock import AsyncMock, MagicMock, patch
  7. import pytest
  8. from backend.app.services.usage_tracker import (
  9. PrintSession,
  10. _active_sessions,
  11. _archive_colors_from_spools,
  12. _spool_color_to_hex,
  13. _track_from_3mf,
  14. on_print_complete,
  15. on_print_start,
  16. )
  17. def _make_spool(*, id=1, label_weight=1000, weight_used=0, tag_uid=None, tray_uuid=None, rgba=None):
  18. """Create a mock Spool object."""
  19. spool = MagicMock()
  20. spool.id = id
  21. spool.label_weight = label_weight
  22. spool.weight_used = weight_used
  23. spool.tag_uid = tag_uid
  24. spool.tray_uuid = tray_uuid
  25. spool.last_used = None
  26. spool.cost_per_kg = None
  27. spool.material = "PLA"
  28. spool.rgba = rgba
  29. return spool
  30. def _make_assignment(*, spool_id=1, printer_id=1, ams_id=0, tray_id=0, created_at=None):
  31. """Create a mock SpoolAssignment object."""
  32. assignment = MagicMock()
  33. assignment.spool_id = spool_id
  34. assignment.printer_id = printer_id
  35. assignment.ams_id = ams_id
  36. assignment.tray_id = tray_id
  37. assignment.created_at = created_at or datetime.now(timezone.utc)
  38. return assignment
  39. def _make_printer_state(ams_data, progress=0, layer_num=0, tray_now=255):
  40. """Create a mock printer state with AMS data."""
  41. state = MagicMock()
  42. state.raw_data = {"ams": ams_data}
  43. state.progress = progress
  44. state.layer_num = layer_num
  45. state.tray_now = tray_now
  46. return state
  47. def _make_printer_manager(state=None):
  48. """Create a mock printer manager."""
  49. pm = MagicMock()
  50. pm.get_status.return_value = state
  51. return pm
  52. class TestOnPrintStart:
  53. """Tests for on_print_start — capturing AMS remain%."""
  54. @pytest.fixture(autouse=True)
  55. def _clear_sessions(self):
  56. _active_sessions.clear()
  57. yield
  58. _active_sessions.clear()
  59. @pytest.mark.asyncio
  60. async def test_creates_session_with_valid_remain(self):
  61. """Session created with remain% data for trays reporting 0-100."""
  62. ams_data = [{"id": 0, "tray": [{"id": 0, "remain": 80}]}]
  63. pm = _make_printer_manager(_make_printer_state(ams_data))
  64. await on_print_start(1, {"subtask_name": "test_print"}, pm)
  65. assert 1 in _active_sessions
  66. session = _active_sessions[1]
  67. assert session.print_name == "test_print"
  68. assert session.tray_remain_start == {(0, 0): 80}
  69. @pytest.mark.asyncio
  70. async def test_creates_session_even_without_valid_remain(self):
  71. """Session still created when remain=-1 (for 3MF fallback path)."""
  72. ams_data = [{"id": 0, "tray": [{"id": 0, "remain": -1}]}]
  73. pm = _make_printer_manager(_make_printer_state(ams_data))
  74. await on_print_start(1, {"subtask_name": "test_print"}, pm)
  75. assert 1 in _active_sessions
  76. session = _active_sessions[1]
  77. assert session.tray_remain_start == {} # Empty, no valid remain
  78. @pytest.mark.asyncio
  79. async def test_skips_without_ams_data(self):
  80. """No session created when no AMS data available."""
  81. state = MagicMock()
  82. state.raw_data = {"ams": []}
  83. pm = _make_printer_manager(state)
  84. await on_print_start(1, {"subtask_name": "test"}, pm)
  85. assert 1 not in _active_sessions
  86. class TestOnPrintCompleteAMSDelta:
  87. """Tests for Path 1: AMS remain% delta tracking."""
  88. @pytest.fixture(autouse=True)
  89. def _clear_sessions(self):
  90. _active_sessions.clear()
  91. yield
  92. _active_sessions.clear()
  93. @pytest.fixture(autouse=True)
  94. def _mock_get_setting(self):
  95. with patch(
  96. "backend.app.api.routes.settings.get_setting",
  97. new_callable=AsyncMock,
  98. return_value=None,
  99. ):
  100. yield
  101. @pytest.mark.asyncio
  102. async def test_computes_delta_and_updates_spool(self):
  103. """Spool weight_used updated by remain% delta * label_weight."""
  104. # Set up session with start remain = 80%
  105. _active_sessions[1] = PrintSession(
  106. printer_id=1,
  107. print_name="test",
  108. started_at=datetime.now(timezone.utc),
  109. tray_remain_start={(0, 0): 80},
  110. )
  111. # Current remain = 70% → 10% consumed → 100g on 1000g spool
  112. ams_data = [{"id": 0, "tray": [{"id": 0, "remain": 70}]}]
  113. pm = _make_printer_manager(_make_printer_state(ams_data))
  114. spool = _make_spool(label_weight=1000, weight_used=50)
  115. assignment = _make_assignment()
  116. db = AsyncMock()
  117. # First 2 executes → _find_3mf_by_filename (library + archive search, uses scalars().all()),
  118. # then assignment, then spool for the AMS fallback path
  119. db.execute = AsyncMock(
  120. side_effect=[
  121. MagicMock(), # _find_3mf_by_filename: library search
  122. MagicMock(), # _find_3mf_by_filename: archive search
  123. MagicMock(scalar_one_or_none=MagicMock(return_value=assignment)),
  124. MagicMock(scalar_one_or_none=MagicMock(return_value=spool)),
  125. ]
  126. )
  127. results = await on_print_complete(1, {"status": "completed"}, pm, db)
  128. assert len(results) == 1
  129. assert results[0]["weight_used"] == 100.0
  130. assert results[0]["percent_used"] == 10
  131. # weight_used should be old (50) + delta (100)
  132. assert spool.weight_used == 150.0
  133. db.commit.assert_called_once()
  134. @pytest.mark.asyncio
  135. async def test_skips_negative_delta(self):
  136. """No tracking when remain increased (spool refilled)."""
  137. _active_sessions[1] = PrintSession(
  138. printer_id=1,
  139. print_name="test",
  140. started_at=datetime.now(timezone.utc),
  141. tray_remain_start={(0, 0): 50},
  142. )
  143. # Remain went UP: 50 → 80 (refilled)
  144. ams_data = [{"id": 0, "tray": [{"id": 0, "remain": 80}]}]
  145. pm = _make_printer_manager(_make_printer_state(ams_data))
  146. db = AsyncMock()
  147. results = await on_print_complete(1, {"status": "completed"}, pm, db)
  148. assert results == []
  149. db.commit.assert_not_called()
  150. @pytest.mark.asyncio
  151. async def test_an_unloaded_tray_at_start_does_not_exclude_every_slot(self):
  152. """tray_now reads 255 at rest -- its initial value, and what an
  153. unparseable reading falls back to. Mapped as a tray id that is (255, 1),
  154. so taking it as evidence of which slots the print used would exclude
  155. every real one and charge nothing (#1820)."""
  156. _active_sessions[1] = PrintSession(
  157. printer_id=1,
  158. print_name="test",
  159. started_at=datetime.now(timezone.utc),
  160. tray_remain_start={(0, 0): 80},
  161. tray_now_at_start=255,
  162. )
  163. ams_data = [{"id": 0, "tray": [{"id": 0, "remain": 70}]}]
  164. pm = _make_printer_manager(_make_printer_state(ams_data))
  165. spool = _make_spool(label_weight=1000, weight_used=0)
  166. db = AsyncMock()
  167. db.execute = AsyncMock(
  168. side_effect=[
  169. MagicMock(), # _find_3mf_by_filename: library search
  170. MagicMock(), # _find_3mf_by_filename: archive search
  171. MagicMock(scalar_one_or_none=MagicMock(return_value=_make_assignment())),
  172. MagicMock(scalar_one_or_none=MagicMock(return_value=spool)),
  173. ]
  174. )
  175. results = await on_print_complete(1, {"status": "completed"}, pm, db)
  176. assert len(results) == 1
  177. assert results[0]["weight_used"] == 100.0
  178. @pytest.mark.asyncio
  179. async def test_a_delta_that_charges_nothing_says_so(self, caplog):
  180. """Charging nothing has to be distinguishable from having nothing to
  181. charge (#1820). A fresh spool reads 100% for its first tens of grams
  182. and the AMS estimate drifts upward on its own, so this fires on real
  183. prints, not only on refills -- and used to fire in complete silence."""
  184. import logging
  185. _active_sessions[1] = PrintSession(
  186. printer_id=1,
  187. print_name="test",
  188. started_at=datetime.now(timezone.utc),
  189. tray_remain_start={(0, 0): 100},
  190. )
  191. ams_data = [{"id": 0, "tray": [{"id": 0, "remain": 100}]}]
  192. pm = _make_printer_manager(_make_printer_state(ams_data))
  193. db = AsyncMock()
  194. with caplog.at_level(logging.INFO, logger="backend.app.services.usage_tracker"):
  195. results = await on_print_complete(1, {"status": "completed"}, pm, db)
  196. assert results == []
  197. assert "did not fall" in caplog.text
  198. assert "100% -> 100%" in caplog.text
  199. @pytest.mark.asyncio
  200. async def test_no_session_falls_through_to_3mf(self):
  201. """When no session exists, AMS delta path skipped (3MF may still run)."""
  202. pm = _make_printer_manager()
  203. db = AsyncMock()
  204. results = await on_print_complete(1, {"status": "completed"}, pm, db)
  205. assert results == []
  206. @pytest.mark.asyncio
  207. async def test_skips_fallback_for_trays_outside_print_mapping(self):
  208. """#1269: swapping a spool in an UNUSED slot mid-print must NOT charge the old spool.
  209. Reproduces maugsburger's report: single-color print on AMS0-T3
  210. (ams_mapping=[3]). User swaps spools in T1 and T2 during the print —
  211. those slots report remain=0 at completion (new spool with no tag).
  212. The fallback must skip T1 and T2 because they were never in the
  213. print's tray mapping or runtime tray_change_log.
  214. """
  215. _active_sessions[1] = PrintSession(
  216. printer_id=1,
  217. print_name="splitter",
  218. started_at=datetime.now(timezone.utc),
  219. tray_remain_start={(0, 1): 100, (0, 2): 17, (0, 3): 100},
  220. tray_now_at_start=3,
  221. ams_mapping=[3],
  222. )
  223. # User swapped T1 and T2 mid-print → both report remain=0 now.
  224. # T3 was actually used but it's also at 0 now. Without the fix the
  225. # fallback would charge the originally-assigned spools at T1 and T2.
  226. ams_data = [
  227. {
  228. "id": 0,
  229. "tray": [
  230. {"id": 1, "remain": 0},
  231. {"id": 2, "remain": 0},
  232. {"id": 3, "remain": 0},
  233. ],
  234. }
  235. ]
  236. state = _make_printer_state(ams_data, tray_now=3)
  237. state.tray_change_log = [(3, 0)] # only T3 was loaded during the print
  238. pm = _make_printer_manager(state)
  239. # Only T3 should reach the spool lookup; T1 and T2 must be filtered
  240. # out before any DB query is issued for them.
  241. t3_spool = _make_spool(id=8, label_weight=1000, weight_used=0)
  242. t3_assignment = _make_assignment(spool_id=8, ams_id=0, tray_id=3)
  243. db = AsyncMock()
  244. db.execute = AsyncMock(
  245. side_effect=[
  246. MagicMock(), # _find_3mf_by_filename: library search
  247. MagicMock(), # _find_3mf_by_filename: archive search
  248. MagicMock(scalar_one_or_none=MagicMock(return_value=t3_assignment)),
  249. MagicMock(scalar_one_or_none=MagicMock(return_value=t3_spool)),
  250. ]
  251. )
  252. results = await on_print_complete(1, {"status": "completed"}, pm, db)
  253. # Only T3 should be charged. T1 (spool 27 in the report) and T2
  254. # (spool 24) must NOT appear in the results.
  255. assert len(results) == 1
  256. assert results[0]["ams_id"] == 0
  257. assert results[0]["tray_id"] == 3
  258. class TestTrackFrom3MF:
  259. """Tests for Path 2: 3MF per-filament fallback tracking."""
  260. @pytest.mark.asyncio
  261. async def test_updates_non_bl_spool_from_3mf(self):
  262. """Non-BL spool gets weight_used from 3MF used_g for completed print."""
  263. spool = _make_spool(id=5, label_weight=1000, weight_used=100)
  264. assignment = _make_assignment(spool_id=5)
  265. archive = MagicMock()
  266. archive.file_path = "archives/test.3mf"
  267. db = AsyncMock()
  268. # archive, queue_item(None), assignment, spool
  269. db.execute = AsyncMock(
  270. side_effect=[
  271. MagicMock(scalar_one_or_none=MagicMock(return_value=archive)),
  272. MagicMock(scalar_one_or_none=MagicMock(return_value=None)),
  273. MagicMock(scalar_one_or_none=MagicMock(return_value=assignment)),
  274. MagicMock(scalar_one_or_none=MagicMock(return_value=spool)),
  275. ]
  276. )
  277. pm = _make_printer_manager(_make_printer_state([], tray_now=0))
  278. filament_usage = [{"slot_id": 1, "used_g": 25.5, "type": "PLA", "color": "#FF0000"}]
  279. with (
  280. patch("backend.app.core.config.settings") as mock_settings,
  281. patch("backend.app.utils.threemf_tools.extract_filament_usage_from_3mf", return_value=filament_usage),
  282. ):
  283. mock_path = MagicMock()
  284. mock_path.exists.return_value = True
  285. mock_settings.base_dir.__truediv__ = MagicMock(return_value=mock_path)
  286. results = await _track_from_3mf(
  287. printer_id=1,
  288. archive_id=10,
  289. status="completed",
  290. print_name="test_print",
  291. handled_trays=set(),
  292. printer_manager=pm,
  293. db=db,
  294. )
  295. assert len(results) == 1
  296. assert results[0]["spool_id"] == 5
  297. assert results[0]["weight_used"] == 25.5
  298. # weight_used = old (100) + 3MF (25.5)
  299. assert spool.weight_used == 125.5
  300. @pytest.mark.asyncio
  301. async def test_scales_by_progress_for_failed_print(self):
  302. """Failed print scales 3MF estimate by progress percentage."""
  303. spool = _make_spool(id=1, label_weight=1000, weight_used=0)
  304. assignment = _make_assignment()
  305. archive = MagicMock()
  306. archive.file_path = "archives/test.3mf"
  307. db = AsyncMock()
  308. # archive, queue_item(None), assignment, spool
  309. db.execute = AsyncMock(
  310. side_effect=[
  311. MagicMock(scalar_one_or_none=MagicMock(return_value=archive)),
  312. MagicMock(scalar_one_or_none=MagicMock(return_value=None)),
  313. MagicMock(scalar_one_or_none=MagicMock(return_value=assignment)),
  314. MagicMock(scalar_one_or_none=MagicMock(return_value=spool)),
  315. ]
  316. )
  317. # Print failed at 50% progress → 50g consumed from 100g estimate
  318. pm = _make_printer_manager(_make_printer_state([], progress=50, tray_now=0))
  319. filament_usage = [{"slot_id": 1, "used_g": 100.0, "type": "PLA", "color": ""}]
  320. with (
  321. patch("backend.app.core.config.settings") as mock_settings,
  322. patch("backend.app.utils.threemf_tools.extract_filament_usage_from_3mf", return_value=filament_usage),
  323. ):
  324. mock_path = MagicMock()
  325. mock_path.exists.return_value = True
  326. mock_settings.base_dir.__truediv__ = MagicMock(return_value=mock_path)
  327. results = await _track_from_3mf(
  328. printer_id=1,
  329. archive_id=10,
  330. status="failed",
  331. print_name="test",
  332. handled_trays=set(),
  333. printer_manager=pm,
  334. db=db,
  335. )
  336. assert len(results) == 1
  337. assert results[0]["weight_used"] == 50.0
  338. assert spool.weight_used == 50.0
  339. @pytest.mark.asyncio
  340. async def test_tracks_bl_spools_via_3mf(self):
  341. """BL spools (with tag_uid) ARE now tracked via 3MF (unified tracking)."""
  342. spool = _make_spool(tag_uid="ABCD1234", tray_uuid="A1B2C3D4E5F6A1B2C3D4E5F6A1B2C3D4")
  343. assignment = _make_assignment()
  344. archive = MagicMock()
  345. archive.file_path = "archives/test.3mf"
  346. db = AsyncMock()
  347. # archive, queue_item(None), assignment, spool
  348. db.execute = AsyncMock(
  349. side_effect=[
  350. MagicMock(scalar_one_or_none=MagicMock(return_value=archive)),
  351. MagicMock(scalar_one_or_none=MagicMock(return_value=None)),
  352. MagicMock(scalar_one_or_none=MagicMock(return_value=assignment)),
  353. MagicMock(scalar_one_or_none=MagicMock(return_value=spool)),
  354. ]
  355. )
  356. pm = _make_printer_manager(_make_printer_state([], tray_now=0))
  357. filament_usage = [{"slot_id": 1, "used_g": 50.0, "type": "PLA", "color": ""}]
  358. with (
  359. patch("backend.app.core.config.settings") as mock_settings,
  360. patch("backend.app.utils.threemf_tools.extract_filament_usage_from_3mf", return_value=filament_usage),
  361. ):
  362. mock_path = MagicMock()
  363. mock_path.exists.return_value = True
  364. mock_settings.base_dir.__truediv__ = MagicMock(return_value=mock_path)
  365. results = await _track_from_3mf(
  366. printer_id=1,
  367. archive_id=10,
  368. status="completed",
  369. print_name="test",
  370. handled_trays=set(),
  371. printer_manager=pm,
  372. db=db,
  373. )
  374. assert len(results) == 1
  375. assert results[0]["spool_id"] == 1
  376. assert results[0]["weight_used"] == 50.0
  377. @pytest.mark.asyncio
  378. async def test_skips_already_handled_trays(self):
  379. """Trays handled by AMS remain% delta are not double-tracked via 3MF."""
  380. archive = MagicMock()
  381. archive.file_path = "archives/test.3mf"
  382. db = AsyncMock()
  383. # archive, queue_item(None)
  384. db.execute = AsyncMock(
  385. side_effect=[
  386. MagicMock(scalar_one_or_none=MagicMock(return_value=archive)),
  387. MagicMock(scalar_one_or_none=MagicMock(return_value=None)),
  388. ]
  389. )
  390. pm = _make_printer_manager(_make_printer_state([], tray_now=0))
  391. filament_usage = [{"slot_id": 1, "used_g": 50.0, "type": "PLA", "color": ""}]
  392. with (
  393. patch("backend.app.core.config.settings") as mock_settings,
  394. patch("backend.app.utils.threemf_tools.extract_filament_usage_from_3mf", return_value=filament_usage),
  395. ):
  396. mock_path = MagicMock()
  397. mock_path.exists.return_value = True
  398. mock_settings.base_dir.__truediv__ = MagicMock(return_value=mock_path)
  399. results = await _track_from_3mf(
  400. printer_id=1,
  401. archive_id=10,
  402. status="completed",
  403. print_name="test",
  404. handled_trays={(0, 0)}, # slot_id=1 → ams_id=0, tray_id=0
  405. printer_manager=pm,
  406. db=db,
  407. )
  408. assert results == []
  409. @pytest.mark.asyncio
  410. async def test_slot_to_tray_mapping(self):
  411. """3MF slot_id maps correctly to (ams_id, tray_id) via tray_now."""
  412. # tray_now=4 → ams_id=1, tray_id=0 (single filament uses tray_now)
  413. spool = _make_spool(id=9)
  414. assignment = _make_assignment(spool_id=9, ams_id=1, tray_id=0)
  415. archive = MagicMock()
  416. archive.file_path = "archives/test.3mf"
  417. db = AsyncMock()
  418. # archive, queue_item(None), assignment, spool
  419. db.execute = AsyncMock(
  420. side_effect=[
  421. MagicMock(scalar_one_or_none=MagicMock(return_value=archive)),
  422. MagicMock(scalar_one_or_none=MagicMock(return_value=None)),
  423. MagicMock(scalar_one_or_none=MagicMock(return_value=assignment)),
  424. MagicMock(scalar_one_or_none=MagicMock(return_value=spool)),
  425. ]
  426. )
  427. pm = _make_printer_manager(_make_printer_state([], tray_now=4))
  428. filament_usage = [{"slot_id": 5, "used_g": 30.0, "type": "PETG", "color": ""}]
  429. with (
  430. patch("backend.app.core.config.settings") as mock_settings,
  431. patch("backend.app.utils.threemf_tools.extract_filament_usage_from_3mf", return_value=filament_usage),
  432. ):
  433. mock_path = MagicMock()
  434. mock_path.exists.return_value = True
  435. mock_settings.base_dir.__truediv__ = MagicMock(return_value=mock_path)
  436. results = await _track_from_3mf(
  437. printer_id=1,
  438. archive_id=10,
  439. status="completed",
  440. print_name="test",
  441. handled_trays=set(),
  442. printer_manager=pm,
  443. db=db,
  444. )
  445. assert len(results) == 1
  446. assert results[0]["ams_id"] == 1
  447. assert results[0]["tray_id"] == 0
  448. class TestSpoolAssignmentSnapshot:
  449. """Tests for spool assignment snapshotting at print start (#459).
  450. When a spool runs empty mid-print, on_ams_change deletes the SpoolAssignment.
  451. The snapshot captured at print start ensures usage is still attributed correctly.
  452. """
  453. @pytest.fixture(autouse=True)
  454. def _clear_sessions(self):
  455. _active_sessions.clear()
  456. yield
  457. _active_sessions.clear()
  458. @pytest.fixture(autouse=True)
  459. def _mock_get_setting(self):
  460. with patch(
  461. "backend.app.api.routes.settings.get_setting",
  462. new_callable=AsyncMock,
  463. return_value=None,
  464. ):
  465. yield
  466. @pytest.mark.asyncio
  467. async def test_on_print_start_snapshots_assignments_with_db(self):
  468. """on_print_start captures spool assignments when db is provided."""
  469. ams_data = [{"id": 0, "tray": [{"id": 0, "remain": 80}, {"id": 1, "remain": 60}]}]
  470. pm = _make_printer_manager(_make_printer_state(ams_data, tray_now=0))
  471. assignment_0 = _make_assignment(spool_id=10, printer_id=1, ams_id=0, tray_id=0)
  472. assignment_1 = _make_assignment(spool_id=20, printer_id=1, ams_id=0, tray_id=1)
  473. db = AsyncMock()
  474. scalars_mock = MagicMock()
  475. scalars_mock.all.return_value = [assignment_0, assignment_1]
  476. result_mock = MagicMock()
  477. result_mock.scalars.return_value = scalars_mock
  478. db.execute = AsyncMock(return_value=result_mock)
  479. await on_print_start(1, {"subtask_name": "Benchy"}, pm, db=db)
  480. session = _active_sessions[1]
  481. assert session.spool_assignments == {(0, 0): 10, (0, 1): 20}
  482. @pytest.mark.asyncio
  483. async def test_on_print_start_empty_snapshot_without_db(self):
  484. """on_print_start creates empty snapshot when no db provided."""
  485. ams_data = [{"id": 0, "tray": [{"id": 0, "remain": 80}]}]
  486. pm = _make_printer_manager(_make_printer_state(ams_data, tray_now=0))
  487. await on_print_start(1, {"subtask_name": "Benchy"}, pm)
  488. session = _active_sessions[1]
  489. assert session.spool_assignments == {}
  490. @pytest.mark.asyncio
  491. async def test_3mf_uses_snapshot_instead_of_live_query(self):
  492. """_track_from_3mf uses snapshot spool_id without querying SpoolAssignment."""
  493. spool = _make_spool(id=42, label_weight=1000)
  494. archive = MagicMock()
  495. archive.file_path = "archives/test.3mf"
  496. # db: archive, queue_item(None), spool — NO assignment query needed
  497. db = AsyncMock()
  498. db.execute = AsyncMock(
  499. side_effect=[
  500. MagicMock(scalar_one_or_none=MagicMock(return_value=archive)),
  501. MagicMock(scalar_one_or_none=MagicMock(return_value=None)),
  502. MagicMock(scalar_one_or_none=MagicMock(return_value=spool)),
  503. ]
  504. )
  505. pm = _make_printer_manager(_make_printer_state([], tray_now=0))
  506. filament_usage = [{"slot_id": 1, "used_g": 15.0, "type": "PLA", "color": "#FF0000"}]
  507. with (
  508. patch("backend.app.core.config.settings") as mock_settings,
  509. patch("backend.app.utils.threemf_tools.extract_filament_usage_from_3mf", return_value=filament_usage),
  510. ):
  511. mock_path = MagicMock()
  512. mock_path.exists.return_value = True
  513. mock_settings.base_dir.__truediv__ = MagicMock(return_value=mock_path)
  514. results = await _track_from_3mf(
  515. printer_id=1,
  516. archive_id=10,
  517. status="completed",
  518. print_name="Test",
  519. handled_trays=set(),
  520. printer_manager=pm,
  521. db=db,
  522. spool_assignments={(0, 0): 42},
  523. )
  524. assert len(results) == 1
  525. assert results[0]["spool_id"] == 42
  526. assert results[0]["weight_used"] == 15.0
  527. @pytest.mark.asyncio
  528. async def test_3mf_falls_back_to_live_query_without_snapshot(self):
  529. """_track_from_3mf queries SpoolAssignment when no snapshot exists."""
  530. spool = _make_spool(id=5, label_weight=1000)
  531. assignment = _make_assignment(spool_id=5)
  532. archive = MagicMock()
  533. archive.file_path = "archives/test.3mf"
  534. # db: archive, queue_item(None), assignment, spool
  535. db = AsyncMock()
  536. db.execute = AsyncMock(
  537. side_effect=[
  538. MagicMock(scalar_one_or_none=MagicMock(return_value=archive)),
  539. MagicMock(scalar_one_or_none=MagicMock(return_value=None)),
  540. MagicMock(scalar_one_or_none=MagicMock(return_value=assignment)),
  541. MagicMock(scalar_one_or_none=MagicMock(return_value=spool)),
  542. ]
  543. )
  544. pm = _make_printer_manager(_make_printer_state([], tray_now=0))
  545. filament_usage = [{"slot_id": 1, "used_g": 10.0, "type": "PLA", "color": "#FF0000"}]
  546. with (
  547. patch("backend.app.core.config.settings") as mock_settings,
  548. patch("backend.app.utils.threemf_tools.extract_filament_usage_from_3mf", return_value=filament_usage),
  549. ):
  550. mock_path = MagicMock()
  551. mock_path.exists.return_value = True
  552. mock_settings.base_dir.__truediv__ = MagicMock(return_value=mock_path)
  553. results = await _track_from_3mf(
  554. printer_id=1,
  555. archive_id=10,
  556. status="completed",
  557. print_name="Test",
  558. handled_trays=set(),
  559. printer_manager=pm,
  560. db=db,
  561. spool_assignments=None,
  562. )
  563. assert len(results) == 1
  564. assert results[0]["spool_id"] == 5
  565. @pytest.mark.asyncio
  566. async def test_ams_delta_uses_snapshot_over_live_query(self):
  567. """AMS remain% fallback uses snapshot spool_id instead of live query."""
  568. spool = _make_spool(id=77, label_weight=1000)
  569. _active_sessions[1] = PrintSession(
  570. printer_id=1,
  571. print_name="Benchy",
  572. started_at=datetime.now(timezone.utc),
  573. tray_remain_start={(0, 0): 80},
  574. spool_assignments={(0, 0): 77},
  575. )
  576. # Current remain = 70% → 10% delta → 100g
  577. ams_data = [{"id": 0, "tray": [{"id": 0, "remain": 70}]}]
  578. pm = _make_printer_manager(_make_printer_state(ams_data))
  579. # First 2 executes → _find_3mf_by_filename (library + archive search),
  580. # then live assignment check (returns None), then spool lookup by snapshot spool_id
  581. db = AsyncMock()
  582. db.execute = AsyncMock(
  583. side_effect=[
  584. MagicMock(), # _find_3mf_by_filename: library search
  585. MagicMock(), # _find_3mf_by_filename: archive search
  586. MagicMock(scalar_one_or_none=MagicMock(return_value=None)), # live assignment
  587. MagicMock(scalar_one_or_none=MagicMock(return_value=spool)),
  588. ]
  589. )
  590. results = await on_print_complete(
  591. printer_id=1,
  592. data={"status": "completed"},
  593. printer_manager=pm,
  594. db=db,
  595. archive_id=None,
  596. )
  597. assert len(results) == 1
  598. assert results[0]["spool_id"] == 77
  599. assert results[0]["weight_used"] == 100.0
  600. @pytest.mark.asyncio
  601. async def test_ams_delta_falls_back_to_live_query_without_snapshot(self):
  602. """AMS remain% fallback queries SpoolAssignment when snapshot is empty."""
  603. spool = _make_spool(id=33, label_weight=1000)
  604. assignment = _make_assignment(spool_id=33)
  605. _active_sessions[1] = PrintSession(
  606. printer_id=1,
  607. print_name="Benchy",
  608. started_at=datetime.now(timezone.utc),
  609. tray_remain_start={(0, 0): 80},
  610. spool_assignments={}, # Empty snapshot (pre-upgrade session)
  611. )
  612. ams_data = [{"id": 0, "tray": [{"id": 0, "remain": 70}]}]
  613. pm = _make_printer_manager(_make_printer_state(ams_data))
  614. # First 2 executes → _find_3mf_by_filename (library + archive search),
  615. # then assignment and spool for the AMS fallback path
  616. db = AsyncMock()
  617. db.execute = AsyncMock(
  618. side_effect=[
  619. MagicMock(), # _find_3mf_by_filename: library search
  620. MagicMock(), # _find_3mf_by_filename: archive search
  621. MagicMock(scalar_one_or_none=MagicMock(return_value=assignment)),
  622. MagicMock(scalar_one_or_none=MagicMock(return_value=spool)),
  623. ]
  624. )
  625. results = await on_print_complete(
  626. printer_id=1,
  627. data={"status": "completed"},
  628. printer_manager=pm,
  629. db=db,
  630. archive_id=None,
  631. )
  632. assert len(results) == 1
  633. assert results[0]["spool_id"] == 33
  634. @pytest.mark.asyncio
  635. async def test_snapshot_survives_mid_print_unlink(self):
  636. """Core bug scenario: snapshot provides spool_id after mid-print unlink.
  637. Simulates the #459 scenario: spool runs empty mid-print, on_ams_change
  638. deletes the SpoolAssignment, but the snapshot from print start still
  639. has the spool_id so usage is correctly attributed at print completion.
  640. """
  641. spool = _make_spool(id=8, label_weight=1000, weight_used=50)
  642. archive = MagicMock()
  643. archive.file_path = "archives/big_print.3mf"
  644. # Explicit numeric so the #1344 top-up branch doesn't trip a
  645. # MagicMock-vs-float comparison.
  646. archive.filament_used_grams = 14.2
  647. # Session was created at print start WITH snapshot
  648. _active_sessions[1] = PrintSession(
  649. printer_id=1,
  650. print_name="Big Print",
  651. started_at=datetime.now(timezone.utc),
  652. tray_remain_start={(0, 0): 90},
  653. spool_assignments={(0, 0): 8}, # Snapshot from print start
  654. )
  655. pm = _make_printer_manager(
  656. _make_printer_state(
  657. [{"id": 0, "tray": [{"id": 0, "remain": 75}]}],
  658. tray_now=0,
  659. )
  660. )
  661. filament_usage = [{"slot_id": 1, "used_g": 14.2, "type": "PLA", "color": "#FF0000"}]
  662. # db: archive, queue_item(None), live assignment(None), spool,
  663. # then cost aggregation queries
  664. # NOTE: No assignment in db — it was deleted by on_ams_change mid-print!
  665. db = AsyncMock()
  666. db.execute = AsyncMock(
  667. side_effect=[
  668. MagicMock(scalar_one_or_none=MagicMock(return_value=archive)),
  669. MagicMock(scalar_one_or_none=MagicMock(return_value=None)),
  670. MagicMock(scalar_one_or_none=MagicMock(return_value=None)),
  671. MagicMock(scalar_one_or_none=MagicMock(return_value=spool)),
  672. # Cost-update block re-selects the archive to mutate cost.
  673. MagicMock(scalar_one_or_none=MagicMock(return_value=archive)),
  674. ]
  675. )
  676. with (
  677. patch("backend.app.core.config.settings") as mock_settings,
  678. patch("backend.app.utils.threemf_tools.extract_filament_usage_from_3mf", return_value=filament_usage),
  679. ):
  680. mock_path = MagicMock()
  681. mock_path.exists.return_value = True
  682. mock_settings.base_dir.__truediv__ = MagicMock(return_value=mock_path)
  683. results = await on_print_complete(
  684. printer_id=1,
  685. data={"status": "completed"},
  686. printer_manager=pm,
  687. db=db,
  688. archive_id=100,
  689. )
  690. # Usage should be tracked despite assignment being deleted mid-print
  691. assert len(results) >= 1
  692. assert results[0]["spool_id"] == 8
  693. assert results[0]["weight_used"] == 14.2
  694. # Spool weight should be updated: 50 + 14.2 = 64.2
  695. assert spool.weight_used == 64.2
  696. class TestSpoolColorToHex:
  697. """`_spool_color_to_hex` normalises Spool.rgba (RRGGBBAA, no #) to #RRGGBB."""
  698. def test_strips_alpha_and_adds_hash(self):
  699. assert _spool_color_to_hex("000000FF") == "#000000"
  700. assert _spool_color_to_hex("EC984CFF") == "#EC984C"
  701. def test_uppercases(self):
  702. assert _spool_color_to_hex("ec984cff") == "#EC984C"
  703. def test_accepts_six_char_value(self):
  704. """A value with no alpha is still valid."""
  705. assert _spool_color_to_hex("161616") == "#161616"
  706. def test_tolerates_leading_hash(self):
  707. assert _spool_color_to_hex("#000000FF") == "#000000"
  708. def test_none_and_too_short_return_none(self):
  709. """Missing / malformed colour falls back to the 3MF value."""
  710. assert _spool_color_to_hex(None) is None
  711. assert _spool_color_to_hex("") is None
  712. assert _spool_color_to_hex("FFF") is None
  713. class TestArchiveColorsFromSpools:
  714. """`_archive_colors_from_spools` rebuilds an archive's filament_color from
  715. the inventory spools that fed the print (#1494). All-or-nothing: a partial
  716. match returns None so the 3MF colour is left intact."""
  717. def test_single_slot_matched(self):
  718. """The #1494 case: one used slot, matched to a #000000 spool."""
  719. usage = [{"slot_id": 1, "used_g": 15.9, "color": "#161616"}]
  720. results = [{"slot_id": 1, "color": "#000000"}]
  721. assert _archive_colors_from_spools(usage, results) == ["#000000"]
  722. def test_multi_slot_all_matched_keeps_slot_order(self):
  723. usage = [
  724. {"slot_id": 1, "used_g": 10.0, "color": "#111111"},
  725. {"slot_id": 2, "used_g": 20.0, "color": "#222222"},
  726. ]
  727. # results deliberately out of slot order — output must be slot-ordered
  728. results = [
  729. {"slot_id": 2, "color": "#00FF00"},
  730. {"slot_id": 1, "color": "#FF0000"},
  731. ]
  732. assert _archive_colors_from_spools(usage, results) == ["#FF0000", "#00FF00"]
  733. def test_duplicate_colors_deduplicated(self):
  734. """Two slots of the same spool colour collapse to one entry, as the
  735. 3MF-derived path also de-duplicates."""
  736. usage = [
  737. {"slot_id": 1, "used_g": 10.0, "color": "#111111"},
  738. {"slot_id": 2, "used_g": 20.0, "color": "#222222"},
  739. ]
  740. results = [
  741. {"slot_id": 1, "color": "#000000"},
  742. {"slot_id": 2, "color": "#000000"},
  743. ]
  744. assert _archive_colors_from_spools(usage, results) == ["#000000"]
  745. def test_partial_match_returns_none(self):
  746. """Slot 2 was used but never matched to a spool — leave the 3MF colour
  747. untouched rather than dropping slot 2 from the archive."""
  748. usage = [
  749. {"slot_id": 1, "used_g": 10.0, "color": "#111111"},
  750. {"slot_id": 2, "used_g": 20.0, "color": "#222222"},
  751. ]
  752. results = [{"slot_id": 1, "color": "#000000"}]
  753. assert _archive_colors_from_spools(usage, results) is None
  754. def test_matched_spool_without_color_returns_none(self):
  755. """A spool with no rgba (color None) does not count as matched."""
  756. usage = [{"slot_id": 1, "used_g": 15.0, "color": "#161616"}]
  757. results = [{"slot_id": 1, "color": None}]
  758. assert _archive_colors_from_spools(usage, results) is None
  759. def test_unused_slot_not_required(self):
  760. """A slot with zero usage need not be matched."""
  761. usage = [
  762. {"slot_id": 1, "used_g": 15.0, "color": "#161616"},
  763. {"slot_id": 2, "used_g": 0.0, "color": "#888888"},
  764. ]
  765. results = [{"slot_id": 1, "color": "#000000"}]
  766. assert _archive_colors_from_spools(usage, results) == ["#000000"]
  767. def test_no_used_slots_returns_none(self):
  768. assert _archive_colors_from_spools([], []) is None
  769. def test_ams_fallback_results_excluded(self):
  770. """AMS remain%-delta fallback results carry slot_id=None and must not
  771. satisfy the match for a real 3MF slot."""
  772. usage = [{"slot_id": 1, "used_g": 15.0, "color": "#161616"}]
  773. results = [{"slot_id": None, "color": "#000000"}]
  774. assert _archive_colors_from_spools(usage, results) is None
  775. class TestArchiveFilamentColorRewrite:
  776. """`_track_from_3mf` overwrites the archive's filament_color with the
  777. matched inventory spool colour at print completion (#1494)."""
  778. @pytest.mark.asyncio
  779. async def test_archive_color_adopts_spool_color(self):
  780. """A print from a #000000 inventory spool whose 3MF says #161616 ends
  781. up with the archive showing the spool's #000000."""
  782. spool = _make_spool(id=5, label_weight=1000, weight_used=100, rgba="000000FF")
  783. assignment = _make_assignment(spool_id=5)
  784. archive = MagicMock()
  785. archive.file_path = "archives/test.3mf"
  786. archive.filament_color = "#161616" # what archive.py set from the 3MF
  787. db = AsyncMock()
  788. db.execute = AsyncMock(
  789. side_effect=[
  790. MagicMock(scalar_one_or_none=MagicMock(return_value=archive)),
  791. MagicMock(scalar_one_or_none=MagicMock(return_value=None)),
  792. MagicMock(scalar_one_or_none=MagicMock(return_value=assignment)),
  793. MagicMock(scalar_one_or_none=MagicMock(return_value=spool)),
  794. ]
  795. )
  796. pm = _make_printer_manager(_make_printer_state([], tray_now=0))
  797. filament_usage = [{"slot_id": 1, "used_g": 25.5, "type": "PETG", "color": "#161616"}]
  798. with (
  799. patch("backend.app.core.config.settings") as mock_settings,
  800. patch("backend.app.utils.threemf_tools.extract_filament_usage_from_3mf", return_value=filament_usage),
  801. ):
  802. mock_path = MagicMock()
  803. mock_path.exists.return_value = True
  804. mock_settings.base_dir.__truediv__ = MagicMock(return_value=mock_path)
  805. results = await _track_from_3mf(
  806. printer_id=1,
  807. archive_id=10,
  808. status="completed",
  809. print_name="test_print",
  810. handled_trays=set(),
  811. printer_manager=pm,
  812. db=db,
  813. )
  814. assert len(results) == 1
  815. assert results[0]["color"] == "#000000"
  816. assert results[0]["slot_id"] == 1
  817. # The archive colour was rewritten from the slicer's #161616 to the
  818. # inventory spool's #000000.
  819. assert archive.filament_color == "#000000"
  820. @pytest.mark.asyncio
  821. async def test_archive_color_untouched_when_spool_has_no_color(self):
  822. """A spool with no rgba leaves the 3MF colour in place."""
  823. spool = _make_spool(id=5, label_weight=1000, weight_used=100, rgba=None)
  824. assignment = _make_assignment(spool_id=5)
  825. archive = MagicMock()
  826. archive.file_path = "archives/test.3mf"
  827. archive.filament_color = "#161616"
  828. db = AsyncMock()
  829. db.execute = AsyncMock(
  830. side_effect=[
  831. MagicMock(scalar_one_or_none=MagicMock(return_value=archive)),
  832. MagicMock(scalar_one_or_none=MagicMock(return_value=None)),
  833. MagicMock(scalar_one_or_none=MagicMock(return_value=assignment)),
  834. MagicMock(scalar_one_or_none=MagicMock(return_value=spool)),
  835. ]
  836. )
  837. pm = _make_printer_manager(_make_printer_state([], tray_now=0))
  838. filament_usage = [{"slot_id": 1, "used_g": 25.5, "type": "PETG", "color": "#161616"}]
  839. with (
  840. patch("backend.app.core.config.settings") as mock_settings,
  841. patch("backend.app.utils.threemf_tools.extract_filament_usage_from_3mf", return_value=filament_usage),
  842. ):
  843. mock_path = MagicMock()
  844. mock_path.exists.return_value = True
  845. mock_settings.base_dir.__truediv__ = MagicMock(return_value=mock_path)
  846. await _track_from_3mf(
  847. printer_id=1,
  848. archive_id=10,
  849. status="completed",
  850. print_name="test_print",
  851. handled_trays=set(),
  852. printer_manager=pm,
  853. db=db,
  854. )
  855. assert archive.filament_color == "#161616"