bambuddy/backend/tests/integration/test_locations_api.py

"""Integration tests for /inventory/locations (#1004)."""

import pytest
from httpx import AsyncClient
from sqlalchemy.ext.asyncio import AsyncSession

from backend.app.models.location import Location
from backend.app.services.location_service import assign_location_name


@pytest.mark.asyncio
@pytest.mark.integration
async def test_locations_crud_and_spool_link(async_client: AsyncClient, db_session: AsyncSession):
    create_resp = await async_client.post("/api/v1/inventory/locations", json={"name": "Shelf A"})
    assert create_resp.status_code == 201
    loc = create_resp.json()
    assert loc["name"] == "Shelf A"
    assert loc["spool_count"] == 0

    dup_resp = await async_client.post("/api/v1/inventory/locations", json={"name": "shelf a"})
    assert dup_resp.status_code == 409

    spool_resp = await async_client.post(
        "/api/v1/inventory/spools",
        json={"material": "PLA", "location_id": loc["id"]},
    )
    assert spool_resp.status_code == 200
    spool = spool_resp.json()
    assert spool["location_id"] == loc["id"]
    assert spool["storage_location"] == "Shelf A"

    list_resp = await async_client.get("/api/v1/inventory/locations")
    assert list_resp.status_code == 200
    listed = {item["id"]: item for item in list_resp.json()}
    assert listed[loc["id"]]["spool_count"] == 1

    delete_resp = await async_client.delete(f"/api/v1/inventory/locations/{loc['id']}")
    assert delete_resp.status_code == 409

    clear_resp = await async_client.patch(
        f"/api/v1/inventory/spools/{spool['id']}",
        json={"location_id": None},
    )
    assert clear_resp.status_code == 200

    delete_resp2 = await async_client.delete(f"/api/v1/inventory/locations/{loc['id']}")
    assert delete_resp2.status_code == 200


@pytest.mark.asyncio
@pytest.mark.integration
async def test_list_locations_sorts_naturally_not_lexicographically(async_client: AsyncClient):
    # Created out of order and with a name-shape ("Drybox N") that a plain
    # ORDER BY name would sort as "Drybox 1", "Drybox 10", "Drybox 2".
    for name in ["Drybox 10", "Drybox 2", "Drybox 1", "Shelf A"]:
        resp = await async_client.post("/api/v1/inventory/locations", json={"name": name})
        assert resp.status_code == 201, resp.text

    list_resp = await async_client.get("/api/v1/inventory/locations")
    assert list_resp.status_code == 200
    names = [loc["name"] for loc in list_resp.json()]
    assert names == ["Drybox 1", "Drybox 2", "Drybox 10", "Shelf A"]


@pytest.mark.asyncio
@pytest.mark.integration
async def test_rename_location_updates_spool_count(async_client: AsyncClient):
    create_resp = await async_client.post("/api/v1/inventory/locations", json={"name": "Old Name"})
    loc = create_resp.json()

    await async_client.post(
        "/api/v1/inventory/spools",
        json={"material": "PLA", "location_id": loc["id"]},
    )

    list_before = await async_client.get("/api/v1/inventory/locations")
    by_id = {item["id"]: item for item in list_before.json()}
    assert by_id[loc["id"]]["spool_count"] == 1

    rename_resp = await async_client.patch(
        f"/api/v1/inventory/locations/{loc['id']}",
        json={"name": "New Name"},
    )
    assert rename_resp.status_code == 200
    assert rename_resp.json()["name"] == "New Name"
    assert rename_resp.json()["spool_count"] == 1


@pytest.mark.asyncio
@pytest.mark.integration
async def test_rename_location_collision_returns_409(async_client: AsyncClient):
    first = await async_client.post("/api/v1/inventory/locations", json={"name": "Shelf A"})
    second = await async_client.post("/api/v1/inventory/locations", json={"name": "Shelf B"})
    assert first.status_code == 201
    assert second.status_code == 201

    collision = await async_client.patch(
        f"/api/v1/inventory/locations/{second.json()['id']}",
        json={"name": "Shelf A"},
    )
    assert collision.status_code == 409
    assert collision.json()["detail"] == "A location with this name already exists"


@pytest.mark.asyncio
@pytest.mark.integration
async def test_create_location_duplicate_after_commit_returns_409(async_client: AsyncClient):
    """Second create with the same name_key must return 409, not 500."""
    first = await async_client.post("/api/v1/inventory/locations", json={"name": "Race Shelf"})
    second = await async_client.post("/api/v1/inventory/locations", json={"name": "race shelf"})
    assert first.status_code == 201
    assert second.status_code == 409
    assert second.json()["detail"] == "A location with this name already exists"


@pytest.mark.asyncio
@pytest.mark.integration
async def test_list_locations_is_read_only(async_client: AsyncClient, db_session: AsyncSession):
    """GET /locations is a pure read — no catalog rows appear without explicit writes."""
    from sqlalchemy import func, select

    loc = Location()
    assign_location_name(loc, "Local Only")
    db_session.add(loc)
    await db_session.commit()

    before = await db_session.scalar(select(func.count()).select_from(Location))
    resp = await async_client.get("/api/v1/inventory/locations")
    after = await db_session.scalar(select(func.count()).select_from(Location))

    assert resp.status_code == 200
    assert len(resp.json()) == 1
    assert before == after == 1


@pytest.mark.asyncio
@pytest.mark.integration
async def test_update_location_404_on_unknown_id(async_client: AsyncClient):
    resp = await async_client.patch(
        "/api/v1/inventory/locations/99999",
        json={"name": "Ghost"},
    )
    assert resp.status_code == 404
    assert resp.json()["detail"] == "Location not found"


@pytest.mark.asyncio
@pytest.mark.integration
async def test_delete_location_404_on_unknown_id(async_client: AsyncClient):
    resp = await async_client.delete("/api/v1/inventory/locations/99999")
    assert resp.status_code == 404
    assert resp.json()["detail"] == "Location not found"


@pytest.mark.asyncio
@pytest.mark.integration
async def test_locations_routes_require_auth_when_enabled(async_client: AsyncClient):
    """All five /locations endpoints must return 401 when auth is enabled and
    no credentials are presented. Mirror of the pattern from
    test_queue_start_user_attribution._enable_auth_with_admin — required by
    project policy: every permission-gated route gets a fail-closed test on
    first ship, no follow-ups (the two CVSS 9.8/9.9 advisories shipped from
    this exact gap)."""
    await async_client.post(
        "/api/v1/auth/setup",
        json={
            "auth_enabled": True,
            "admin_username": "locations1505admin",
            "admin_password": "AdminPass1!",
        },
    )

    # GET /locations — read-gated
    list_resp = await async_client.get("/api/v1/inventory/locations")
    assert list_resp.status_code == 401, list_resp.text

    # POST /locations — write-gated
    create_resp = await async_client.post("/api/v1/inventory/locations", json={"name": "Locked"})
    assert create_resp.status_code == 401, create_resp.text

    # PATCH /locations/{id} — write-gated. Use a synthetic id; the auth gate
    # runs before the not-found check, so 401 is the correct expectation even
    # when the id doesn't exist.
    patch_resp = await async_client.patch("/api/v1/inventory/locations/99999", json={"name": "Locked2"})
    assert patch_resp.status_code == 401, patch_resp.text

    # DELETE /locations/{id} — write-gated
    delete_resp = await async_client.delete("/api/v1/inventory/locations/99999")
    assert delete_resp.status_code == 401, delete_resp.text