bambuddy/spoolbuddy/tests/test_api_client.py

"""Tests for daemon.api_client — APIClient HTTP communication."""

import asyncio
from unittest.mock import AsyncMock, MagicMock, patch

import httpx
import pytest
from daemon.api_client import MAX_BUFFER_SIZE, WRITE_RESULT_PATH, APIClient


@pytest.fixture
def api():
    return APIClient("http://localhost:5000", "test-key")


class TestAPIClientInit:
    def test_base_url_construction(self, api):
        assert api._base == "http://localhost:5000/api/v1/spoolbuddy"

    def test_base_url_strips_trailing_slash(self):
        client = APIClient("http://localhost:5000/", "key")
        assert client._base == "http://localhost:5000/api/v1/spoolbuddy"

    def test_api_key_in_headers(self):
        client = APIClient("http://localhost:5000", "my-key")
        assert client._headers == {"X-API-Key": "my-key"}

    def test_no_api_key_empty_headers(self):
        client = APIClient("http://localhost:5000", "")
        assert client._headers == {}


class TestPost:
    @pytest.mark.asyncio
    async def test_post_success(self, api):
        mock_resp = MagicMock()
        mock_resp.status_code = 200
        mock_resp.json.return_value = {"ok": True}
        mock_resp.raise_for_status = MagicMock()

        api._client.post = AsyncMock(return_value=mock_resp)

        result = await api._post("/test", {"key": "value"})

        assert result == {"ok": True}
        assert api._connected is True
        assert api._backoff == 1.0
        api._client.post.assert_awaited_once()

    @pytest.mark.asyncio
    async def test_post_failure_buffers_request(self, api):
        api._client.post = AsyncMock(side_effect=httpx.ConnectError("refused"))

        result = await api._post("/test", {"data": 1})

        assert result is None
        assert len(api._buffer) == 1
        assert api._buffer[0] == {"path": "/test", "data": {"data": 1}}

    @pytest.mark.asyncio
    async def test_a_buffered_write_result_is_reported(self, api):
        # #3076: main must know a tag write's result is still unsent.
        api._client.post = AsyncMock(side_effect=httpx.ConnectError("down"))
        assert not api.has_buffered(WRITE_RESULT_PATH)

        await api.write_tag_result("dev-1", 7, "04A1", True, "ok")

        assert api.has_buffered(WRITE_RESULT_PATH)
        assert not api.has_buffered("/heartbeat")

    @pytest.mark.asyncio
    async def test_post_failure_logs_connection_lost_once(self, api):
        api._connected = True
        api._client.post = AsyncMock(side_effect=httpx.ConnectError("refused"))

        await api._post("/a", {})
        assert api._connected is False

        # Second failure should not log "connection lost" again
        await api._post("/b", {})
        assert len(api._buffer) == 2

    @pytest.mark.asyncio
    async def test_post_success_resets_backoff(self, api):
        api._backoff = 16.0
        mock_resp = MagicMock()
        mock_resp.json.return_value = {}
        mock_resp.raise_for_status = MagicMock()
        api._client.post = AsyncMock(return_value=mock_resp)

        await api._post("/test", {})

        assert api._backoff == 1.0

    @pytest.mark.asyncio
    async def test_buffer_max_size(self, api):
        api._client.post = AsyncMock(side_effect=httpx.ConnectError("refused"))

        for i in range(MAX_BUFFER_SIZE + 20):
            await api._post("/test", {"i": i})

        assert len(api._buffer) == MAX_BUFFER_SIZE
        # Oldest entries should have been dropped (deque maxlen behavior)
        assert api._buffer[0]["data"]["i"] == 20


class TestHeartbeat:
    @pytest.mark.asyncio
    async def test_heartbeat_posts_to_correct_path(self, api):
        mock_resp = MagicMock()
        mock_resp.json.return_value = {"pending_command": None}
        mock_resp.raise_for_status = MagicMock()
        api._client.post = AsyncMock(return_value=mock_resp)

        result = await api.heartbeat(
            device_id="dev-1",
            nfc_ok=True,
            scale_ok=False,
            uptime_s=120,
            ip_address="192.168.1.50",
            firmware_version="0.2.2b1",
        )

        assert result == {"pending_command": None}
        call_args = api._client.post.call_args
        assert "/devices/dev-1/heartbeat" in call_args[0][0]

    @pytest.mark.asyncio
    async def test_heartbeat_flushes_buffer_on_success(self, api):
        # Pre-populate buffer
        api._buffer.append({"path": "/old", "data": {"x": 1}})

        mock_resp = MagicMock()
        mock_resp.json.return_value = {"ok": True}
        mock_resp.raise_for_status = MagicMock()
        api._client.post = AsyncMock(return_value=mock_resp)

        await api.heartbeat(device_id="d", nfc_ok=True, scale_ok=True, uptime_s=0)

        # Buffer should be flushed (post called for heartbeat + 1 buffered item)
        assert len(api._buffer) == 0

    @pytest.mark.asyncio
    async def test_heartbeat_returns_none_on_failure(self, api):
        api._client.post = AsyncMock(side_effect=httpx.ConnectError("fail"))

        result = await api.heartbeat(device_id="d", nfc_ok=True, scale_ok=True, uptime_s=0)

        assert result is None


class TestRegisterDevice:
    @pytest.mark.asyncio
    async def test_register_retries_until_success(self, api):
        mock_resp = MagicMock()
        mock_resp.json.return_value = {"device_id": "dev-1"}
        mock_resp.raise_for_status = MagicMock()

        # Fail twice, then succeed
        call_count = 0

        async def mock_post(*args, **kwargs):
            nonlocal call_count
            call_count += 1
            if call_count <= 2:
                raise httpx.ConnectError("refused")
            return mock_resp

        api._client.post = mock_post
        # Speed up retries
        api._backoff = 0.01
        api._max_backoff = 0.02

        result = await api.register_device(
            device_id="dev-1",
            hostname="test",
            ip_address="1.2.3.4",
        )

        assert result == {"device_id": "dev-1"}
        assert call_count == 3

    @pytest.mark.asyncio
    async def test_register_sends_all_fields(self, api):
        mock_resp = MagicMock()
        mock_resp.json.return_value = {"ok": True}
        mock_resp.raise_for_status = MagicMock()
        api._client.post = AsyncMock(return_value=mock_resp)

        await api.register_device(
            device_id="dev-1",
            hostname="myhost",
            ip_address="10.0.0.1",
            firmware_version="0.2.2b1",
            has_nfc=True,
            has_scale=False,
            tare_offset=100,
            calibration_factor=1.05,
            nfc_reader_type="PN532",
            nfc_connection="SPI",
            has_backlight=True,
        )

        call_args = api._client.post.call_args
        payload = call_args[1]["json"]
        assert payload["device_id"] == "dev-1"
        assert payload["has_backlight"] is True
        assert payload["calibration_factor"] == 1.05


def _status_error(code: int, detail: str | None = None) -> httpx.HTTPStatusError:
    request = httpx.Request("POST", "http://localhost:5000/x")
    body = {"json": {"detail": detail}} if detail is not None else {}
    return httpx.HTTPStatusError("rejected", request=request, response=httpx.Response(code, request=request, **body))


class TestTagScanned:
    @pytest.mark.asyncio
    async def test_sends_raw_blocks(self, api):
        api._post = AsyncMock(return_value={"status": "ok"})
        raw = {"1": "4130302D423038004746413030000000", "9": "36B6C12DB3DA4A39A50C275F510BD399"}

        await api.tag_scanned("sb-1", "865947E2", tray_uuid="36B6C12DB3DA4A39A50C275F510BD399", raw_blocks=raw)

        path, payload = api._post.await_args.args
        assert path == "/nfc/tag-scanned"
        assert payload["raw_blocks"] == raw
        assert payload["tray_uuid"] == "36B6C12DB3DA4A39A50C275F510BD399"

    @pytest.mark.asyncio
    async def test_raw_blocks_default_to_none(self, api):
        api._post = AsyncMock(return_value={"status": "ok"})

        await api.tag_scanned("sb-1", "04A1B2C3D4E5F6")

        _, payload = api._post.await_args.args
        assert payload["raw_blocks"] is None


class TestRejectedRequests:
    """A request the backend refuses is not a connection problem: buffering it
    replays it forever, and the flush stops at the first item that fails."""

    @pytest.mark.asyncio
    async def test_a_heartbeat_for_an_unregistered_device_is_not_buffered(self, api):
        resp = MagicMock()
        resp.raise_for_status = MagicMock(side_effect=_status_error(404, "Device not registered"))
        api._client.post = AsyncMock(return_value=resp)

        result = await api.heartbeat(device_id="dev-1", nfc_ok=True, scale_ok=True, uptime_s=1)

        assert result is None
        assert len(api._buffer) == 0
        assert api.unregistered is True

    @pytest.mark.asyncio
    async def test_a_proxys_bare_404_is_not_taken_for_an_unregistered_device(self, api):
        """A reverse proxy answers 404 while Bambuddy restarts."""
        resp = MagicMock()
        resp.raise_for_status = MagicMock(side_effect=_status_error(404))
        api._client.post = AsyncMock(return_value=resp)

        await api.heartbeat(device_id="dev-1", nfc_ok=True, scale_ok=True, uptime_s=1)

        assert api.unregistered is False

    @pytest.mark.asyncio
    async def test_a_connection_error_is_still_buffered(self, api):
        api._client.post = AsyncMock(side_effect=httpx.ConnectError("refused"))

        await api.heartbeat(device_id="dev-1", nfc_ok=True, scale_ok=True, uptime_s=1)

        assert len(api._buffer) == 1
        assert api.unregistered is False

    @pytest.mark.asyncio
    async def test_a_rejected_buffered_item_does_not_block_the_rest(self, api):
        api._buffer.append({"path": "/devices/dev-1/heartbeat", "data": {}})
        api._buffer.append({"path": "/scale/reading", "data": {"w": 1}})
        rejected = MagicMock(raise_for_status=MagicMock(side_effect=_status_error(404)))
        accepted = MagicMock(raise_for_status=MagicMock())
        api._client.post = AsyncMock(side_effect=[rejected, accepted])

        await api._flush_buffer()

        assert len(api._buffer) == 0
        assert api._client.post.await_count == 2