test_spoolman_api.py 32 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793
  1. """Integration tests for Spoolman API endpoints."""
  2. from unittest.mock import AsyncMock, MagicMock, patch
  3. import pytest
  4. from httpx import AsyncClient
  5. class TestSpoolmanAPI:
  6. """Integration tests for /api/v1/spoolman/ endpoints."""
  7. @pytest.fixture
  8. async def spoolman_settings(self, db_session):
  9. """Create Spoolman settings in the database (enabled with URL)."""
  10. from backend.app.models.settings import Settings
  11. # Both settings are required for Spoolman to work
  12. enabled_setting = Settings(key="spoolman_enabled", value="true")
  13. url_setting = Settings(key="spoolman_url", value="http://localhost:7912")
  14. db_session.add(enabled_setting)
  15. db_session.add(url_setting)
  16. await db_session.commit()
  17. return {"enabled": enabled_setting, "url": url_setting}
  18. @pytest.fixture
  19. async def spoolman_url_only(self, db_session):
  20. """Create only the URL setting (not enabled)."""
  21. from backend.app.models.settings import Settings
  22. setting = Settings(key="spoolman_url", value="http://localhost:7912")
  23. db_session.add(setting)
  24. await db_session.commit()
  25. return setting
  26. @pytest.fixture
  27. def mock_spoolman_client(self):
  28. """Mock the Spoolman client functions."""
  29. mock_client = MagicMock()
  30. mock_client.is_connected = True
  31. mock_client.base_url = "http://localhost:7912"
  32. mock_client.health_check = AsyncMock(return_value=True)
  33. mock_client.ensure_tag_extra_field = AsyncMock(return_value=True)
  34. mock_client.get_spools = AsyncMock(return_value=[])
  35. mock_client.get_filaments = AsyncMock(return_value=[])
  36. mock_client.create_spool = AsyncMock(return_value={"id": 1})
  37. mock_client.update_spool = AsyncMock(return_value={"id": 1})
  38. mock_client.close = AsyncMock()
  39. with (
  40. patch(
  41. "backend.app.api.routes.spoolman.get_spoolman_client",
  42. AsyncMock(return_value=mock_client),
  43. ),
  44. patch(
  45. "backend.app.api.routes.spoolman.init_spoolman_client",
  46. AsyncMock(return_value=mock_client),
  47. ),
  48. patch(
  49. "backend.app.api.routes.spoolman.close_spoolman_client",
  50. AsyncMock(),
  51. ),
  52. ):
  53. yield mock_client
  54. @pytest.fixture
  55. def mock_spoolman_disconnected(self):
  56. """Mock the Spoolman client as disconnected (returns None)."""
  57. with (
  58. patch(
  59. "backend.app.api.routes.spoolman.get_spoolman_client",
  60. AsyncMock(return_value=None),
  61. ),
  62. patch(
  63. "backend.app.api.routes.spoolman.init_spoolman_client",
  64. AsyncMock(return_value=None),
  65. ),
  66. ):
  67. yield
  68. # =========================================================================
  69. # Status Endpoint Tests
  70. # =========================================================================
  71. @pytest.mark.asyncio
  72. @pytest.mark.integration
  73. async def test_get_status_not_configured(self, async_client: AsyncClient):
  74. """Verify status shows not enabled when no settings exist."""
  75. response = await async_client.get("/api/v1/spoolman/status")
  76. assert response.status_code == 200
  77. data = response.json()
  78. assert data["enabled"] is False
  79. assert data["connected"] is False
  80. @pytest.mark.asyncio
  81. @pytest.mark.integration
  82. async def test_get_status_url_only_not_enabled(self, async_client: AsyncClient, spoolman_url_only):
  83. """Verify status shows not enabled when only URL is set."""
  84. response = await async_client.get("/api/v1/spoolman/status")
  85. assert response.status_code == 200
  86. data = response.json()
  87. assert data["enabled"] is False
  88. assert data["url"] == "http://localhost:7912"
  89. @pytest.mark.asyncio
  90. @pytest.mark.integration
  91. async def test_get_status_enabled_and_connected(
  92. self, async_client: AsyncClient, spoolman_settings, mock_spoolman_client
  93. ):
  94. """Verify status shows enabled and connected when properly configured."""
  95. response = await async_client.get("/api/v1/spoolman/status")
  96. assert response.status_code == 200
  97. data = response.json()
  98. assert data["enabled"] is True
  99. assert data["connected"] is True
  100. assert data["url"] == "http://localhost:7912"
  101. # =========================================================================
  102. # Connect/Disconnect Tests
  103. # =========================================================================
  104. @pytest.mark.asyncio
  105. @pytest.mark.integration
  106. async def test_connect_not_enabled(self, async_client: AsyncClient):
  107. """Verify connect fails when not enabled."""
  108. response = await async_client.post("/api/v1/spoolman/connect")
  109. assert response.status_code == 400
  110. assert "not enabled" in response.json()["detail"].lower()
  111. @pytest.mark.asyncio
  112. @pytest.mark.integration
  113. async def test_connect_success(self, async_client: AsyncClient, spoolman_settings, mock_spoolman_client):
  114. """Verify successful connection to Spoolman."""
  115. response = await async_client.post("/api/v1/spoolman/connect")
  116. assert response.status_code == 200
  117. data = response.json()
  118. assert data["success"] is True
  119. assert "connected" in data["message"].lower()
  120. @pytest.mark.asyncio
  121. @pytest.mark.integration
  122. async def test_disconnect(self, async_client: AsyncClient, spoolman_settings, mock_spoolman_client):
  123. """Verify disconnect works."""
  124. response = await async_client.post("/api/v1/spoolman/disconnect")
  125. assert response.status_code == 200
  126. assert "disconnected" in response.json()["message"].lower()
  127. # =========================================================================
  128. # Spools Endpoint Tests
  129. # =========================================================================
  130. @pytest.mark.asyncio
  131. @pytest.mark.integration
  132. async def test_get_spools_not_enabled(self, async_client: AsyncClient):
  133. """Verify get spools fails when not enabled."""
  134. response = await async_client.get("/api/v1/spoolman/spools")
  135. assert response.status_code == 400
  136. assert "not enabled" in response.json()["detail"].lower()
  137. @pytest.mark.asyncio
  138. @pytest.mark.integration
  139. async def test_get_spools_success(self, async_client: AsyncClient, spoolman_settings, mock_spoolman_client):
  140. """Verify get spools returns data in expected format."""
  141. mock_spool = {
  142. "id": 1,
  143. "remaining_weight": 500,
  144. "used_weight": 500,
  145. "filament": {
  146. "id": 1,
  147. "name": "PLA Basic",
  148. "material": "PLA",
  149. "color_hex": "FF0000",
  150. },
  151. "first_used": "2024-01-01",
  152. "last_used": "2024-01-15",
  153. "location": "AMS1",
  154. "lot_nr": "LOT123",
  155. "comment": "Test spool",
  156. "extra": {"tag": '"ABC123"'},
  157. }
  158. mock_spoolman_client.get_spools = AsyncMock(return_value=[mock_spool])
  159. response = await async_client.get("/api/v1/spoolman/spools")
  160. assert response.status_code == 200
  161. data = response.json()
  162. assert "spools" in data
  163. assert isinstance(data["spools"], list)
  164. assert len(data["spools"]) == 1
  165. assert data["spools"][0]["id"] == 1
  166. # =========================================================================
  167. # Unlinked Spools Tests
  168. # =========================================================================
  169. @pytest.mark.asyncio
  170. @pytest.mark.integration
  171. async def test_get_unlinked_spools_not_enabled(self, async_client: AsyncClient):
  172. """Verify get unlinked spools fails when not enabled."""
  173. response = await async_client.get("/api/v1/spoolman/spools/unlinked")
  174. assert response.status_code == 400
  175. @pytest.mark.asyncio
  176. @pytest.mark.integration
  177. async def test_get_unlinked_spools_success(
  178. self, async_client: AsyncClient, spoolman_settings, mock_spoolman_client
  179. ):
  180. """Verify get unlinked spools returns spools without tags."""
  181. # Mock spool without extra.tag (unlinked)
  182. mock_spool = {
  183. "id": 1,
  184. "remaining_weight": 800,
  185. "used_weight": 200,
  186. "extra": {}, # No tag = unlinked
  187. "filament": {
  188. "id": 1,
  189. "name": "PLA Basic",
  190. "material": "PLA",
  191. "color_hex": "FF0000",
  192. },
  193. "location": "Shelf A",
  194. }
  195. mock_spoolman_client.get_spools = AsyncMock(return_value=[mock_spool])
  196. response = await async_client.get("/api/v1/spoolman/spools/unlinked")
  197. assert response.status_code == 200
  198. data = response.json()
  199. assert isinstance(data, list)
  200. assert len(data) == 1
  201. assert data[0]["id"] == 1
  202. assert data[0]["filament_name"] == "PLA Basic"
  203. @pytest.mark.asyncio
  204. @pytest.mark.integration
  205. async def test_get_unlinked_spools_excludes_linked(
  206. self, async_client: AsyncClient, spoolman_settings, mock_spoolman_client
  207. ):
  208. """Verify linked spools (with tag) are excluded."""
  209. # Mock spool with extra.tag (linked)
  210. mock_spool_linked = {
  211. "id": 1,
  212. "remaining_weight": 800,
  213. "used_weight": 200,
  214. "extra": {"tag": '"ABC123"'}, # Has tag = linked
  215. "filament": {"id": 1, "name": "PLA Red", "material": "PLA", "color_hex": "FF0000"},
  216. }
  217. # Mock spool without tag (unlinked)
  218. mock_spool_unlinked = {
  219. "id": 2,
  220. "remaining_weight": 900,
  221. "used_weight": 100,
  222. "extra": {}, # No tag = unlinked
  223. "filament": {"id": 2, "name": "PLA Blue", "material": "PLA", "color_hex": "0000FF"},
  224. }
  225. mock_spoolman_client.get_spools = AsyncMock(return_value=[mock_spool_linked, mock_spool_unlinked])
  226. response = await async_client.get("/api/v1/spoolman/spools/unlinked")
  227. assert response.status_code == 200
  228. data = response.json()
  229. assert len(data) == 1
  230. assert data[0]["id"] == 2 # Only unlinked spool
  231. # =========================================================================
  232. # Linked Spools Tests
  233. # =========================================================================
  234. @pytest.mark.asyncio
  235. @pytest.mark.integration
  236. async def test_get_linked_spools_not_enabled(self, async_client: AsyncClient):
  237. """Verify get linked spools fails when not enabled."""
  238. response = await async_client.get("/api/v1/spoolman/spools/linked")
  239. assert response.status_code == 400
  240. @pytest.mark.asyncio
  241. @pytest.mark.integration
  242. async def test_get_linked_spools_success(self, async_client: AsyncClient, spoolman_settings, mock_spoolman_client):
  243. """Verify get linked spools returns map of tag -> spool_id."""
  244. # Mock spool with extra.tag (linked)
  245. mock_spool = {
  246. "id": 42,
  247. "remaining_weight": 800,
  248. "extra": {"tag": '"A1B2C3D4E5F6A1B2C3D4E5F6A1B2C3D4"'},
  249. "filament": {"id": 1, "name": "PLA Red", "material": "PLA", "weight": 1000},
  250. }
  251. mock_spoolman_client.get_spools = AsyncMock(return_value=[mock_spool])
  252. response = await async_client.get("/api/v1/spoolman/spools/linked")
  253. assert response.status_code == 200
  254. data = response.json()
  255. assert "linked" in data
  256. assert isinstance(data["linked"], dict)
  257. # Tag should be uppercase and stripped of quotes
  258. assert "A1B2C3D4E5F6A1B2C3D4E5F6A1B2C3D4" in data["linked"]
  259. linked_info = data["linked"]["A1B2C3D4E5F6A1B2C3D4E5F6A1B2C3D4"]
  260. assert linked_info["id"] == 42
  261. assert linked_info["remaining_weight"] == 800
  262. assert linked_info["filament_weight"] == 1000
  263. @pytest.mark.asyncio
  264. @pytest.mark.integration
  265. async def test_get_linked_spools_excludes_unlinked(
  266. self, async_client: AsyncClient, spoolman_settings, mock_spoolman_client
  267. ):
  268. """Verify unlinked spools (without tag) are excluded."""
  269. # Mock spool with tag (linked)
  270. mock_spool_linked = {
  271. "id": 1,
  272. "extra": {"tag": '"ABC12345678901234567890123456789A"'},
  273. "filament": {"id": 1, "name": "PLA Red", "material": "PLA"},
  274. }
  275. # Mock spool without tag (unlinked)
  276. mock_spool_unlinked = {
  277. "id": 2,
  278. "extra": {},
  279. "filament": {"id": 2, "name": "PLA Blue", "material": "PLA"},
  280. }
  281. mock_spoolman_client.get_spools = AsyncMock(return_value=[mock_spool_linked, mock_spool_unlinked])
  282. response = await async_client.get("/api/v1/spoolman/spools/linked")
  283. assert response.status_code == 200
  284. data = response.json()
  285. assert len(data["linked"]) == 1 # Only linked spool
  286. @pytest.mark.asyncio
  287. @pytest.mark.integration
  288. async def test_get_linked_spools_empty_tag_excluded(
  289. self, async_client: AsyncClient, spoolman_settings, mock_spoolman_client
  290. ):
  291. """Verify spools with empty tag (JSON-encoded empty string) are excluded."""
  292. # Mock spool with empty JSON-encoded tag
  293. mock_spool = {
  294. "id": 1,
  295. "extra": {"tag": '""'}, # JSON-encoded empty string
  296. "filament": {"id": 1, "name": "PLA Red", "material": "PLA"},
  297. }
  298. mock_spoolman_client.get_spools = AsyncMock(return_value=[mock_spool])
  299. response = await async_client.get("/api/v1/spoolman/spools/linked")
  300. assert response.status_code == 200
  301. data = response.json()
  302. assert len(data["linked"]) == 0 # Empty tag should be excluded
  303. @pytest.mark.asyncio
  304. @pytest.mark.integration
  305. async def test_get_linked_spools_includes_weight_data(
  306. self, async_client: AsyncClient, spoolman_settings, mock_spoolman_client
  307. ):
  308. """Verify linked spools response includes remaining_weight and filament_weight."""
  309. mock_spool = {
  310. "id": 10,
  311. "remaining_weight": 500.5,
  312. "extra": {"tag": '"AABB11223344556677889900AABBCCDD"'},
  313. "filament": {"id": 1, "name": "PETG Blue", "material": "PETG", "weight": 750},
  314. }
  315. mock_spoolman_client.get_spools = AsyncMock(return_value=[mock_spool])
  316. response = await async_client.get("/api/v1/spoolman/spools/linked")
  317. assert response.status_code == 200
  318. data = response.json()
  319. info = data["linked"]["AABB11223344556677889900AABBCCDD"]
  320. assert info["id"] == 10
  321. assert info["remaining_weight"] == 500.5
  322. assert info["filament_weight"] == 750
  323. @pytest.mark.asyncio
  324. @pytest.mark.integration
  325. async def test_get_linked_spools_missing_weight_fields(
  326. self, async_client: AsyncClient, spoolman_settings, mock_spoolman_client
  327. ):
  328. """Verify linked spools handles missing weight data gracefully."""
  329. mock_spool = {
  330. "id": 5,
  331. "extra": {"tag": '"CCDD11223344556677889900AABBCCDD"'},
  332. "filament": {"id": 1, "name": "PLA Red", "material": "PLA"},
  333. }
  334. mock_spoolman_client.get_spools = AsyncMock(return_value=[mock_spool])
  335. response = await async_client.get("/api/v1/spoolman/spools/linked")
  336. assert response.status_code == 200
  337. data = response.json()
  338. info = data["linked"]["CCDD11223344556677889900AABBCCDD"]
  339. assert info["id"] == 5
  340. assert info["remaining_weight"] is None
  341. assert info["filament_weight"] is None
  342. @pytest.mark.asyncio
  343. @pytest.mark.integration
  344. async def test_get_linked_spools_null_filament(
  345. self, async_client: AsyncClient, spoolman_settings, mock_spoolman_client
  346. ):
  347. """Verify linked spools handles null filament object."""
  348. mock_spool = {
  349. "id": 7,
  350. "remaining_weight": 300,
  351. "extra": {"tag": '"EEFF11223344556677889900AABBCCDD"'},
  352. "filament": None,
  353. }
  354. mock_spoolman_client.get_spools = AsyncMock(return_value=[mock_spool])
  355. response = await async_client.get("/api/v1/spoolman/spools/linked")
  356. assert response.status_code == 200
  357. data = response.json()
  358. info = data["linked"]["EEFF11223344556677889900AABBCCDD"]
  359. assert info["id"] == 7
  360. assert info["remaining_weight"] == 300
  361. assert info["filament_weight"] is None
  362. # =========================================================================
  363. # Link Spool Tests
  364. # =========================================================================
  365. @pytest.mark.asyncio
  366. @pytest.mark.integration
  367. async def test_link_spool_not_enabled(self, async_client: AsyncClient):
  368. """Verify link spool fails when not enabled."""
  369. response = await async_client.post(
  370. "/api/v1/spoolman/spools/1/link",
  371. json={"tray_uuid": "A1B2C3D4E5F6A1B2C3D4E5F6A1B2C3D4"},
  372. )
  373. assert response.status_code == 400
  374. @pytest.mark.asyncio
  375. @pytest.mark.integration
  376. async def test_link_spool_invalid_uuid_length(
  377. self, async_client: AsyncClient, spoolman_settings, mock_spoolman_client
  378. ):
  379. """Verify link spool fails with invalid UUID length."""
  380. response = await async_client.post(
  381. "/api/v1/spoolman/spools/1/link",
  382. json={"tray_uuid": "ABC123"}, # Too short
  383. )
  384. assert response.status_code == 400
  385. assert "16 or 32 hex characters" in response.json()["detail"]
  386. @pytest.mark.asyncio
  387. @pytest.mark.integration
  388. async def test_link_spool_invalid_uuid_format(
  389. self, async_client: AsyncClient, spoolman_settings, mock_spoolman_client
  390. ):
  391. """Verify link spool fails with non-hex UUID."""
  392. response = await async_client.post(
  393. "/api/v1/spoolman/spools/1/link",
  394. json={"tray_uuid": "ZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZ"}, # Not hex
  395. )
  396. assert response.status_code == 400
  397. assert "hex" in response.json()["detail"].lower()
  398. @pytest.mark.asyncio
  399. @pytest.mark.integration
  400. async def test_link_spool_success(self, async_client: AsyncClient, spoolman_settings, mock_spoolman_client):
  401. """Verify successfully linking a spool to AMS tray."""
  402. mock_spoolman_client.update_spool = AsyncMock(
  403. return_value={"id": 1, "extra": {"tag": '"A1B2C3D4E5F6A1B2C3D4E5F6A1B2C3D4"'}}
  404. )
  405. response = await async_client.post(
  406. "/api/v1/spoolman/spools/1/link",
  407. json={"tray_uuid": "A1B2C3D4E5F6A1B2C3D4E5F6A1B2C3D4"},
  408. )
  409. assert response.status_code == 200
  410. data = response.json()
  411. assert data["success"] is True
  412. assert "linked" in data["message"].lower()
  413. # Verify update_spool was called
  414. mock_spoolman_client.update_spool.assert_called_once()
  415. @pytest.mark.asyncio
  416. @pytest.mark.integration
  417. async def test_unlink_spool_success(self, async_client: AsyncClient, spoolman_settings, mock_spoolman_client):
  418. """Verify successfully unlinking a spool clears extra.tag."""
  419. mock_spoolman_client.update_spool = AsyncMock(return_value={"id": 1, "extra": {"tag": '""'}})
  420. response = await async_client.post("/api/v1/spoolman/spools/1/unlink")
  421. assert response.status_code == 200
  422. data = response.json()
  423. assert data["success"] is True
  424. assert "unlinked" in data["message"].lower()
  425. mock_spoolman_client.update_spool.assert_called_once_with(
  426. spool_id=1,
  427. clear_location=True,
  428. extra={"tag": '""'},
  429. )
  430. # =========================================================================
  431. # Sync Tests
  432. # =========================================================================
  433. @pytest.mark.asyncio
  434. @pytest.mark.integration
  435. async def test_sync_printer_not_enabled(self, async_client: AsyncClient, printer_factory):
  436. """Verify sync fails when Spoolman not enabled."""
  437. printer = await printer_factory()
  438. response = await async_client.post(f"/api/v1/spoolman/sync/{printer.id}")
  439. assert response.status_code == 400
  440. assert "not enabled" in response.json()["detail"].lower()
  441. @pytest.mark.asyncio
  442. @pytest.mark.integration
  443. async def test_sync_printer_not_found(self, async_client: AsyncClient, spoolman_settings, mock_spoolman_client):
  444. """Verify sync fails for non-existent printer."""
  445. response = await async_client.post("/api/v1/spoolman/sync/9999")
  446. assert response.status_code == 404
  447. @pytest.mark.asyncio
  448. @pytest.mark.integration
  449. async def test_sync_returns_result_structure(
  450. self,
  451. async_client: AsyncClient,
  452. spoolman_settings,
  453. mock_spoolman_client,
  454. printer_factory,
  455. ):
  456. """Verify sync returns proper result structure."""
  457. printer = await printer_factory()
  458. # Mock printer manager to return AMS data
  459. with patch("backend.app.api.routes.spoolman.printer_manager") as pm_mock:
  460. mock_state = MagicMock()
  461. mock_state.raw_data = {"ams": [{"id": 0, "tray": []}]}
  462. pm_mock.get_status = MagicMock(return_value=mock_state)
  463. response = await async_client.post(f"/api/v1/spoolman/sync/{printer.id}")
  464. assert response.status_code == 200
  465. data = response.json()
  466. # Verify SyncResult structure
  467. assert "success" in data
  468. assert "synced_count" in data
  469. assert "skipped_count" in data
  470. assert "skipped" in data
  471. assert "errors" in data
  472. assert isinstance(data["skipped"], list)
  473. assert isinstance(data["errors"], list)
  474. @pytest.mark.asyncio
  475. @pytest.mark.integration
  476. async def test_sync_printer_not_connected(
  477. self,
  478. async_client: AsyncClient,
  479. spoolman_settings,
  480. mock_spoolman_client,
  481. printer_factory,
  482. ):
  483. """Verify sync fails when printer is not connected (no status)."""
  484. printer = await printer_factory()
  485. with patch("backend.app.api.routes.spoolman.printer_manager") as pm_mock:
  486. pm_mock.get_status = MagicMock(return_value=None)
  487. response = await async_client.post(f"/api/v1/spoolman/sync/{printer.id}")
  488. assert response.status_code == 404
  489. assert "not connected" in response.json()["detail"].lower()
  490. # =========================================================================
  491. # Filaments Endpoint Tests
  492. # =========================================================================
  493. @pytest.mark.asyncio
  494. @pytest.mark.integration
  495. async def test_get_filaments_not_enabled(self, async_client: AsyncClient):
  496. """Verify get filaments fails when not enabled."""
  497. response = await async_client.get("/api/v1/spoolman/filaments")
  498. assert response.status_code == 400
  499. assert "not enabled" in response.json()["detail"].lower()
  500. @pytest.mark.asyncio
  501. @pytest.mark.integration
  502. async def test_get_filaments_success(self, async_client: AsyncClient, spoolman_settings, mock_spoolman_client):
  503. """Verify get filaments returns data in expected format."""
  504. mock_filament = {
  505. "id": 1,
  506. "name": "PLA Basic",
  507. "material": "PLA",
  508. "color_hex": "FF0000",
  509. "vendor_id": 1,
  510. "weight": 1000,
  511. }
  512. mock_spoolman_client.get_filaments = AsyncMock(return_value=[mock_filament])
  513. response = await async_client.get("/api/v1/spoolman/filaments")
  514. assert response.status_code == 200
  515. data = response.json()
  516. assert "filaments" in data
  517. assert isinstance(data["filaments"], list)
  518. assert len(data["filaments"]) == 1
  519. assert data["filaments"][0]["name"] == "PLA Basic"
  520. # =========================================================================
  521. # Disable Weight Sync Tests
  522. # =========================================================================
  523. @pytest.fixture
  524. async def spoolman_settings_weight_sync_disabled(self, db_session):
  525. """Create Spoolman settings with weight sync disabled."""
  526. from backend.app.models.settings import Settings
  527. enabled_setting = Settings(key="spoolman_enabled", value="true")
  528. url_setting = Settings(key="spoolman_url", value="http://localhost:7912")
  529. disable_weight_setting = Settings(key="spoolman_disable_weight_sync", value="true")
  530. partial_usage_setting = Settings(key="spoolman_report_partial_usage", value="true")
  531. db_session.add(enabled_setting)
  532. db_session.add(url_setting)
  533. db_session.add(disable_weight_setting)
  534. db_session.add(partial_usage_setting)
  535. await db_session.commit()
  536. return {
  537. "enabled": enabled_setting,
  538. "url": url_setting,
  539. "disable_weight": disable_weight_setting,
  540. "partial_usage": partial_usage_setting,
  541. }
  542. @pytest.mark.asyncio
  543. @pytest.mark.integration
  544. async def test_settings_returns_disable_weight_sync(
  545. self, async_client: AsyncClient, spoolman_settings_weight_sync_disabled
  546. ):
  547. """Verify settings endpoint returns the disable_weight_sync setting."""
  548. response = await async_client.get("/api/v1/settings/spoolman")
  549. assert response.status_code == 200
  550. data = response.json()
  551. assert "spoolman_disable_weight_sync" in data
  552. assert data["spoolman_disable_weight_sync"] == "true"
  553. @pytest.mark.asyncio
  554. @pytest.mark.integration
  555. async def test_settings_update_disable_weight_sync(self, async_client: AsyncClient, spoolman_settings):
  556. """Verify settings endpoint can update the disable_weight_sync setting."""
  557. # First verify it's false by default
  558. response = await async_client.get("/api/v1/settings/spoolman")
  559. assert response.status_code == 200
  560. data = response.json()
  561. assert data.get("spoolman_disable_weight_sync", "false") == "false"
  562. # Update the setting
  563. response = await async_client.put(
  564. "/api/v1/settings/spoolman",
  565. json={"spoolman_disable_weight_sync": "true"},
  566. )
  567. assert response.status_code == 200
  568. data = response.json()
  569. assert data["spoolman_disable_weight_sync"] == "true"
  570. # Verify it persisted
  571. response = await async_client.get("/api/v1/settings/spoolman")
  572. assert response.status_code == 200
  573. data = response.json()
  574. assert data["spoolman_disable_weight_sync"] == "true"
  575. @pytest.mark.asyncio
  576. @pytest.mark.integration
  577. async def test_sync_with_weight_sync_disabled_updates_location_only(
  578. self,
  579. async_client: AsyncClient,
  580. spoolman_settings_weight_sync_disabled,
  581. mock_spoolman_client,
  582. printer_factory,
  583. ):
  584. """Verify sync only updates location when disable_weight_sync is enabled."""
  585. printer = await printer_factory()
  586. # Mock existing spool
  587. mock_existing_spool = {
  588. "id": 42,
  589. "remaining_weight": 800,
  590. "extra": {"tag": '"A1B2C3D4E5F6A1B2C3D4E5F6A1B2C3D4"'},
  591. "filament": {"id": 1, "name": "PLA Red", "material": "PLA"},
  592. }
  593. mock_spoolman_client.find_spool_by_tag = AsyncMock(return_value=mock_existing_spool)
  594. mock_spoolman_client.parse_ams_tray = MagicMock()
  595. # Create mock AMSTray
  596. from backend.app.services.spoolman import AMSTray
  597. mock_tray = AMSTray(
  598. ams_id=0,
  599. tray_id=0,
  600. tray_type="PLA",
  601. tray_sub_brands="PLA Basic",
  602. tray_color="FF0000FF",
  603. remain=50,
  604. tag_uid="",
  605. tray_uuid="A1B2C3D4E5F6A1B2C3D4E5F6A1B2C3D4",
  606. tray_info_idx="GFA00",
  607. tray_weight=1000,
  608. )
  609. mock_spoolman_client.parse_ams_tray.return_value = mock_tray
  610. mock_spoolman_client.is_bambu_lab_spool = MagicMock(return_value=True)
  611. mock_spoolman_client.convert_ams_slot_to_location = MagicMock(return_value="AMS A1")
  612. mock_spoolman_client.sync_ams_tray = AsyncMock(return_value={"id": 42})
  613. mock_spoolman_client.clear_location_for_removed_spools = AsyncMock(return_value=0)
  614. with patch("backend.app.api.routes.spoolman.printer_manager") as pm_mock:
  615. mock_state = MagicMock()
  616. mock_state.raw_data = {
  617. "ams": [
  618. {
  619. "id": 0,
  620. "tray": [
  621. {
  622. "id": 0,
  623. "tray_type": "PLA",
  624. "tray_sub_brands": "PLA Basic",
  625. "tray_color": "FF0000FF",
  626. "remain": 50,
  627. "tag_uid": "",
  628. "tray_uuid": "A1B2C3D4E5F6A1B2C3D4E5F6A1B2C3D4",
  629. "tray_info_idx": "GFA00",
  630. "tray_weight": 1000,
  631. }
  632. ],
  633. }
  634. ]
  635. }
  636. pm_mock.get_status = MagicMock(return_value=mock_state)
  637. response = await async_client.post(f"/api/v1/spoolman/sync/{printer.id}")
  638. assert response.status_code == 200
  639. # Verify sync_ams_tray was called with disable_weight_sync=True
  640. mock_spoolman_client.sync_ams_tray.assert_called()
  641. call_kwargs = mock_spoolman_client.sync_ams_tray.call_args.kwargs
  642. assert call_kwargs.get("disable_weight_sync") is True
  643. # =========================================================================
  644. # Report Partial Usage Tests
  645. # =========================================================================
  646. @pytest.fixture
  647. async def spoolman_settings_partial_usage_disabled(self, db_session):
  648. """Create Spoolman settings with partial usage reporting disabled."""
  649. from backend.app.models.settings import Settings
  650. enabled_setting = Settings(key="spoolman_enabled", value="true")
  651. url_setting = Settings(key="spoolman_url", value="http://localhost:7912")
  652. partial_usage_setting = Settings(key="spoolman_report_partial_usage", value="false")
  653. db_session.add(enabled_setting)
  654. db_session.add(url_setting)
  655. db_session.add(partial_usage_setting)
  656. await db_session.commit()
  657. return {
  658. "enabled": enabled_setting,
  659. "url": url_setting,
  660. "partial_usage": partial_usage_setting,
  661. }
  662. @pytest.mark.asyncio
  663. @pytest.mark.integration
  664. async def test_settings_returns_report_partial_usage(
  665. self, async_client: AsyncClient, spoolman_settings_partial_usage_disabled
  666. ):
  667. """Verify settings endpoint returns the report_partial_usage setting."""
  668. response = await async_client.get("/api/v1/settings/spoolman")
  669. assert response.status_code == 200
  670. data = response.json()
  671. assert "spoolman_report_partial_usage" in data
  672. assert data["spoolman_report_partial_usage"] == "false"
  673. @pytest.mark.asyncio
  674. @pytest.mark.integration
  675. async def test_settings_update_report_partial_usage(self, async_client: AsyncClient, spoolman_settings):
  676. """Verify settings endpoint can update the report_partial_usage setting."""
  677. # First verify it's true by default
  678. response = await async_client.get("/api/v1/settings/spoolman")
  679. assert response.status_code == 200
  680. data = response.json()
  681. assert data.get("spoolman_report_partial_usage", "true") == "true"
  682. # Update the setting to false
  683. response = await async_client.put(
  684. "/api/v1/settings/spoolman",
  685. json={"spoolman_report_partial_usage": "false"},
  686. )
  687. assert response.status_code == 200
  688. data = response.json()
  689. assert data["spoolman_report_partial_usage"] == "false"
  690. # Verify it persisted
  691. response = await async_client.get("/api/v1/settings/spoolman")
  692. assert response.status_code == 200
  693. data = response.json()
  694. assert data["spoolman_report_partial_usage"] == "false"
  695. @pytest.mark.asyncio
  696. @pytest.mark.integration
  697. async def test_settings_report_partial_usage_defaults_to_true(self, async_client: AsyncClient, spoolman_settings):
  698. """Verify report_partial_usage defaults to true (unlike disable_weight_sync which defaults to false)."""
  699. response = await async_client.get("/api/v1/settings/spoolman")
  700. assert response.status_code == 200
  701. data = response.json()
  702. # Should default to "true"
  703. assert data["spoolman_report_partial_usage"] == "true"