test_printers_api.py 48 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175
  1. """Integration tests for Printers API endpoints.
  2. Tests the full request/response cycle for /api/v1/printers/ endpoints.
  3. """
  4. from unittest.mock import MagicMock, patch
  5. import pytest
  6. from httpx import AsyncClient
  7. class TestPrintersAPI:
  8. """Integration tests for /api/v1/printers/ endpoints."""
  9. # ========================================================================
  10. # List endpoints
  11. # ========================================================================
  12. @pytest.mark.asyncio
  13. @pytest.mark.integration
  14. async def test_list_printers_empty(self, async_client: AsyncClient):
  15. """Verify empty list is returned when no printers exist."""
  16. response = await async_client.get("/api/v1/printers/")
  17. assert response.status_code == 200
  18. assert response.json() == []
  19. @pytest.mark.asyncio
  20. @pytest.mark.integration
  21. async def test_list_printers_with_data(self, async_client: AsyncClient, printer_factory, db_session):
  22. """Verify list returns existing printers."""
  23. await printer_factory(name="Test Printer")
  24. response = await async_client.get("/api/v1/printers/")
  25. assert response.status_code == 200
  26. data = response.json()
  27. assert len(data) >= 1
  28. assert any(p["name"] == "Test Printer" for p in data)
  29. # ========================================================================
  30. # Create endpoints
  31. # ========================================================================
  32. @pytest.mark.asyncio
  33. @pytest.mark.integration
  34. async def test_create_printer(self, async_client: AsyncClient):
  35. """Verify printer can be created."""
  36. data = {
  37. "name": "New Printer",
  38. "serial_number": "00M09A111111111",
  39. "ip_address": "192.168.1.100",
  40. "access_code": "12345678",
  41. "is_active": True,
  42. "model": "X1C",
  43. }
  44. response = await async_client.post("/api/v1/printers/", json=data)
  45. assert response.status_code == 200
  46. result = response.json()
  47. assert result["name"] == "New Printer"
  48. assert result["serial_number"] == "00M09A111111111"
  49. assert result["model"] == "X1C"
  50. @pytest.mark.asyncio
  51. @pytest.mark.integration
  52. async def test_create_printer_with_hostname(self, async_client: AsyncClient):
  53. """Verify printer can be created with a hostname instead of IP address."""
  54. data = {
  55. "name": "DNS Printer",
  56. "serial_number": "00M09A555555555",
  57. "ip_address": "printer.local",
  58. "access_code": "12345678",
  59. "model": "P1S",
  60. }
  61. response = await async_client.post("/api/v1/printers/", json=data)
  62. assert response.status_code == 200
  63. result = response.json()
  64. assert result["name"] == "DNS Printer"
  65. assert result["ip_address"] == "printer.local"
  66. @pytest.mark.asyncio
  67. @pytest.mark.integration
  68. async def test_create_printer_with_fqdn(self, async_client: AsyncClient):
  69. """Verify printer can be created with a fully qualified domain name."""
  70. data = {
  71. "name": "FQDN Printer",
  72. "serial_number": "00M09A666666666",
  73. "ip_address": "my-printer.home.lan",
  74. "access_code": "12345678",
  75. "model": "X1C",
  76. }
  77. response = await async_client.post("/api/v1/printers/", json=data)
  78. assert response.status_code == 200
  79. result = response.json()
  80. assert result["ip_address"] == "my-printer.home.lan"
  81. @pytest.mark.asyncio
  82. @pytest.mark.integration
  83. async def test_create_printer_invalid_hostname(self, async_client: AsyncClient):
  84. """Verify invalid hostnames are rejected."""
  85. data = {
  86. "name": "Bad Printer",
  87. "serial_number": "00M09A777777777",
  88. "ip_address": "-invalid",
  89. "access_code": "12345678",
  90. }
  91. response = await async_client.post("/api/v1/printers/", json=data)
  92. assert response.status_code == 422
  93. @pytest.mark.asyncio
  94. @pytest.mark.integration
  95. async def test_create_printer_duplicate_serial(self, async_client: AsyncClient, printer_factory, db_session):
  96. """Verify duplicate serial number is rejected."""
  97. await printer_factory(serial_number="00M09A222222222")
  98. data = {
  99. "name": "Duplicate Printer",
  100. "serial_number": "00M09A222222222",
  101. "ip_address": "192.168.1.101",
  102. "access_code": "12345678",
  103. }
  104. response = await async_client.post("/api/v1/printers/", json=data)
  105. # Should fail due to duplicate serial
  106. assert response.status_code in [400, 409, 422, 500]
  107. # ========================================================================
  108. # Get single endpoint
  109. # ========================================================================
  110. @pytest.mark.asyncio
  111. @pytest.mark.integration
  112. async def test_get_printer(self, async_client: AsyncClient, printer_factory, db_session):
  113. """Verify single printer can be retrieved."""
  114. printer = await printer_factory(name="Get Test Printer")
  115. response = await async_client.get(f"/api/v1/printers/{printer.id}")
  116. assert response.status_code == 200
  117. result = response.json()
  118. assert result["id"] == printer.id
  119. assert result["name"] == "Get Test Printer"
  120. @pytest.mark.asyncio
  121. @pytest.mark.integration
  122. async def test_get_printer_not_found(self, async_client: AsyncClient):
  123. """Verify 404 for non-existent printer."""
  124. response = await async_client.get("/api/v1/printers/9999")
  125. assert response.status_code == 404
  126. # ========================================================================
  127. # Update endpoints
  128. # ========================================================================
  129. @pytest.mark.asyncio
  130. @pytest.mark.integration
  131. async def test_update_printer_name(self, async_client: AsyncClient, printer_factory, db_session):
  132. """Verify printer name can be updated."""
  133. printer = await printer_factory(name="Original Name")
  134. response = await async_client.patch(f"/api/v1/printers/{printer.id}", json={"name": "Updated Name"})
  135. assert response.status_code == 200
  136. assert response.json()["name"] == "Updated Name"
  137. @pytest.mark.asyncio
  138. @pytest.mark.integration
  139. async def test_update_printer_active_status(self, async_client: AsyncClient, printer_factory, db_session):
  140. """Verify printer active status can be updated."""
  141. printer = await printer_factory(is_active=True)
  142. response = await async_client.patch(f"/api/v1/printers/{printer.id}", json={"is_active": False})
  143. assert response.status_code == 200
  144. assert response.json()["is_active"] is False
  145. @pytest.mark.asyncio
  146. @pytest.mark.integration
  147. async def test_update_printer_auto_archive(self, async_client: AsyncClient, printer_factory, db_session):
  148. """Verify auto_archive setting can be updated."""
  149. printer = await printer_factory(auto_archive=True)
  150. response = await async_client.patch(f"/api/v1/printers/{printer.id}", json={"auto_archive": False})
  151. assert response.status_code == 200
  152. assert response.json()["auto_archive"] is False
  153. @pytest.mark.asyncio
  154. @pytest.mark.integration
  155. async def test_update_nonexistent_printer(self, async_client: AsyncClient):
  156. """Verify updating non-existent printer returns 404."""
  157. response = await async_client.patch("/api/v1/printers/9999", json={"name": "New Name"})
  158. assert response.status_code == 404
  159. # ========================================================================
  160. # Delete endpoints
  161. # ========================================================================
  162. @pytest.mark.asyncio
  163. @pytest.mark.integration
  164. async def test_delete_printer(self, async_client: AsyncClient, printer_factory, db_session):
  165. """Verify printer can be deleted."""
  166. printer = await printer_factory()
  167. printer_id = printer.id
  168. response = await async_client.delete(f"/api/v1/printers/{printer_id}")
  169. assert response.status_code == 200
  170. # Verify deleted
  171. response = await async_client.get(f"/api/v1/printers/{printer_id}")
  172. assert response.status_code == 404
  173. @pytest.mark.asyncio
  174. @pytest.mark.integration
  175. async def test_delete_nonexistent_printer(self, async_client: AsyncClient):
  176. """Verify deleting non-existent printer returns 404."""
  177. response = await async_client.delete("/api/v1/printers/9999")
  178. assert response.status_code == 404
  179. # ========================================================================
  180. # Status endpoint
  181. # ========================================================================
  182. @pytest.mark.asyncio
  183. @pytest.mark.integration
  184. async def test_get_printer_status(
  185. self, async_client: AsyncClient, printer_factory, mock_printer_manager, db_session
  186. ):
  187. """Verify printer status can be retrieved."""
  188. printer = await printer_factory()
  189. response = await async_client.get(f"/api/v1/printers/{printer.id}/status")
  190. assert response.status_code == 200
  191. result = response.json()
  192. assert "connected" in result
  193. assert "state" in result
  194. @pytest.mark.asyncio
  195. @pytest.mark.integration
  196. async def test_get_printer_status_not_found(self, async_client: AsyncClient):
  197. """Verify 404 for status of non-existent printer."""
  198. response = await async_client.get("/api/v1/printers/9999/status")
  199. assert response.status_code == 404
  200. # ========================================================================
  201. # Test connection endpoint
  202. # ========================================================================
  203. class TestPrinterDataIntegrity:
  204. """Tests for printer data integrity."""
  205. @pytest.mark.asyncio
  206. @pytest.mark.integration
  207. async def test_printer_stores_all_fields(self, async_client: AsyncClient, printer_factory, db_session):
  208. """Verify printer stores all fields correctly."""
  209. printer = await printer_factory(
  210. name="Full Test Printer",
  211. serial_number="00M09A444444444",
  212. ip_address="192.168.1.150",
  213. model="P1S",
  214. is_active=True,
  215. auto_archive=False,
  216. )
  217. response = await async_client.get(f"/api/v1/printers/{printer.id}")
  218. assert response.status_code == 200
  219. result = response.json()
  220. assert result["name"] == "Full Test Printer"
  221. assert result["serial_number"] == "00M09A444444444"
  222. assert result["ip_address"] == "192.168.1.150"
  223. assert result["model"] == "P1S"
  224. assert result["is_active"] is True
  225. assert result["auto_archive"] is False
  226. @pytest.mark.asyncio
  227. @pytest.mark.integration
  228. async def test_printer_update_persists(self, async_client: AsyncClient, printer_factory, db_session):
  229. """CRITICAL: Verify printer updates persist."""
  230. printer = await printer_factory(name="Original", is_active=True)
  231. # Update
  232. await async_client.patch(f"/api/v1/printers/{printer.id}", json={"name": "Updated", "is_active": False})
  233. # Verify persistence
  234. response = await async_client.get(f"/api/v1/printers/{printer.id}")
  235. result = response.json()
  236. assert result["name"] == "Updated"
  237. assert result["is_active"] is False
  238. # ========================================================================
  239. # Refresh status endpoint
  240. # ========================================================================
  241. @pytest.mark.asyncio
  242. @pytest.mark.integration
  243. async def test_refresh_status_not_found(self, async_client: AsyncClient):
  244. """Verify 404 for non-existent printer."""
  245. response = await async_client.post("/api/v1/printers/99999/refresh-status")
  246. assert response.status_code == 404
  247. @pytest.mark.asyncio
  248. @pytest.mark.integration
  249. async def test_refresh_status_not_connected(self, async_client: AsyncClient, printer_factory):
  250. """Verify 400 when printer is not connected."""
  251. printer = await printer_factory(name="Disconnected Printer")
  252. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  253. mock_pm.request_status_update.return_value = False
  254. response = await async_client.post(f"/api/v1/printers/{printer.id}/refresh-status")
  255. assert response.status_code == 400
  256. assert "not connected" in response.json()["detail"].lower()
  257. @pytest.mark.asyncio
  258. @pytest.mark.integration
  259. async def test_refresh_status_success(self, async_client: AsyncClient, printer_factory):
  260. """Verify successful refresh request."""
  261. printer = await printer_factory(name="Connected Printer")
  262. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  263. mock_pm.request_status_update.return_value = True
  264. response = await async_client.post(f"/api/v1/printers/{printer.id}/refresh-status")
  265. assert response.status_code == 200
  266. assert response.json()["status"] == "refresh_requested"
  267. mock_pm.request_status_update.assert_called_once_with(printer.id)
  268. # ========================================================================
  269. # Current print user endpoint (Issue #206)
  270. # ========================================================================
  271. @pytest.mark.asyncio
  272. @pytest.mark.integration
  273. async def test_get_current_print_user_not_found(self, async_client: AsyncClient):
  274. """Verify 404 for non-existent printer."""
  275. response = await async_client.get("/api/v1/printers/99999/current-print-user")
  276. assert response.status_code == 404
  277. @pytest.mark.asyncio
  278. @pytest.mark.integration
  279. async def test_get_current_print_user_returns_empty_when_no_user(self, async_client: AsyncClient, printer_factory):
  280. """Verify empty object returned when no user is tracked."""
  281. printer = await printer_factory(name="Test Printer")
  282. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  283. mock_pm.get_current_print_user.return_value = None
  284. response = await async_client.get(f"/api/v1/printers/{printer.id}/current-print-user")
  285. assert response.status_code == 200
  286. assert response.json() == {}
  287. @pytest.mark.asyncio
  288. @pytest.mark.integration
  289. async def test_get_current_print_user_returns_user_info(self, async_client: AsyncClient, printer_factory):
  290. """Verify user info is returned when tracked."""
  291. printer = await printer_factory(name="Test Printer")
  292. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  293. mock_pm.get_current_print_user.return_value = {"user_id": 42, "username": "testuser"}
  294. response = await async_client.get(f"/api/v1/printers/{printer.id}/current-print-user")
  295. assert response.status_code == 200
  296. result = response.json()
  297. assert result["user_id"] == 42
  298. assert result["username"] == "testuser"
  299. class TestPrintControlAPI:
  300. """Integration tests for print control endpoints (stop, pause, resume)."""
  301. # ========================================================================
  302. # Stop print endpoint
  303. # ========================================================================
  304. @pytest.mark.asyncio
  305. @pytest.mark.integration
  306. async def test_stop_print_not_found(self, async_client: AsyncClient):
  307. """Verify 404 for non-existent printer."""
  308. response = await async_client.post("/api/v1/printers/99999/print/stop")
  309. assert response.status_code == 404
  310. @pytest.mark.asyncio
  311. @pytest.mark.integration
  312. async def test_stop_print_not_connected(self, async_client: AsyncClient, printer_factory):
  313. """Verify error when printer is not connected."""
  314. printer = await printer_factory(name="Disconnected Printer")
  315. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  316. mock_pm.get_client.return_value = None
  317. response = await async_client.post(f"/api/v1/printers/{printer.id}/print/stop")
  318. assert response.status_code == 400
  319. assert "not connected" in response.json()["detail"].lower()
  320. @pytest.mark.asyncio
  321. @pytest.mark.integration
  322. async def test_stop_print_success(self, async_client: AsyncClient, printer_factory):
  323. """Verify successful stop print request."""
  324. printer = await printer_factory(name="Printing Printer")
  325. mock_client = MagicMock()
  326. mock_client.stop_print.return_value = True
  327. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  328. mock_pm.get_client.return_value = mock_client
  329. response = await async_client.post(f"/api/v1/printers/{printer.id}/print/stop")
  330. assert response.status_code == 200
  331. assert response.json()["success"] is True
  332. mock_client.stop_print.assert_called_once()
  333. # ========================================================================
  334. # Pause print endpoint
  335. # ========================================================================
  336. @pytest.mark.asyncio
  337. @pytest.mark.integration
  338. async def test_pause_print_not_found(self, async_client: AsyncClient):
  339. """Verify 404 for non-existent printer."""
  340. response = await async_client.post("/api/v1/printers/99999/print/pause")
  341. assert response.status_code == 404
  342. @pytest.mark.asyncio
  343. @pytest.mark.integration
  344. async def test_pause_print_not_connected(self, async_client: AsyncClient, printer_factory):
  345. """Verify error when printer is not connected."""
  346. printer = await printer_factory(name="Disconnected Printer")
  347. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  348. mock_pm.get_client.return_value = None
  349. response = await async_client.post(f"/api/v1/printers/{printer.id}/print/pause")
  350. assert response.status_code == 400
  351. assert "not connected" in response.json()["detail"].lower()
  352. @pytest.mark.asyncio
  353. @pytest.mark.integration
  354. async def test_pause_print_success(self, async_client: AsyncClient, printer_factory):
  355. """Verify successful pause print request."""
  356. printer = await printer_factory(name="Printing Printer")
  357. mock_client = MagicMock()
  358. mock_client.pause_print.return_value = True
  359. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  360. mock_pm.get_client.return_value = mock_client
  361. response = await async_client.post(f"/api/v1/printers/{printer.id}/print/pause")
  362. assert response.status_code == 200
  363. assert response.json()["success"] is True
  364. mock_client.pause_print.assert_called_once()
  365. # ========================================================================
  366. # Resume print endpoint
  367. # ========================================================================
  368. @pytest.mark.asyncio
  369. @pytest.mark.integration
  370. async def test_resume_print_not_found(self, async_client: AsyncClient):
  371. """Verify 404 for non-existent printer."""
  372. response = await async_client.post("/api/v1/printers/99999/print/resume")
  373. assert response.status_code == 404
  374. @pytest.mark.asyncio
  375. @pytest.mark.integration
  376. async def test_resume_print_not_connected(self, async_client: AsyncClient, printer_factory):
  377. """Verify error when printer is not connected."""
  378. printer = await printer_factory(name="Disconnected Printer")
  379. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  380. mock_pm.get_client.return_value = None
  381. response = await async_client.post(f"/api/v1/printers/{printer.id}/print/resume")
  382. assert response.status_code == 400
  383. assert "not connected" in response.json()["detail"].lower()
  384. @pytest.mark.asyncio
  385. @pytest.mark.integration
  386. async def test_resume_print_success(self, async_client: AsyncClient, printer_factory):
  387. """Verify successful resume print request."""
  388. printer = await printer_factory(name="Paused Printer")
  389. mock_client = MagicMock()
  390. mock_client.resume_print.return_value = True
  391. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  392. mock_pm.get_client.return_value = mock_client
  393. response = await async_client.post(f"/api/v1/printers/{printer.id}/print/resume")
  394. assert response.status_code == 200
  395. assert response.json()["success"] is True
  396. mock_client.resume_print.assert_called_once()
  397. class TestAMSRefreshAPI:
  398. """Integration tests for AMS slot refresh endpoint."""
  399. @pytest.mark.asyncio
  400. @pytest.mark.integration
  401. async def test_ams_refresh_not_found(self, async_client: AsyncClient):
  402. """Verify 404 for non-existent printer."""
  403. response = await async_client.post("/api/v1/printers/99999/ams/0/slot/0/refresh")
  404. assert response.status_code == 404
  405. @pytest.mark.asyncio
  406. @pytest.mark.integration
  407. async def test_ams_refresh_not_connected(self, async_client: AsyncClient, printer_factory):
  408. """Verify error when printer is not connected."""
  409. printer = await printer_factory(name="Disconnected Printer")
  410. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  411. mock_pm.get_client.return_value = None
  412. response = await async_client.post(f"/api/v1/printers/{printer.id}/ams/0/slot/0/refresh")
  413. assert response.status_code == 400
  414. assert "not connected" in response.json()["detail"].lower()
  415. @pytest.mark.asyncio
  416. @pytest.mark.integration
  417. async def test_ams_refresh_success(self, async_client: AsyncClient, printer_factory):
  418. """Verify successful AMS refresh request."""
  419. printer = await printer_factory(name="Printer with AMS")
  420. mock_client = MagicMock()
  421. mock_client.ams_refresh_tray.return_value = (True, "Refreshing AMS 0 tray 1")
  422. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  423. mock_pm.get_client.return_value = mock_client
  424. response = await async_client.post(f"/api/v1/printers/{printer.id}/ams/0/slot/1/refresh")
  425. assert response.status_code == 200
  426. result = response.json()
  427. assert result["success"] is True
  428. mock_client.ams_refresh_tray.assert_called_once_with(0, 1)
  429. @pytest.mark.asyncio
  430. @pytest.mark.integration
  431. async def test_ams_refresh_filament_loaded(self, async_client: AsyncClient, printer_factory):
  432. """Verify error when filament is loaded (can't refresh while loaded)."""
  433. printer = await printer_factory(name="Printer with AMS")
  434. mock_client = MagicMock()
  435. mock_client.ams_refresh_tray.return_value = (False, "Please unload filament first")
  436. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  437. mock_pm.get_client.return_value = mock_client
  438. response = await async_client.post(f"/api/v1/printers/{printer.id}/ams/0/slot/0/refresh")
  439. assert response.status_code == 400
  440. assert "unload" in response.json()["detail"].lower()
  441. class TestConfigureAMSSlotAPI:
  442. """Integration tests for AMS slot configure endpoint — tray_info_idx resolution."""
  443. @pytest.mark.asyncio
  444. @pytest.mark.integration
  445. async def test_configure_not_connected(self, async_client: AsyncClient, printer_factory):
  446. """Verify error when printer is not connected."""
  447. printer = await printer_factory(name="Disconnected")
  448. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  449. mock_pm.get_client.return_value = None
  450. response = await async_client.post(
  451. f"/api/v1/printers/{printer.id}/slots/0/0/configure",
  452. params={
  453. "tray_info_idx": "GFL99",
  454. "tray_type": "PLA",
  455. "tray_sub_brands": "PLA Basic",
  456. "tray_color": "FF0000FF",
  457. "nozzle_temp_min": 190,
  458. "nozzle_temp_max": 230,
  459. },
  460. )
  461. assert response.status_code == 400
  462. assert "not connected" in response.json()["detail"].lower()
  463. @pytest.mark.asyncio
  464. @pytest.mark.integration
  465. async def test_configure_with_gf_id_keeps_it(self, async_client: AsyncClient, printer_factory):
  466. """Standard Bambu GF* filament IDs are sent as-is."""
  467. printer = await printer_factory(name="H2D")
  468. mock_client = MagicMock()
  469. mock_client.ams_set_filament_setting.return_value = True
  470. mock_client.extrusion_cali_sel.return_value = True
  471. mock_client.request_status_update.return_value = True
  472. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  473. mock_pm.get_client.return_value = mock_client
  474. mock_pm.get_status.return_value = None # No existing state
  475. response = await async_client.post(
  476. f"/api/v1/printers/{printer.id}/slots/2/3/configure",
  477. params={
  478. "tray_info_idx": "GFL05",
  479. "tray_type": "PLA",
  480. "tray_sub_brands": "PLA Basic",
  481. "tray_color": "FFFFFFFF",
  482. "nozzle_temp_min": 190,
  483. "nozzle_temp_max": 230,
  484. },
  485. )
  486. assert response.status_code == 200
  487. call_kwargs = mock_client.ams_set_filament_setting.call_args
  488. assert call_kwargs.kwargs["tray_info_idx"] == "GFL05"
  489. @pytest.mark.asyncio
  490. @pytest.mark.integration
  491. async def test_configure_pfus_replaced_with_generic(self, async_client: AsyncClient, printer_factory):
  492. """PFUS* user-local IDs are replaced with generic Bambu IDs."""
  493. printer = await printer_factory(name="H2D")
  494. mock_client = MagicMock()
  495. mock_client.ams_set_filament_setting.return_value = True
  496. mock_client.extrusion_cali_sel.return_value = True
  497. mock_client.request_status_update.return_value = True
  498. mock_status = MagicMock()
  499. mock_status.raw_data = {"ams": {"ams": []}} # No existing tray data
  500. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  501. mock_pm.get_client.return_value = mock_client
  502. mock_pm.get_status.return_value = mock_status
  503. response = await async_client.post(
  504. f"/api/v1/printers/{printer.id}/slots/2/3/configure",
  505. params={
  506. "tray_info_idx": "PFUS9ac902733670a9",
  507. "tray_type": "PLA",
  508. "tray_sub_brands": "Devil Design PLA",
  509. "tray_color": "FF0000FF",
  510. "nozzle_temp_min": 190,
  511. "nozzle_temp_max": 230,
  512. },
  513. )
  514. assert response.status_code == 200
  515. call_kwargs = mock_client.ams_set_filament_setting.call_args
  516. assert call_kwargs.kwargs["tray_info_idx"] == "GFL99"
  517. @pytest.mark.asyncio
  518. @pytest.mark.integration
  519. async def test_configure_pfus_reuses_existing_slot_id(self, async_client: AsyncClient, printer_factory):
  520. """When slot already has a recognised preset for same material, reuse it."""
  521. printer = await printer_factory(name="H2D")
  522. mock_client = MagicMock()
  523. mock_client.ams_set_filament_setting.return_value = True
  524. mock_client.extrusion_cali_sel.return_value = True
  525. mock_client.request_status_update.return_value = True
  526. # Simulate slot already configured by slicer with cloud-synced preset
  527. mock_status = MagicMock()
  528. mock_status.raw_data = {
  529. "ams": {
  530. "ams": [
  531. {
  532. "id": 2,
  533. "tray": [
  534. {
  535. "id": 3,
  536. "tray_info_idx": "P4d64437",
  537. "tray_type": "PLA",
  538. "tray_color": "FF0000FF",
  539. }
  540. ],
  541. }
  542. ]
  543. }
  544. }
  545. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  546. mock_pm.get_client.return_value = mock_client
  547. mock_pm.get_status.return_value = mock_status
  548. response = await async_client.post(
  549. f"/api/v1/printers/{printer.id}/slots/2/3/configure",
  550. params={
  551. "tray_info_idx": "PFUS9ac902733670a9",
  552. "tray_type": "PLA",
  553. "tray_sub_brands": "Devil Design PLA",
  554. "tray_color": "FF0000FF",
  555. "nozzle_temp_min": 190,
  556. "nozzle_temp_max": 230,
  557. },
  558. )
  559. assert response.status_code == 200
  560. call_kwargs = mock_client.ams_set_filament_setting.call_args
  561. # Should reuse the slicer's P4d64437, not replace with GFL99
  562. assert call_kwargs.kwargs["tray_info_idx"] == "P4d64437"
  563. @pytest.mark.asyncio
  564. @pytest.mark.integration
  565. async def test_configure_pfus_different_material_uses_generic(self, async_client: AsyncClient, printer_factory):
  566. """When slot has a recognised preset but for DIFFERENT material, use generic."""
  567. printer = await printer_factory(name="H2D")
  568. mock_client = MagicMock()
  569. mock_client.ams_set_filament_setting.return_value = True
  570. mock_client.extrusion_cali_sel.return_value = True
  571. mock_client.request_status_update.return_value = True
  572. # Slot currently has PETG but user is configuring PLA
  573. mock_status = MagicMock()
  574. mock_status.raw_data = {
  575. "ams": {
  576. "ams": [
  577. {
  578. "id": 2,
  579. "tray": [{"id": 3, "tray_info_idx": "GFG99", "tray_type": "PETG", "tray_color": "FFFFFFFF"}],
  580. }
  581. ]
  582. }
  583. }
  584. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  585. mock_pm.get_client.return_value = mock_client
  586. mock_pm.get_status.return_value = mock_status
  587. response = await async_client.post(
  588. f"/api/v1/printers/{printer.id}/slots/2/3/configure",
  589. params={
  590. "tray_info_idx": "PFUS9ac902733670a9",
  591. "tray_type": "PLA",
  592. "tray_sub_brands": "Devil Design PLA",
  593. "tray_color": "FF0000FF",
  594. "nozzle_temp_min": 190,
  595. "nozzle_temp_max": 230,
  596. },
  597. )
  598. assert response.status_code == 200
  599. call_kwargs = mock_client.ams_set_filament_setting.call_args
  600. # Different material → should NOT reuse PETG ID, use generic PLA
  601. assert call_kwargs.kwargs["tray_info_idx"] == "GFL99"
  602. @pytest.mark.asyncio
  603. @pytest.mark.integration
  604. async def test_configure_empty_id_uses_generic(self, async_client: AsyncClient, printer_factory):
  605. """Empty tray_info_idx (local preset) is replaced with generic."""
  606. printer = await printer_factory(name="H2D")
  607. mock_client = MagicMock()
  608. mock_client.ams_set_filament_setting.return_value = True
  609. mock_client.extrusion_cali_sel.return_value = True
  610. mock_client.request_status_update.return_value = True
  611. mock_status = MagicMock()
  612. mock_status.raw_data = {"ams": {"ams": []}}
  613. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  614. mock_pm.get_client.return_value = mock_client
  615. mock_pm.get_status.return_value = mock_status
  616. response = await async_client.post(
  617. f"/api/v1/printers/{printer.id}/slots/2/3/configure",
  618. params={
  619. "tray_info_idx": "",
  620. "tray_type": "PETG",
  621. "tray_sub_brands": "PETG Basic",
  622. "tray_color": "FFFFFFFF",
  623. "nozzle_temp_min": 220,
  624. "nozzle_temp_max": 260,
  625. },
  626. )
  627. assert response.status_code == 200
  628. call_kwargs = mock_client.ams_set_filament_setting.call_args
  629. assert call_kwargs.kwargs["tray_info_idx"] == "GFG99"
  630. class TestSkipObjectsAPI:
  631. """Integration tests for skip objects endpoints."""
  632. # ========================================================================
  633. # Get printable objects endpoint
  634. # ========================================================================
  635. @pytest.mark.asyncio
  636. @pytest.mark.integration
  637. async def test_get_objects_not_found(self, async_client: AsyncClient):
  638. """Verify 404 for non-existent printer."""
  639. response = await async_client.get("/api/v1/printers/99999/print/objects")
  640. assert response.status_code == 404
  641. @pytest.mark.asyncio
  642. @pytest.mark.integration
  643. async def test_get_objects_not_connected(self, async_client: AsyncClient, printer_factory):
  644. """Verify error when printer is not connected."""
  645. printer = await printer_factory(name="Disconnected Printer")
  646. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  647. mock_pm.get_client.return_value = None
  648. response = await async_client.get(f"/api/v1/printers/{printer.id}/print/objects")
  649. assert response.status_code == 400
  650. assert "not connected" in response.json()["detail"].lower()
  651. @pytest.mark.asyncio
  652. @pytest.mark.integration
  653. async def test_get_objects_empty(self, async_client: AsyncClient, printer_factory):
  654. """Verify empty objects list when no print is active."""
  655. printer = await printer_factory(name="Idle Printer")
  656. mock_client = MagicMock()
  657. mock_client.state.printable_objects = {}
  658. mock_client.state.skipped_objects = []
  659. mock_client.state.state = "IDLE"
  660. mock_client.state.subtask_name = None # Prevent FTP download attempt
  661. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  662. mock_pm.get_client.return_value = mock_client
  663. response = await async_client.get(f"/api/v1/printers/{printer.id}/print/objects")
  664. assert response.status_code == 200
  665. result = response.json()
  666. assert result["objects"] == []
  667. assert result["total"] == 0
  668. assert result["skipped_count"] == 0
  669. assert result["is_printing"] is False
  670. @pytest.mark.asyncio
  671. @pytest.mark.integration
  672. async def test_get_objects_with_data(self, async_client: AsyncClient, printer_factory):
  673. """Verify objects list when print is active."""
  674. printer = await printer_factory(name="Printing Printer")
  675. mock_client = MagicMock()
  676. mock_client.state.printable_objects = {100: "Part A", 200: "Part B", 300: "Part C"}
  677. mock_client.state.skipped_objects = [200]
  678. mock_client.state.state = "RUNNING"
  679. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  680. mock_pm.get_client.return_value = mock_client
  681. response = await async_client.get(f"/api/v1/printers/{printer.id}/print/objects")
  682. assert response.status_code == 200
  683. result = response.json()
  684. assert result["total"] == 3
  685. assert result["skipped_count"] == 1
  686. assert result["is_printing"] is True
  687. # Check objects have correct structure
  688. objects_by_id = {obj["id"]: obj for obj in result["objects"]}
  689. assert objects_by_id[100]["name"] == "Part A"
  690. assert objects_by_id[100]["skipped"] is False
  691. assert objects_by_id[200]["name"] == "Part B"
  692. assert objects_by_id[200]["skipped"] is True
  693. assert objects_by_id[300]["name"] == "Part C"
  694. assert objects_by_id[300]["skipped"] is False
  695. # ========================================================================
  696. # Skip objects endpoint
  697. # ========================================================================
  698. @pytest.mark.asyncio
  699. @pytest.mark.integration
  700. async def test_get_objects_with_positions(self, async_client: AsyncClient, printer_factory):
  701. """Verify objects list includes position data when available."""
  702. printer = await printer_factory(name="Printing Printer")
  703. # New format with position data
  704. mock_client = MagicMock()
  705. mock_client.state.printable_objects = {
  706. 100: {"name": "Part A", "x": 50.0, "y": 100.0},
  707. 200: {"name": "Part B", "x": 150.0, "y": 100.0},
  708. }
  709. mock_client.state.skipped_objects = []
  710. mock_client.state.state = "RUNNING"
  711. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  712. mock_pm.get_client.return_value = mock_client
  713. response = await async_client.get(f"/api/v1/printers/{printer.id}/print/objects")
  714. assert response.status_code == 200
  715. result = response.json()
  716. assert result["total"] == 2
  717. # Check objects have position data
  718. objects_by_id = {obj["id"]: obj for obj in result["objects"]}
  719. assert objects_by_id[100]["name"] == "Part A"
  720. assert objects_by_id[100]["x"] == 50.0
  721. assert objects_by_id[100]["y"] == 100.0
  722. assert objects_by_id[200]["name"] == "Part B"
  723. assert objects_by_id[200]["x"] == 150.0
  724. assert objects_by_id[200]["y"] == 100.0
  725. # ========================================================================
  726. # Skip objects endpoint
  727. # ========================================================================
  728. @pytest.mark.asyncio
  729. @pytest.mark.integration
  730. async def test_skip_objects_not_found(self, async_client: AsyncClient):
  731. """Verify 404 for non-existent printer."""
  732. response = await async_client.post("/api/v1/printers/99999/print/skip-objects", json=[100])
  733. assert response.status_code == 404
  734. @pytest.mark.asyncio
  735. @pytest.mark.integration
  736. async def test_skip_objects_not_connected(self, async_client: AsyncClient, printer_factory):
  737. """Verify error when printer is not connected."""
  738. printer = await printer_factory(name="Disconnected Printer")
  739. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  740. mock_pm.get_client.return_value = None
  741. response = await async_client.post(f"/api/v1/printers/{printer.id}/print/skip-objects", json=[100])
  742. assert response.status_code == 400
  743. assert "not connected" in response.json()["detail"].lower()
  744. @pytest.mark.asyncio
  745. @pytest.mark.integration
  746. async def test_skip_objects_empty_list(self, async_client: AsyncClient, printer_factory):
  747. """Verify error when no object IDs provided."""
  748. printer = await printer_factory(name="Printing Printer")
  749. mock_client = MagicMock()
  750. mock_client.state.printable_objects = {100: "Part A"}
  751. mock_client.state.skipped_objects = []
  752. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  753. mock_pm.get_client.return_value = mock_client
  754. response = await async_client.post(f"/api/v1/printers/{printer.id}/print/skip-objects", json=[])
  755. assert response.status_code == 400
  756. assert "no object" in response.json()["detail"].lower()
  757. @pytest.mark.asyncio
  758. @pytest.mark.integration
  759. async def test_skip_objects_invalid_id(self, async_client: AsyncClient, printer_factory):
  760. """Verify error when object ID doesn't exist."""
  761. printer = await printer_factory(name="Printing Printer")
  762. mock_client = MagicMock()
  763. mock_client.state.printable_objects = {100: "Part A"}
  764. mock_client.state.skipped_objects = []
  765. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  766. mock_pm.get_client.return_value = mock_client
  767. response = await async_client.post(f"/api/v1/printers/{printer.id}/print/skip-objects", json=[999])
  768. assert response.status_code == 400
  769. assert "invalid" in response.json()["detail"].lower()
  770. @pytest.mark.asyncio
  771. @pytest.mark.integration
  772. async def test_skip_objects_success(self, async_client: AsyncClient, printer_factory):
  773. """Verify successful skip objects request."""
  774. printer = await printer_factory(name="Printing Printer")
  775. mock_client = MagicMock()
  776. mock_client.state.printable_objects = {100: "Part A", 200: "Part B"}
  777. mock_client.state.skipped_objects = []
  778. mock_client.skip_objects.return_value = True
  779. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  780. mock_pm.get_client.return_value = mock_client
  781. response = await async_client.post(f"/api/v1/printers/{printer.id}/print/skip-objects", json=[100])
  782. assert response.status_code == 200
  783. result = response.json()
  784. assert result["success"] is True
  785. assert 100 in result["skipped_objects"]
  786. mock_client.skip_objects.assert_called_once_with([100])
  787. @pytest.mark.asyncio
  788. @pytest.mark.integration
  789. async def test_skip_objects_multiple(self, async_client: AsyncClient, printer_factory):
  790. """Verify skipping multiple objects at once."""
  791. printer = await printer_factory(name="Printing Printer")
  792. mock_client = MagicMock()
  793. mock_client.state.printable_objects = {100: "Part A", 200: "Part B", 300: "Part C"}
  794. mock_client.state.skipped_objects = []
  795. mock_client.skip_objects.return_value = True
  796. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  797. mock_pm.get_client.return_value = mock_client
  798. response = await async_client.post(f"/api/v1/printers/{printer.id}/print/skip-objects", json=[100, 200])
  799. assert response.status_code == 200
  800. result = response.json()
  801. assert result["success"] is True
  802. assert 100 in result["skipped_objects"]
  803. assert 200 in result["skipped_objects"]
  804. mock_client.skip_objects.assert_called_once_with([100, 200])
  805. class TestChamberLightAPI:
  806. """Integration tests for chamber light control endpoint."""
  807. @pytest.mark.asyncio
  808. @pytest.mark.integration
  809. async def test_chamber_light_not_found(self, async_client: AsyncClient):
  810. """Verify 404 for non-existent printer."""
  811. response = await async_client.post("/api/v1/printers/99999/chamber-light?on=true")
  812. assert response.status_code == 404
  813. @pytest.mark.asyncio
  814. @pytest.mark.integration
  815. async def test_chamber_light_not_connected(self, async_client: AsyncClient, printer_factory):
  816. """Verify error when printer is not connected."""
  817. printer = await printer_factory(name="Disconnected Printer")
  818. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  819. mock_pm.get_client.return_value = None
  820. response = await async_client.post(f"/api/v1/printers/{printer.id}/chamber-light?on=true")
  821. assert response.status_code == 400
  822. assert "not connected" in response.json()["detail"].lower()
  823. @pytest.mark.asyncio
  824. @pytest.mark.integration
  825. async def test_chamber_light_on_success(self, async_client: AsyncClient, printer_factory):
  826. """Verify successful chamber light on request."""
  827. printer = await printer_factory(name="Test Printer")
  828. mock_client = MagicMock()
  829. mock_client.set_chamber_light.return_value = True
  830. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  831. mock_pm.get_client.return_value = mock_client
  832. response = await async_client.post(f"/api/v1/printers/{printer.id}/chamber-light?on=true")
  833. assert response.status_code == 200
  834. result = response.json()
  835. assert result["success"] is True
  836. assert "on" in result["message"].lower()
  837. mock_client.set_chamber_light.assert_called_once_with(True)
  838. @pytest.mark.asyncio
  839. @pytest.mark.integration
  840. async def test_chamber_light_off_success(self, async_client: AsyncClient, printer_factory):
  841. """Verify successful chamber light off request."""
  842. printer = await printer_factory(name="Test Printer")
  843. mock_client = MagicMock()
  844. mock_client.set_chamber_light.return_value = True
  845. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  846. mock_pm.get_client.return_value = mock_client
  847. response = await async_client.post(f"/api/v1/printers/{printer.id}/chamber-light?on=false")
  848. assert response.status_code == 200
  849. result = response.json()
  850. assert result["success"] is True
  851. assert "off" in result["message"].lower()
  852. mock_client.set_chamber_light.assert_called_once_with(False)
  853. @pytest.mark.asyncio
  854. @pytest.mark.integration
  855. async def test_chamber_light_failure(self, async_client: AsyncClient, printer_factory):
  856. """Verify error handling when chamber light control fails."""
  857. printer = await printer_factory(name="Test Printer")
  858. mock_client = MagicMock()
  859. mock_client.set_chamber_light.return_value = False
  860. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  861. mock_pm.get_client.return_value = mock_client
  862. response = await async_client.post(f"/api/v1/printers/{printer.id}/chamber-light?on=true")
  863. assert response.status_code == 500
  864. assert "failed" in response.json()["detail"].lower()
  865. class TestClearHMSErrorsAPI:
  866. """Integration tests for clear HMS errors endpoint."""
  867. @pytest.mark.asyncio
  868. @pytest.mark.integration
  869. async def test_clear_hms_errors_not_found(self, async_client: AsyncClient):
  870. """Verify 404 for non-existent printer."""
  871. response = await async_client.post("/api/v1/printers/99999/hms/clear")
  872. assert response.status_code == 404
  873. @pytest.mark.asyncio
  874. @pytest.mark.integration
  875. async def test_clear_hms_errors_not_connected(self, async_client: AsyncClient, printer_factory):
  876. """Verify error when printer is not connected."""
  877. printer = await printer_factory(name="Disconnected Printer")
  878. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  879. mock_pm.get_client.return_value = None
  880. response = await async_client.post(f"/api/v1/printers/{printer.id}/hms/clear")
  881. assert response.status_code == 400
  882. assert "not connected" in response.json()["detail"].lower()
  883. @pytest.mark.asyncio
  884. @pytest.mark.integration
  885. async def test_clear_hms_errors_success(self, async_client: AsyncClient, printer_factory):
  886. """Verify successful clear HMS errors request."""
  887. printer = await printer_factory(name="Test Printer")
  888. mock_client = MagicMock()
  889. mock_client.clear_hms_errors.return_value = True
  890. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  891. mock_pm.get_client.return_value = mock_client
  892. response = await async_client.post(f"/api/v1/printers/{printer.id}/hms/clear")
  893. assert response.status_code == 200
  894. result = response.json()
  895. assert result["success"] is True
  896. assert "cleared" in result["message"].lower()
  897. mock_client.clear_hms_errors.assert_called_once()
  898. @pytest.mark.asyncio
  899. @pytest.mark.integration
  900. async def test_clear_hms_errors_failure(self, async_client: AsyncClient, printer_factory):
  901. """Verify error handling when clear HMS errors fails."""
  902. printer = await printer_factory(name="Test Printer")
  903. mock_client = MagicMock()
  904. mock_client.clear_hms_errors.return_value = False
  905. with patch("backend.app.api.routes.printers.printer_manager") as mock_pm:
  906. mock_pm.get_client.return_value = mock_client
  907. response = await async_client.post(f"/api/v1/printers/{printer.id}/hms/clear")
  908. assert response.status_code == 500
  909. assert "failed" in response.json()["detail"].lower()