test_scheduler_preheat.py 25 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568
  1. """Tests for the preheat & heat-soak scheduler stage (#1468).
  2. Three layered concerns the stage has to get right:
  3. 1. **Override resolution** (per-item beats global beats default).
  4. 2. **Chamber-target derivation** (item-override > filament-map max > 0).
  5. 3. **Hardware-tier branching** (chamber heater vs sensor-only vs no sensor).
  6. The fixtures construct a queue item with `preheat_override` + the override
  7. target both unset; tests flip those per case. `asyncio.sleep` is patched to
  8. AsyncMock so the soak phase doesn't actually wait — assertions are on what
  9. got scheduled, not wall-clock.
  10. """
  11. from types import SimpleNamespace
  12. from unittest.mock import AsyncMock, MagicMock, patch
  13. import pytest
  14. from backend.app.services.print_scheduler import PrintScheduler
  15. @pytest.fixture
  16. def scheduler():
  17. return PrintScheduler()
  18. @pytest.fixture
  19. def item():
  20. return SimpleNamespace(
  21. id=42,
  22. preheat_override="inherit",
  23. preheat_chamber_target_override=None,
  24. )
  25. @pytest.fixture
  26. def archive():
  27. return SimpleNamespace(bed_temperature=60)
  28. def _make_printer(model: str, printer_id: int = 7):
  29. return SimpleNamespace(id=printer_id, model=model)
  30. def _make_client():
  31. client = MagicMock()
  32. client.set_bed_temperature = MagicMock(return_value=True)
  33. client.set_chamber_temperature = MagicMock(return_value=True)
  34. client.set_airduct_mode = MagicMock(return_value=True)
  35. return client
  36. def _make_state(
  37. bed_temp: float = 0.0,
  38. chamber_temp: float = 0.0,
  39. trays: list[str] | None = None,
  40. airduct_mode: int = 0,
  41. ):
  42. """Build a PrinterState-shaped namespace with optional AMS tray types.
  43. `trays` is a list of tray_type strings (each becomes one loaded slot in
  44. AMS unit 0). Empty / None gives an empty AMS — the derivation falls
  45. through to 0. `airduct_mode` is 0 (cooling, default) or 1 (heating);
  46. matches the field on PrinterState that the preheat stage reads to
  47. decide whether to fire a redundant `set_airduct_mode` call."""
  48. raw_data: dict = {}
  49. if trays is not None:
  50. raw_data["ams"] = [{"tray": [{"tray_type": t} for t in trays]}]
  51. return SimpleNamespace(
  52. temperatures={"bed": bed_temp, "chamber": chamber_temp},
  53. raw_data=raw_data,
  54. airduct_mode=airduct_mode,
  55. )
  56. def _ints(**values):
  57. """Mock side_effect for _get_int_setting that returns the kwarg value
  58. when the key matches, else the helper's `default` argument."""
  59. return AsyncMock(side_effect=lambda _db, key, default: values.get(key, default))
  60. # ----------------------------------------------------------------------------
  61. # Override resolution
  62. # ----------------------------------------------------------------------------
  63. @pytest.mark.asyncio
  64. async def test_global_disabled_inherit_skips(scheduler, item, archive):
  65. """preheat_enabled=False + item.preheat_override='inherit' → no heater dispatch."""
  66. db = AsyncMock()
  67. client = _make_client()
  68. with (
  69. patch.object(scheduler, "_get_bool_setting", AsyncMock(return_value=False)),
  70. patch.object(scheduler, "_get_int_setting", _ints()),
  71. patch("backend.app.services.print_scheduler.printer_manager") as pm,
  72. ):
  73. pm.get_client.return_value = client
  74. await scheduler._preheat_and_soak(db, item, _make_printer("H2D"), archive)
  75. client.set_bed_temperature.assert_not_called()
  76. client.set_chamber_temperature.assert_not_called()
  77. @pytest.mark.asyncio
  78. async def test_item_override_off_bypasses_global_on(scheduler, item, archive):
  79. """preheat_enabled=True + item.preheat_override='off' → preheat suppressed."""
  80. db = AsyncMock()
  81. client = _make_client()
  82. item.preheat_override = "off"
  83. with (
  84. patch.object(scheduler, "_get_bool_setting", AsyncMock(return_value=True)),
  85. patch.object(scheduler, "_get_int_setting", _ints()),
  86. patch("backend.app.services.print_scheduler.printer_manager") as pm,
  87. ):
  88. pm.get_client.return_value = client
  89. await scheduler._preheat_and_soak(db, item, _make_printer("H2D"), archive)
  90. client.set_bed_temperature.assert_not_called()
  91. client.set_chamber_temperature.assert_not_called()
  92. @pytest.mark.asyncio
  93. async def test_item_override_on_runs_despite_global_off(scheduler, item, archive):
  94. """preheat_enabled=False + item.preheat_override='on' → preheat runs (bed
  95. fires, chamber depends on the resolved target)."""
  96. db = AsyncMock()
  97. client = _make_client()
  98. item.preheat_override = "on"
  99. item.preheat_chamber_target_override = 0 # explicit no-chamber so the assertion is sharp
  100. with (
  101. patch.object(scheduler, "_get_bool_setting", AsyncMock(return_value=False)),
  102. patch.object(scheduler, "_get_int_setting", _ints(preheat_soak_seconds=0)),
  103. patch("backend.app.services.print_scheduler.printer_manager") as pm,
  104. patch("backend.app.services.print_scheduler.asyncio.sleep", AsyncMock()),
  105. ):
  106. pm.get_client.return_value = client
  107. pm.get_status.return_value = _make_state(60.0, 0.0)
  108. await scheduler._preheat_and_soak(db, item, _make_printer("H2D"), archive)
  109. client.set_bed_temperature.assert_called_once_with(60)
  110. client.set_chamber_temperature.assert_not_called()
  111. # ----------------------------------------------------------------------------
  112. # Chamber-target derivation
  113. # ----------------------------------------------------------------------------
  114. @pytest.mark.asyncio
  115. async def test_chamber_target_override_beats_filament_map(scheduler, item, archive):
  116. """item.preheat_chamber_target_override is the highest-priority source —
  117. a PLA-only print with an explicit 50°C override still heats the chamber."""
  118. db = AsyncMock()
  119. client = _make_client()
  120. item.preheat_chamber_target_override = 50
  121. with (
  122. patch.object(scheduler, "_get_bool_setting", AsyncMock(return_value=True)),
  123. patch.object(scheduler, "_get_int_setting", _ints(preheat_soak_seconds=0)),
  124. patch("backend.app.services.print_scheduler.printer_manager") as pm,
  125. patch("backend.app.services.print_scheduler.asyncio.sleep", AsyncMock()),
  126. ):
  127. pm.get_client.return_value = client
  128. # Only PLA loaded — filament map would derive 0; override forces 50.
  129. pm.get_status.return_value = _make_state(60.0, 52.0, trays=["PLA Basic"])
  130. await scheduler._preheat_and_soak(db, item, _make_printer("H2D"), archive)
  131. client.set_bed_temperature.assert_called_once_with(60)
  132. client.set_chamber_temperature.assert_called_once_with(50)
  133. @pytest.mark.asyncio
  134. async def test_filament_map_picks_max_across_loaded_slots(scheduler, item, archive):
  135. """Mixed PA + PLA load: PA=50 + PLA=0 → chamber target 50 (the max).
  136. The "lowest common denominator" model is wrong here; PA's requirement
  137. is the binding constraint."""
  138. db = AsyncMock()
  139. client = _make_client()
  140. with (
  141. patch.object(scheduler, "_get_bool_setting", AsyncMock(return_value=True)),
  142. patch.object(scheduler, "_get_int_setting", _ints(preheat_soak_seconds=0)),
  143. patch.object(scheduler, "_get_setting", AsyncMock(return_value=None)),
  144. patch("backend.app.services.print_scheduler.printer_manager") as pm,
  145. patch("backend.app.services.print_scheduler.asyncio.sleep", AsyncMock()),
  146. ):
  147. pm.get_client.return_value = client
  148. # `PA Basic` (note the space) normalises to `PA` which the bundled
  149. # map keys against; a hyphenated `PA-Generic` would normalise to
  150. # `PA-GENERIC` and fall through to `default` (0) — that's a separate
  151. # behaviour the user editor handles by adding a custom key.
  152. pm.get_status.return_value = _make_state(60.0, 52.0, trays=["PLA Basic", "PA Basic"])
  153. await scheduler._preheat_and_soak(db, item, _make_printer("H2D"), archive)
  154. client.set_chamber_temperature.assert_called_once_with(50) # PA's recommendation, not PLA's
  155. @pytest.mark.asyncio
  156. async def test_pla_only_derives_zero_chamber_skips(scheduler, item, archive):
  157. """PLA-only print: filament-map lookup returns 0 → chamber phase skips
  158. automatically without the user touching anything."""
  159. db = AsyncMock()
  160. client = _make_client()
  161. with (
  162. patch.object(scheduler, "_get_bool_setting", AsyncMock(return_value=True)),
  163. patch.object(scheduler, "_get_int_setting", _ints(preheat_soak_seconds=0)),
  164. patch.object(scheduler, "_get_setting", AsyncMock(return_value=None)),
  165. patch("backend.app.services.print_scheduler.printer_manager") as pm,
  166. patch("backend.app.services.print_scheduler.asyncio.sleep", AsyncMock()),
  167. ):
  168. pm.get_client.return_value = client
  169. pm.get_status.return_value = _make_state(60.0, 0.0, trays=["PLA", "PLA"])
  170. await scheduler._preheat_and_soak(db, item, _make_printer("H2D"), archive)
  171. client.set_bed_temperature.assert_called_once_with(60)
  172. client.set_chamber_temperature.assert_not_called()
  173. @pytest.mark.asyncio
  174. async def test_unknown_filament_type_falls_to_default(scheduler, item, archive):
  175. """A loaded tray with a type not in the map uses the `default` entry —
  176. keeps users with custom filament names safe (they get 0 by default,
  177. can be tuned via the per-filament editor)."""
  178. db = AsyncMock()
  179. client = _make_client()
  180. with (
  181. patch.object(scheduler, "_get_bool_setting", AsyncMock(return_value=True)),
  182. patch.object(scheduler, "_get_int_setting", _ints(preheat_soak_seconds=0)),
  183. patch.object(scheduler, "_get_setting", AsyncMock(return_value=None)),
  184. patch("backend.app.services.print_scheduler.printer_manager") as pm,
  185. patch("backend.app.services.print_scheduler.asyncio.sleep", AsyncMock()),
  186. ):
  187. pm.get_client.return_value = client
  188. pm.get_status.return_value = _make_state(60.0, 0.0, trays=["MyCustomFilament"])
  189. await scheduler._preheat_and_soak(db, item, _make_printer("H2D"), archive)
  190. client.set_bed_temperature.assert_called_once_with(60)
  191. client.set_chamber_temperature.assert_not_called() # default = 0
  192. @pytest.mark.asyncio
  193. async def test_custom_filament_targets_json_parses(scheduler, item, archive):
  194. """User-customised filament-target JSON overrides the bundled defaults —
  195. raising PLA to 30°C makes a PLA-only print actually heat the chamber."""
  196. db = AsyncMock()
  197. client = _make_client()
  198. custom_map = '{"PLA": 30, "default": 0}'
  199. with (
  200. patch.object(scheduler, "_get_bool_setting", AsyncMock(return_value=True)),
  201. patch.object(scheduler, "_get_int_setting", _ints(preheat_soak_seconds=0)),
  202. patch.object(scheduler, "_get_setting", AsyncMock(return_value=custom_map)),
  203. patch("backend.app.services.print_scheduler.printer_manager") as pm,
  204. patch("backend.app.services.print_scheduler.asyncio.sleep", AsyncMock()),
  205. ):
  206. pm.get_client.return_value = client
  207. pm.get_status.return_value = _make_state(60.0, 31.0, trays=["PLA Basic"])
  208. await scheduler._preheat_and_soak(db, item, _make_printer("H2D"), archive)
  209. client.set_chamber_temperature.assert_called_once_with(30)
  210. @pytest.mark.asyncio
  211. async def test_malformed_filament_targets_falls_back_to_defaults(scheduler, item, archive):
  212. """A corrupted JSON in the setting must not break the scheduler — log
  213. and use bundled defaults."""
  214. db = AsyncMock()
  215. client = _make_client()
  216. with (
  217. patch.object(scheduler, "_get_bool_setting", AsyncMock(return_value=True)),
  218. patch.object(scheduler, "_get_int_setting", _ints(preheat_soak_seconds=0)),
  219. patch.object(scheduler, "_get_setting", AsyncMock(return_value="not-json{{{")),
  220. patch("backend.app.services.print_scheduler.printer_manager") as pm,
  221. patch("backend.app.services.print_scheduler.asyncio.sleep", AsyncMock()),
  222. ):
  223. pm.get_client.return_value = client
  224. # Bundled default for ABS = 45 → chamber should fire.
  225. pm.get_status.return_value = _make_state(60.0, 46.0, trays=["ABS"])
  226. await scheduler._preheat_and_soak(db, item, _make_printer("H2D"), archive)
  227. client.set_chamber_temperature.assert_called_once_with(45)
  228. # ----------------------------------------------------------------------------
  229. # Hardware-tier branching (unchanged from the first cut but updated for new
  230. # fixtures that include AMS data so the derivation lands at a non-zero target).
  231. # ----------------------------------------------------------------------------
  232. @pytest.mark.asyncio
  233. async def test_no_bed_temperature_in_archive_skips(scheduler, item):
  234. """Archive without bed_temperature metadata skips entirely rather than
  235. guessing a default that might wreck a non-PLA print."""
  236. db = AsyncMock()
  237. client = _make_client()
  238. bare_archive = SimpleNamespace(bed_temperature=None)
  239. with (
  240. patch.object(scheduler, "_get_bool_setting", AsyncMock(return_value=True)),
  241. patch.object(scheduler, "_get_int_setting", _ints()),
  242. patch.object(scheduler, "_get_setting", AsyncMock(return_value=None)),
  243. patch("backend.app.services.print_scheduler.printer_manager") as pm,
  244. ):
  245. pm.get_client.return_value = client
  246. pm.get_status.return_value = _make_state(trays=["ABS"])
  247. await scheduler._preheat_and_soak(db, item, _make_printer("H2D"), bare_archive)
  248. client.set_bed_temperature.assert_not_called()
  249. client.set_chamber_temperature.assert_not_called()
  250. @pytest.mark.asyncio
  251. async def test_x1c_skips_m141_but_waits_passively(scheduler, item, archive):
  252. """X1C has a chamber sensor but no active heater — M141 must NOT fire even
  253. when the filament map derives a non-zero target."""
  254. db = AsyncMock()
  255. client = _make_client()
  256. with (
  257. patch.object(scheduler, "_get_bool_setting", AsyncMock(return_value=True)),
  258. patch.object(scheduler, "_get_int_setting", _ints(preheat_soak_seconds=0)),
  259. patch.object(scheduler, "_get_setting", AsyncMock(return_value=None)),
  260. patch("backend.app.services.print_scheduler.printer_manager") as pm,
  261. patch("backend.app.services.print_scheduler.asyncio.sleep", AsyncMock()),
  262. ):
  263. pm.get_client.return_value = client
  264. # ABS loaded → derived target 45; sensor reads 46 (already there).
  265. pm.get_status.return_value = _make_state(60.0, 46.0, trays=["ABS"])
  266. await scheduler._preheat_and_soak(db, item, _make_printer("X1C"), archive)
  267. client.set_bed_temperature.assert_called_once_with(60)
  268. client.set_chamber_temperature.assert_not_called()
  269. @pytest.mark.asyncio
  270. async def test_p1s_no_chamber_sensor_uses_soak_timer_only(scheduler, item, archive):
  271. """P1S has no chamber sensor — derived target is ignored for the wait
  272. loop, only the soak timer applies."""
  273. db = AsyncMock()
  274. client = _make_client()
  275. with (
  276. patch.object(scheduler, "_get_bool_setting", AsyncMock(return_value=True)),
  277. patch.object(scheduler, "_get_int_setting", _ints(preheat_soak_seconds=600)),
  278. patch.object(scheduler, "_get_setting", AsyncMock(return_value=None)),
  279. patch("backend.app.services.print_scheduler.printer_manager") as pm,
  280. patch("backend.app.services.print_scheduler.asyncio.sleep", AsyncMock()) as sleep_mock,
  281. ):
  282. pm.get_client.return_value = client
  283. pm.get_status.return_value = _make_state(60.0, 0.0, trays=["ABS"])
  284. await scheduler._preheat_and_soak(db, item, _make_printer("P1S"), archive)
  285. client.set_bed_temperature.assert_called_once_with(60)
  286. client.set_chamber_temperature.assert_not_called()
  287. assert 600 in [call.args[0] for call in sleep_mock.call_args_list]
  288. @pytest.mark.asyncio
  289. async def test_lost_client_skips_silently(scheduler, item, archive):
  290. """If the MQTT client drops, the helper returns without raising."""
  291. db = AsyncMock()
  292. with (
  293. patch.object(scheduler, "_get_bool_setting", AsyncMock(return_value=True)),
  294. patch.object(scheduler, "_get_int_setting", _ints()),
  295. patch.object(scheduler, "_get_setting", AsyncMock(return_value=None)),
  296. patch("backend.app.services.print_scheduler.printer_manager") as pm,
  297. ):
  298. pm.get_client.return_value = None
  299. await scheduler._preheat_and_soak(db, item, _make_printer("H2D"), archive)
  300. # No exception escaping — the disable path is silent.
  301. @pytest.mark.asyncio
  302. async def test_h2d_flips_airduct_to_heating_before_m141(scheduler, item, archive):
  303. """H-series + X2D have a cooling/heating airduct flap that DEFAULTS to
  304. cooling. If we energise M141 without first flipping to heating, the
  305. chamber fan actively extracts the heat we're trying to put in and the
  306. chamber never converges. Verify airduct=heating fires AND lands before
  307. the chamber-target call so the heater starts in the right airflow regime."""
  308. db = AsyncMock()
  309. client = _make_client()
  310. call_order = []
  311. client.set_airduct_mode.side_effect = lambda mode: call_order.append(("airduct", mode)) or True
  312. client.set_chamber_temperature.side_effect = lambda t: call_order.append(("chamber", t)) or True
  313. with (
  314. patch.object(scheduler, "_get_bool_setting", AsyncMock(return_value=True)),
  315. patch.object(scheduler, "_get_int_setting", _ints(preheat_soak_seconds=0)),
  316. patch.object(scheduler, "_get_setting", AsyncMock(return_value=None)),
  317. patch("backend.app.services.print_scheduler.printer_manager") as pm,
  318. patch("backend.app.services.print_scheduler.asyncio.sleep", AsyncMock()),
  319. ):
  320. pm.get_client.return_value = client
  321. pm.get_status.return_value = _make_state(60.0, 46.0, trays=["ABS"])
  322. await scheduler._preheat_and_soak(db, item, _make_printer("H2D"), archive)
  323. client.set_airduct_mode.assert_called_once_with("heating")
  324. client.set_chamber_temperature.assert_called_once_with(45)
  325. # Airduct heating must precede M141 — the heater enabling first while the
  326. # flap is still in cooling mode wastes minutes of fan-vs-heater tug-of-war.
  327. assert call_order == [("airduct", "heating"), ("chamber", 45)]
  328. @pytest.mark.asyncio
  329. async def test_x1c_skips_airduct_no_heater_no_call(scheduler, item, archive):
  330. """X1C has neither an active chamber heater nor an airduct flap (the
  331. frontend's airduct whitelist is P2S/X2D/H2D/H2C/H2S/H2D Pro — no X1
  332. series). The preheat stage's airduct call is gated on supports_airduct
  333. AND has_heater, so X1C gets neither call regardless. Important: a
  334. spurious set_airduct on X1C wouldn't just be wasted MQTT — there's no
  335. flap to set, so the firmware response would be undefined behaviour."""
  336. db = AsyncMock()
  337. client = _make_client()
  338. with (
  339. patch.object(scheduler, "_get_bool_setting", AsyncMock(return_value=True)),
  340. patch.object(scheduler, "_get_int_setting", _ints(preheat_soak_seconds=0)),
  341. patch.object(scheduler, "_get_setting", AsyncMock(return_value=None)),
  342. patch("backend.app.services.print_scheduler.printer_manager") as pm,
  343. patch("backend.app.services.print_scheduler.asyncio.sleep", AsyncMock()),
  344. ):
  345. pm.get_client.return_value = client
  346. pm.get_status.return_value = _make_state(60.0, 46.0, trays=["ABS"])
  347. await scheduler._preheat_and_soak(db, item, _make_printer("X1C"), archive)
  348. client.set_chamber_temperature.assert_not_called()
  349. client.set_airduct_mode.assert_not_called()
  350. @pytest.mark.asyncio
  351. async def test_normalize_filament_type_strips_at_space():
  352. """`PLA Basic` and `ABS Premium` should normalise to `PLA` and `ABS` so
  353. they match the map keys. `PA-CF` has no space and stays verbatim."""
  354. s = PrintScheduler
  355. assert s._normalize_filament_type("PLA Basic") == "PLA"
  356. assert s._normalize_filament_type("ABS Premium") == "ABS"
  357. assert s._normalize_filament_type("PA-CF") == "PA-CF"
  358. assert s._normalize_filament_type("") == ""
  359. assert s._normalize_filament_type("petg") == "PETG" # case-folded
  360. @pytest.mark.asyncio
  361. async def test_get_preheat_filament_targets_defaults_when_missing(scheduler):
  362. """Empty / null setting → bundled defaults are used. _get_preheat_filament_targets
  363. upper-cases the keys, so the bundled `default` becomes `DEFAULT` on the
  364. returned dict — keep both spellings synced."""
  365. db = AsyncMock()
  366. with patch.object(scheduler, "_get_setting", AsyncMock(return_value=None)):
  367. targets = await scheduler._get_preheat_filament_targets(db)
  368. # The bundled defaults dict is kept as-is on the "no setting" path, so
  369. # `default` (lowercase) is what callers see for that fallback.
  370. assert targets["PLA"] == 0
  371. assert targets["ABS"] == 45
  372. assert targets["PA-CF"] == 55
  373. # Either casing must resolve to the fallback 0.
  374. assert targets.get("default", targets.get("DEFAULT")) == 0
  375. # ----------------------------------------------------------------------------
  376. # Airduct mode switch (#1468 follow-up)
  377. # ----------------------------------------------------------------------------
  378. @pytest.mark.asyncio
  379. async def test_h2d_chamber_heat_switches_airduct_to_heating(scheduler, item, archive):
  380. """H2D in cooling mode (the default; what you get after a PLA print)
  381. with chamber_target > 0 must switch the airduct to heating BEFORE the
  382. M141 dispatch — otherwise the open exhaust flap actively fights the
  383. chamber heater and the chamber never converges."""
  384. db = AsyncMock()
  385. client = _make_client()
  386. with (
  387. patch.object(scheduler, "_get_bool_setting", AsyncMock(return_value=True)),
  388. patch.object(scheduler, "_get_int_setting", _ints(preheat_soak_seconds=0)),
  389. patch.object(scheduler, "_get_setting", AsyncMock(return_value=None)),
  390. patch("backend.app.services.print_scheduler.printer_manager") as pm,
  391. patch("backend.app.services.print_scheduler.asyncio.sleep", AsyncMock()),
  392. ):
  393. pm.get_client.return_value = client
  394. # Currently in cooling (mode 0). ABS loaded → derived target 45.
  395. pm.get_status.return_value = _make_state(60.0, 46.0, trays=["ABS"], airduct_mode=0)
  396. await scheduler._preheat_and_soak(db, item, _make_printer("H2D"), archive)
  397. client.set_airduct_mode.assert_called_once_with("heating")
  398. client.set_chamber_temperature.assert_called_once_with(45)
  399. @pytest.mark.asyncio
  400. async def test_h2d_chamber_zero_switches_airduct_to_cooling(scheduler, item, archive):
  401. """H2D running a PLA print (chamber_target derives 0) on an airduct
  402. previously left in heating mode (from a prior ABS run) must switch
  403. back to cooling. Otherwise PLA prints inherit ABS's closed-flap recirc
  404. and run hot."""
  405. db = AsyncMock()
  406. client = _make_client()
  407. with (
  408. patch.object(scheduler, "_get_bool_setting", AsyncMock(return_value=True)),
  409. patch.object(scheduler, "_get_int_setting", _ints(preheat_soak_seconds=0)),
  410. patch.object(scheduler, "_get_setting", AsyncMock(return_value=None)),
  411. patch("backend.app.services.print_scheduler.printer_manager") as pm,
  412. patch("backend.app.services.print_scheduler.asyncio.sleep", AsyncMock()),
  413. ):
  414. pm.get_client.return_value = client
  415. # Currently in heating (mode 1). PLA loaded → derived target 0.
  416. pm.get_status.return_value = _make_state(60.0, 30.0, trays=["PLA"], airduct_mode=1)
  417. await scheduler._preheat_and_soak(db, item, _make_printer("H2D"), archive)
  418. client.set_airduct_mode.assert_called_once_with("cooling")
  419. client.set_chamber_temperature.assert_not_called()
  420. @pytest.mark.asyncio
  421. async def test_h2d_airduct_already_correct_idempotent(scheduler, item, archive):
  422. """If the airduct is already in the desired mode, don't re-send
  423. `set_airduct` — the firmware accepts it but it generates needless MQTT
  424. chatter and could thrash the flap motor on rapid repeats."""
  425. db = AsyncMock()
  426. client = _make_client()
  427. with (
  428. patch.object(scheduler, "_get_bool_setting", AsyncMock(return_value=True)),
  429. patch.object(scheduler, "_get_int_setting", _ints(preheat_soak_seconds=0)),
  430. patch.object(scheduler, "_get_setting", AsyncMock(return_value=None)),
  431. patch("backend.app.services.print_scheduler.printer_manager") as pm,
  432. patch("backend.app.services.print_scheduler.asyncio.sleep", AsyncMock()),
  433. ):
  434. pm.get_client.return_value = client
  435. # Already in heating (mode 1) and ABS → derived 45 wants heating.
  436. pm.get_status.return_value = _make_state(60.0, 46.0, trays=["ABS"], airduct_mode=1)
  437. await scheduler._preheat_and_soak(db, item, _make_printer("H2D"), archive)
  438. client.set_airduct_mode.assert_not_called()
  439. # But M141 still fires — the airduct decision is independent.
  440. client.set_chamber_temperature.assert_called_once_with(45)
  441. @pytest.mark.asyncio
  442. async def test_x1c_no_airduct_flap_never_fires_set_airduct(scheduler, item, archive):
  443. """X1C has a chamber sensor but no airduct flap — the firmware ignores
  444. `set_airduct`. We gate on `supports_airduct(model)` to avoid sending the
  445. no-op. Regression guard: wiring this to `supports_chamber_temp` or
  446. `supports_chamber_heater` alone would have leaked the command to
  447. X1C/X1E or P2S inappropriately."""
  448. db = AsyncMock()
  449. client = _make_client()
  450. with (
  451. patch.object(scheduler, "_get_bool_setting", AsyncMock(return_value=True)),
  452. patch.object(scheduler, "_get_int_setting", _ints(preheat_soak_seconds=0)),
  453. patch.object(scheduler, "_get_setting", AsyncMock(return_value=None)),
  454. patch("backend.app.services.print_scheduler.printer_manager") as pm,
  455. patch("backend.app.services.print_scheduler.asyncio.sleep", AsyncMock()),
  456. ):
  457. pm.get_client.return_value = client
  458. pm.get_status.return_value = _make_state(60.0, 46.0, trays=["ABS"], airduct_mode=0)
  459. await scheduler._preheat_and_soak(db, item, _make_printer("X1C"), archive)
  460. client.set_airduct_mode.assert_not_called()