test_spoolman_tracking.py 15 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376
  1. """Unit tests for Spoolman tracking service helpers."""
  2. import json
  3. from types import SimpleNamespace
  4. from unittest.mock import AsyncMock, MagicMock, patch
  5. import pytest
  6. from backend.app.services.spoolman_tracking import (
  7. _apply_spool_colors_to_archive,
  8. _get_fallback_spool_tag,
  9. _global_tray_id_to_ams_slot,
  10. _hash_serial_to_hex32,
  11. _resolve_global_tray_id,
  12. _resolve_spool_tag,
  13. build_ams_tray_lookup,
  14. store_print_data,
  15. )
  16. class TestResolveSpoolTag:
  17. """Tests for _resolve_spool_tag()."""
  18. def test_prefers_tray_uuid_over_tag_uid(self):
  19. tray = {"tray_uuid": "A1B2C3D4E5F6A1B2C3D4E5F6A1B2C3D4", "tag_uid": "DEADBEEF"}
  20. assert _resolve_spool_tag(tray) == "A1B2C3D4E5F6A1B2C3D4E5F6A1B2C3D4"
  21. def test_falls_back_to_tag_uid_when_no_uuid(self):
  22. tray = {"tray_uuid": "", "tag_uid": "DEADBEEF"}
  23. assert _resolve_spool_tag(tray) == "DEADBEEF"
  24. def test_falls_back_to_tag_uid_when_uuid_zero(self):
  25. tray = {"tray_uuid": "00000000000000000000000000000000", "tag_uid": "DEADBEEF"}
  26. assert _resolve_spool_tag(tray) == "DEADBEEF"
  27. def test_rejects_zero_tag_uid(self):
  28. tray = {"tray_uuid": "", "tag_uid": "0000000000000000"}
  29. assert _resolve_spool_tag(tray) == ""
  30. def test_uses_fallback_tag_when_ids_missing(self):
  31. tray = {"tray_uuid": "", "tag_uid": ""}
  32. # global_tray_id 0 -> ams_id 0, tray_id 0
  33. assert _resolve_spool_tag(tray, "01P00A000000000", 0) == "ABA7845700000000"
  34. def test_uses_fallback_tag_when_ids_zero(self):
  35. tray = {"tray_uuid": "00000000000000000000000000000000", "tag_uid": "0000000000000000"}
  36. # global_tray_id 5 -> ams_id 1, tray_id 1
  37. assert _resolve_spool_tag(tray, "01P00A000000000", 5) == "ABA7845700010001"
  38. def test_prefers_tray_uuid_over_fallback_when_non_zero(self):
  39. tray = {"tray_uuid": "A1B2C3D4E5F6A1B2C3D4E5F6A1B2C3D4", "tag_uid": ""}
  40. assert _resolve_spool_tag(tray, "01P00A000000000", 0) == "A1B2C3D4E5F6A1B2C3D4E5F6A1B2C3D4"
  41. def test_empty_both(self):
  42. tray = {"tray_uuid": "", "tag_uid": ""}
  43. assert _resolve_spool_tag(tray) == ""
  44. def test_missing_keys(self):
  45. assert _resolve_spool_tag({}) == ""
  46. def test_zero_uuid_no_tag(self):
  47. tray = {"tray_uuid": "00000000000000000000000000000000", "tag_uid": ""}
  48. assert _resolve_spool_tag(tray) == ""
  49. class TestResolveGlobalTrayId:
  50. """Tests for _resolve_global_tray_id()."""
  51. def test_default_mapping(self):
  52. """slot 1 -> tray 0, slot 2 -> tray 1, etc."""
  53. assert _resolve_global_tray_id(1, None) == 0
  54. assert _resolve_global_tray_id(2, None) == 1
  55. assert _resolve_global_tray_id(4, None) == 3
  56. def test_custom_mapping(self):
  57. """Custom slot_to_tray overrides default."""
  58. mapping = [5, 2, -1, 0]
  59. assert _resolve_global_tray_id(1, mapping) == 5
  60. assert _resolve_global_tray_id(2, mapping) == 2
  61. assert _resolve_global_tray_id(4, mapping) == 0
  62. def test_unmapped_slot(self):
  63. """Slot with -1 in mapping uses default."""
  64. mapping = [5, -1, 2, 0]
  65. assert _resolve_global_tray_id(2, mapping) == 1 # default: slot 2 -> tray 1
  66. def test_slot_beyond_mapping(self):
  67. """Slot beyond mapping length uses default."""
  68. mapping = [5, 2]
  69. assert _resolve_global_tray_id(3, mapping) == 2 # default: slot 3 -> tray 2
  70. def test_empty_mapping(self):
  71. mapping = []
  72. assert _resolve_global_tray_id(1, mapping) == 0
  73. def test_minus_one_resolves_to_external_spool_when_present(self):
  74. """#1276 (regression of #853): -1 in slot_to_tray is BambuStudio's
  75. encoding for "external spool used" — look up the external spool in
  76. ams_trays rather than falling through to the position-based default
  77. (which would credit an unrelated AMS tray). Reporter ojimpo's H2S
  78. had AMS slot 0 occupied with PLA and ran a TPU external-spool print;
  79. the bug credited the TPU usage to the PLA spool.
  80. """
  81. # Single external spool (most common: H2S/X1C/P1S + external)
  82. assert _resolve_global_tray_id(1, [-1], ams_trays={254: {}}) == 254
  83. # AMS occupied with material AND external in use — fix prevents
  84. # crediting AMS slot 0 (the actual bug from #1276)
  85. assert _resolve_global_tray_id(1, [-1], ams_trays={0: {}, 1: {}, 2: {}, 3: {}, 254: {}}) == 254
  86. # H2D-style deputy nozzle at 255
  87. assert _resolve_global_tray_id(1, [-1], ams_trays={0: {}, 255: {}}) == 255
  88. # Both external slots present (multi-nozzle) — prefer 254 (main on
  89. # single-nozzle, deputy on H2D — matches tray_now reporting)
  90. assert _resolve_global_tray_id(1, [-1], ams_trays={254: {}, 255: {}}) == 254
  91. def test_minus_one_falls_through_when_no_external_in_ams_trays(self):
  92. """If -1 is seen but ams_trays has no external spool (254/255),
  93. fall through to position-based default (legacy behavior preserved
  94. for callers that don't pass ams_trays or pre-fix call sites).
  95. """
  96. # ams_trays without external — fall through to legacy behavior
  97. assert _resolve_global_tray_id(1, [-1], ams_trays={0: {}, 1: {}}) == 0
  98. # No ams_trays passed at all — legacy fallback
  99. assert _resolve_global_tray_id(1, [-1]) == 0
  100. class TestFallbackTagHelpers:
  101. """Tests for frontend-mirrored fallback tag helpers."""
  102. def test_hash_serial_matches_frontend_algorithm(self):
  103. assert _hash_serial_to_hex32("01P00A000000000") == "ABA78457"
  104. # Frontend trims and uppercases before hashing
  105. assert _hash_serial_to_hex32(" 01p00a000000000 ") == "ABA78457"
  106. def test_global_tray_to_ams_slot_standard_ams(self):
  107. assert _global_tray_id_to_ams_slot(0) == (0, 0)
  108. assert _global_tray_id_to_ams_slot(7) == (1, 3)
  109. def test_global_tray_to_ams_slot_ams_ht(self):
  110. assert _global_tray_id_to_ams_slot(128) == (128, 0)
  111. assert _global_tray_id_to_ams_slot(135) == (135, 0)
  112. def test_global_tray_to_ams_slot_external(self):
  113. assert _global_tray_id_to_ams_slot(254) == (255, 0)
  114. assert _global_tray_id_to_ams_slot(255) == (255, 1)
  115. def test_get_fallback_spool_tag_standard(self):
  116. assert _get_fallback_spool_tag("01P00A000000000", 5) == "ABA7845700010001"
  117. def test_get_fallback_spool_tag_ams_ht(self):
  118. assert _get_fallback_spool_tag("01P00A000000000", 128) == "ABA7845700800000"
  119. def test_get_fallback_spool_tag_external(self):
  120. assert _get_fallback_spool_tag("01P00A000000000", 255) == "ABA7845700FF0001"
  121. class TestBuildAmsTrayLookup:
  122. """Tests for build_ams_tray_lookup()."""
  123. def test_single_ams_unit(self):
  124. raw = {
  125. "ams": [
  126. {
  127. "id": 0,
  128. "tray": [
  129. {"id": 0, "tray_uuid": "AAA", "tag_uid": "111", "tray_type": "PLA"},
  130. {"id": 1, "tray_uuid": "BBB", "tag_uid": "222", "tray_type": "ABS"},
  131. ],
  132. }
  133. ]
  134. }
  135. lookup = build_ams_tray_lookup(raw)
  136. assert lookup[0] == {"tray_uuid": "AAA", "tag_uid": "111", "tray_type": "PLA"}
  137. assert lookup[1] == {"tray_uuid": "BBB", "tag_uid": "222", "tray_type": "ABS"}
  138. def test_multiple_ams_units(self):
  139. raw = {
  140. "ams": [
  141. {"id": 0, "tray": [{"id": 0, "tray_uuid": "A", "tag_uid": "", "tray_type": "PLA"}]},
  142. {"id": 1, "tray": [{"id": 0, "tray_uuid": "B", "tag_uid": "", "tray_type": "PETG"}]},
  143. ]
  144. }
  145. lookup = build_ams_tray_lookup(raw)
  146. assert 0 in lookup # AMS 0, tray 0
  147. assert 4 in lookup # AMS 1, tray 0 (1*4+0)
  148. assert lookup[4]["tray_uuid"] == "B"
  149. def test_external_spool(self):
  150. raw = {
  151. "ams": [],
  152. "vt_tray": [{"tray_uuid": "EXT", "tag_uid": "X", "tray_type": "TPU"}],
  153. }
  154. lookup = build_ams_tray_lookup(raw)
  155. assert 254 in lookup
  156. assert lookup[254]["tray_type"] == "TPU"
  157. def test_empty_external_spool_skipped(self):
  158. raw = {"ams": [], "vt_tray": [{"tray_type": ""}]}
  159. lookup = build_ams_tray_lookup(raw)
  160. assert 254 not in lookup
  161. def test_no_ams_data(self):
  162. assert build_ams_tray_lookup({}) == {}
  163. assert build_ams_tray_lookup({"ams": []}) == {}
  164. def test_missing_fields_default(self):
  165. raw = {"ams": [{"id": 0, "tray": [{"id": 0}]}]}
  166. lookup = build_ams_tray_lookup(raw)
  167. assert lookup[0] == {"tray_uuid": "", "tag_uid": "", "tray_type": ""}
  168. class TestStorePrintData:
  169. """Tests for store_print_data()."""
  170. @pytest.mark.asyncio
  171. async def test_prefers_explicit_ams_mapping_over_queue_mapping(self):
  172. db = AsyncMock()
  173. # store_print_data now queries the queue item unconditionally (to pick up
  174. # plate_id for multi-plate 3MFs, #1697), then deletes any stale spoolman
  175. # row before inserting the new one. Two execute calls in that order.
  176. queue_item = SimpleNamespace(ams_mapping=json.dumps([2, -1, -1, -1]), plate_id=None)
  177. queue_result = MagicMock()
  178. queue_result.scalar_one_or_none.return_value = queue_item
  179. delete_result = MagicMock()
  180. db.execute = AsyncMock(side_effect=[queue_result, delete_result])
  181. db.add = MagicMock()
  182. db.commit = AsyncMock()
  183. printer_manager = MagicMock()
  184. printer_manager.get_status.return_value = SimpleNamespace(
  185. raw_data={"ams": [{"id": 0, "tray": [{"id": 0, "tray_type": "PLA"}, {"id": 1, "tray_type": "PLA"}]}]}
  186. )
  187. mock_settings = MagicMock()
  188. mock_path = MagicMock()
  189. mock_path.exists.return_value = True
  190. mock_settings.base_dir.__truediv__.return_value = mock_path
  191. with (
  192. patch("backend.app.services.spoolman_tracking.app_settings", mock_settings),
  193. patch("backend.app.api.routes.settings.get_setting", AsyncMock(side_effect=["true", "true"])),
  194. patch(
  195. "backend.app.utils.threemf_tools.extract_filament_usage_from_3mf",
  196. return_value=[{"slot_id": 1, "used_g": 3.83, "type": "PLA", "color": "#FF0000"}],
  197. ),
  198. patch("backend.app.utils.threemf_tools.extract_layer_filament_usage_from_3mf", return_value=None),
  199. patch("backend.app.utils.threemf_tools.extract_filament_properties_from_3mf", return_value={}),
  200. ):
  201. await store_print_data(
  202. printer_id=1,
  203. archive_id=15,
  204. file_path="archives/test.3mf",
  205. db=db,
  206. printer_manager=printer_manager,
  207. ams_mapping=[1, -1, -1, -1],
  208. )
  209. db.add.assert_called_once()
  210. tracking = db.add.call_args.args[0]
  211. assert tracking.slot_to_tray == [1, -1, -1, -1]
  212. assert db.execute.await_count == 2
  213. @pytest.mark.asyncio
  214. async def test_stores_tracking_when_disable_weight_sync_is_false(self):
  215. """#1119: per-print tracking must run regardless of disable_weight_sync.
  216. Previously store_print_data short-circuited when the deprecated
  217. `spoolman_disable_weight_sync` flag was off, leaving non-BL spools
  218. with no weight-update path at all. Per-print tracking is now the
  219. only weight writer for Spoolman, so it must run whenever Spoolman
  220. is enabled.
  221. """
  222. db = AsyncMock()
  223. db.execute = AsyncMock(return_value=MagicMock())
  224. db.add = MagicMock()
  225. db.commit = AsyncMock()
  226. printer_manager = MagicMock()
  227. printer_manager.get_status.return_value = SimpleNamespace(
  228. raw_data={"ams": [{"id": 0, "tray": [{"id": 0, "tray_type": "PLA"}]}]}
  229. )
  230. mock_settings = MagicMock()
  231. mock_path = MagicMock()
  232. mock_path.exists.return_value = True
  233. mock_settings.base_dir.__truediv__.return_value = mock_path
  234. # Only spoolman_enabled is consulted now (disable_weight_sync is no
  235. # longer read). The single side_effect entry proves no extra
  236. # get_setting calls slip back in.
  237. with (
  238. patch("backend.app.services.spoolman_tracking.app_settings", mock_settings),
  239. patch("backend.app.api.routes.settings.get_setting", AsyncMock(side_effect=["true"])),
  240. patch(
  241. "backend.app.utils.threemf_tools.extract_filament_usage_from_3mf",
  242. return_value=[{"slot_id": 1, "used_g": 5.0, "type": "PLA", "color": "#FF0000"}],
  243. ),
  244. patch("backend.app.utils.threemf_tools.extract_layer_filament_usage_from_3mf", return_value=None),
  245. patch("backend.app.utils.threemf_tools.extract_filament_properties_from_3mf", return_value={}),
  246. ):
  247. await store_print_data(
  248. printer_id=1,
  249. archive_id=20,
  250. file_path="archives/test.3mf",
  251. db=db,
  252. printer_manager=printer_manager,
  253. ams_mapping=[0],
  254. )
  255. # Tracking row was inserted — the fix is working.
  256. db.add.assert_called_once()
  257. class TestApplySpoolColorsToArchive:
  258. """`_apply_spool_colors_to_archive` stamps the archive's filament_color
  259. from the matched Spoolman spools (#1494) — the Spoolman-mode mirror of
  260. the built-in inventory rewrite in usage_tracker."""
  261. def _make_db(self, archive):
  262. db = AsyncMock()
  263. db.execute = AsyncMock(return_value=MagicMock(scalar_one_or_none=MagicMock(return_value=archive)))
  264. return db
  265. @pytest.mark.asyncio
  266. async def test_rewrites_color_from_spoolman_spool(self):
  267. """The #1494 case: 3MF said #161616, the Spoolman spool is 000000."""
  268. archive = MagicMock()
  269. archive.filament_color = "#161616"
  270. db = self._make_db(archive)
  271. await _apply_spool_colors_to_archive(
  272. db,
  273. archive_id=10,
  274. filament_usage=[{"slot_id": 1, "used_g": 15.9}],
  275. slot_colors={1: "000000"},
  276. )
  277. assert archive.filament_color == "#000000"
  278. db.commit.assert_awaited()
  279. @pytest.mark.asyncio
  280. async def test_empty_slot_colors_is_noop(self):
  281. """No resolved spool colours — never touches the DB."""
  282. db = self._make_db(MagicMock())
  283. await _apply_spool_colors_to_archive(
  284. db, archive_id=10, filament_usage=[{"slot_id": 1, "used_g": 15.9}], slot_colors={}
  285. )
  286. db.execute.assert_not_awaited()
  287. db.commit.assert_not_awaited()
  288. @pytest.mark.asyncio
  289. async def test_partial_match_leaves_archive_untouched(self):
  290. """Slot 2 used but unresolved — keep the 3MF colour, don't load the archive."""
  291. db = self._make_db(MagicMock())
  292. await _apply_spool_colors_to_archive(
  293. db,
  294. archive_id=10,
  295. filament_usage=[
  296. {"slot_id": 1, "used_g": 10.0},
  297. {"slot_id": 2, "used_g": 20.0},
  298. ],
  299. slot_colors={1: "000000"},
  300. )
  301. db.execute.assert_not_awaited()
  302. db.commit.assert_not_awaited()
  303. @pytest.mark.asyncio
  304. async def test_missing_archive_does_not_crash(self):
  305. """Archive row gone (deleted between completion and reporting)."""
  306. db = self._make_db(None)
  307. await _apply_spool_colors_to_archive(
  308. db,
  309. archive_id=10,
  310. filament_usage=[{"slot_id": 1, "used_g": 15.9}],
  311. slot_colors={1: "000000"},
  312. )
  313. db.commit.assert_not_awaited()