/** * Frontend tests for the AddNotificationModal — focused on the per-event * ntfy Priority section (#990). * * Coverage: * - Priority section renders only for ntfy provider type. * - Section lists ONLY events the user has enabled, not the whole catalogue. * - Save round-trips event_priorities into config. * - Editing an existing ntfy provider pre-fills priorities from config. * - Switching off a toggle drops the matching row from the priority section. * - For non-ntfy providers, event_priorities never appears in the saved config. */ import { describe, it, expect, afterEach, vi } from 'vitest'; import { screen, waitFor, within } from '@testing-library/react'; import userEvent from '@testing-library/user-event'; import { http, HttpResponse } from 'msw'; import { render } from '../utils'; import { server } from '../mocks/server'; import { AddNotificationModal } from '../../components/AddNotificationModal'; import type { NotificationProvider } from '../../api/client'; afterEach(() => { server.resetHandlers(); vi.restoreAllMocks(); }); function buildProvider(overrides: Partial = {}): NotificationProvider { return { id: 1, name: 'My ntfy', provider_type: 'ntfy', enabled: true, config: { server: 'https://ntfy.sh', topic: 'bambuddy' }, on_print_start: false, on_print_complete: true, on_print_failed: true, on_print_stopped: true, on_print_progress: false, on_print_missing_spool_assignment: false, on_printer_offline: false, on_printer_error: false, on_ai_failure_detection: false, on_filament_low: false, on_maintenance_due: false, on_ams_humidity_high: false, on_ams_temperature_high: false, on_ams_ht_humidity_high: false, on_ams_ht_temperature_high: false, on_plate_not_empty: true, on_plate_clear_required: false, on_bed_cooled: false, on_first_layer_complete: false, on_queue_job_added: false, on_queue_job_assigned: false, on_queue_job_started: false, on_queue_job_waiting: true, on_queue_job_skipped: true, on_queue_job_failed: true, on_queue_completed: false, on_stock_reorder_alert: false, on_stock_break_alert: false, quiet_hours_enabled: false, quiet_hours_start: null, quiet_hours_end: null, daily_digest_enabled: false, daily_digest_time: null, printer_id: null, last_success: null, last_error: null, last_error_at: null, created_at: '2026-04-25T00:00:00Z', updated_at: '2026-04-25T00:00:00Z', ...overrides, }; } describe('AddNotificationModal — ntfy Priority (#990)', () => { it('renders the ntfy Priority section listing only enabled events', async () => { render( undefined} />); // Section header present, then scope every label query to it — the same // labels also appear in the toggle grid above. const sectionHeader = await screen.findByText(/ntfy priority/i); const sectionRoot = sectionHeader.closest('div')!; // Defaults from buildProvider(): complete + failed + stopped enabled; // start + progress + offline disabled. The priority list mirrors that. expect(within(sectionRoot).getByText('Complete')).toBeInTheDocument(); expect(within(sectionRoot).getByText('Failed')).toBeInTheDocument(); expect(within(sectionRoot).getByText('Stopped')).toBeInTheDocument(); // Disabled events must not appear in the priority block. expect(within(sectionRoot).queryByText('Start')).not.toBeInTheDocument(); expect(within(sectionRoot).queryByText('Progress')).not.toBeInTheDocument(); expect(within(sectionRoot).queryByText('Offline')).not.toBeInTheDocument(); }); it('does not render the Priority section for non-ntfy providers', async () => { render( undefined} />, ); // Wait for the modal to settle. await screen.findByDisplayValue('My ntfy'); expect(screen.queryByText(/ntfy priority/i)).not.toBeInTheDocument(); }); it('persists event_priorities into config on save', async () => { let captured: unknown = null; server.use( http.patch('*/api/v1/notifications/1', async ({ request }) => { captured = await request.json(); return HttpResponse.json({ id: 1 }); }), ); const onClose = vi.fn(); const user = userEvent.setup(); render(); // Pick "Urgent" (5) for the on_print_failed row. const sectionHeader = await screen.findByText(/ntfy priority/i); const sectionRoot = sectionHeader.closest('div')!; const failedRow = within(sectionRoot).getByText('Failed').closest('div')!; const select = within(failedRow).getByRole('combobox'); await user.selectOptions(select, '5'); await user.click(screen.getByRole('button', { name: /^save$/i })); await waitFor(() => expect(onClose).toHaveBeenCalled()); expect(captured).not.toBeNull(); const payload = captured as { config: Record }; expect(payload.config).toMatchObject({ server: 'https://ntfy.sh', topic: 'bambuddy', event_priorities: { on_print_failed: 5 }, }); }); it('pre-fills priorities from existing provider.config.event_priorities', async () => { const provider = buildProvider({ config: { server: 'https://ntfy.sh', topic: 'bambuddy', event_priorities: { on_print_failed: 5, on_print_complete: 2 }, }, }); render( undefined} />); const sectionHeader = await screen.findByText(/ntfy priority/i); const sectionRoot = sectionHeader.closest('div')!; const failedRow = within(sectionRoot).getByText('Failed').closest('div')!; expect((within(failedRow).getByRole('combobox') as HTMLSelectElement).value).toBe('5'); const completeRow = within(sectionRoot).getByText('Complete').closest('div')!; expect((within(completeRow).getByRole('combobox') as HTMLSelectElement).value).toBe('2'); // Stopped is enabled but has no override → defaults to 3. const stoppedRow = within(sectionRoot).getByText('Stopped').closest('div')!; expect((within(stoppedRow).getByRole('combobox') as HTMLSelectElement).value).toBe('3'); }); it('drops events from the priority section when their toggle is disabled', async () => { const user = userEvent.setup(); render( undefined} />); const sectionHeader = await screen.findByText(/ntfy priority/i); const sectionRoot = sectionHeader.closest('div')!; // Stopped is initially enabled → row visible. expect(within(sectionRoot).getByText('Stopped')).toBeInTheDocument(); // Find the Stopped toggle in the events grid (a separate area). Its label // appears in the priority section AND the toggle grid; we need the toggle // one. The toggle is a sibling of the label inside an event-row div. const allStoppedNodes = screen.getAllByText('Stopped'); // The first occurrence is in the Print Events grid; the second is in the // Priority section. Click the toggle next to the first one. const togglesGridStopped = allStoppedNodes[0]; const toggleRow = togglesGridStopped.closest('div')!; const toggle = within(toggleRow).getByRole('switch'); await user.click(toggle); // Row drops out of the priority section. await waitFor(() => { const stillSection = screen.getByText(/ntfy priority/i).closest('div')!; expect(within(stillSection).queryByText('Stopped')).not.toBeInTheDocument(); }); }); it('omits event_priorities for non-ntfy providers on save', async () => { let captured: unknown = null; server.use( http.post('*/api/v1/notifications/', async ({ request }) => { captured = await request.json(); return HttpResponse.json({ id: 99 }); }), ); const onClose = vi.fn(); const user = userEvent.setup(); render(); // Default new-provider type is email. Fill required fields and save. await user.type(screen.getByPlaceholderText(/My Notifications/i), 'Test'); await user.type(screen.getByPlaceholderText('smtp.gmail.com'), 'smtp.example.com'); const fromInputs = screen.getAllByPlaceholderText('your@email.com'); await user.type(fromInputs[fromInputs.length - 1], 'me@example.com'); await user.type(screen.getByPlaceholderText('recipient@email.com'), 'them@example.com'); await user.click(screen.getByRole('button', { name: /^add$/i })); await waitFor(() => expect(onClose).toHaveBeenCalled()); const payload = captured as { provider_type: string; config: Record }; expect(payload.provider_type).toBe('email'); expect(payload.config).not.toHaveProperty('event_priorities'); }); }); describe('AddNotificationModal — plate clear required (#2525)', () => { it('renders the toggle off by default', async () => { render( undefined} />); await screen.findByDisplayValue('My ntfy'); const toggle = screen .getAllByRole('switch') .find((s) => s.closest('div')?.textContent?.match(/plate clear required/i)); expect(toggle).toBeDefined(); expect(toggle).toHaveAttribute('aria-checked', 'false'); }); it('pre-fills the toggle from the existing provider value', async () => { render( undefined} />, ); await screen.findByDisplayValue('My ntfy'); const toggle = screen .getAllByRole('switch') .find((s) => s.closest('div')?.textContent?.match(/plate clear required/i))!; expect(toggle).toHaveAttribute('aria-checked', 'true'); }); it('persists on_plate_clear_required on save', async () => { let captured: unknown = null; server.use( http.patch('*/api/v1/notifications/1', async ({ request }) => { captured = await request.json(); return HttpResponse.json({ id: 1 }); }), ); const onClose = vi.fn(); const user = userEvent.setup(); render(); await screen.findByDisplayValue('My ntfy'); const toggle = screen .getAllByRole('switch') .find((s) => s.closest('div')?.textContent?.match(/plate clear required/i))!; await user.click(toggle); await user.click(screen.getByRole('button', { name: /^save$/i })); await waitFor(() => expect(onClose).toHaveBeenCalled()); const payload = captured as Record; expect(payload.on_plate_clear_required).toBe(true); }); it('lists the event in the ntfy priority section once enabled', async () => { render( undefined} />, ); const sectionHeader = await screen.findByText(/ntfy priority/i); const sectionRoot = sectionHeader.closest('div')!; expect(within(sectionRoot).getByText(/plate clear required/i)).toBeInTheDocument(); }); }); describe('AddNotificationModal — stock alert toggles', () => { it('renders Inventory Alerts section with both stock alert toggles', async () => { render( undefined} />); const section = await screen.findByText(/inventory alerts/i); const sectionRoot = section.closest('div')!; expect(section).toBeInTheDocument(); expect(sectionRoot.textContent).toMatch(/reorder alert/i); expect(sectionRoot.textContent).toMatch(/stock break alert/i); }); it('pre-fills toggles from existing provider values', async () => { render( undefined} />, ); await screen.findByText(/inventory alerts/i); // Reorder alert switch should be ON, break alert switch OFF const switches = screen.getAllByRole('switch'); const reorderSwitch = switches.find((s) => { const row = s.closest('div'); return row?.textContent?.match(/reorder alert/i); }); const breakSwitch = switches.find((s) => { const row = s.closest('div'); return row?.textContent?.match(/stock break alert/i); }); expect(reorderSwitch).toHaveAttribute('aria-checked', 'true'); expect(breakSwitch).toHaveAttribute('aria-checked', 'false'); }); it('persists on_stock_reorder_alert on save', async () => { let captured: unknown = null; server.use( http.patch('*/api/v1/notifications/1', async ({ request }) => { captured = await request.json(); return HttpResponse.json({ id: 1 }); }), ); const onClose = vi.fn(); const user = userEvent.setup(); render(); await screen.findByText(/inventory alerts/i); // Enable the reorder alert toggle const switches = screen.getAllByRole('switch'); const reorderSwitch = switches.find((s) => { const row = s.closest('div'); return row?.textContent?.match(/reorder alert/i); })!; await user.click(reorderSwitch); await user.click(screen.getByRole('button', { name: /^save$/i })); await waitFor(() => expect(onClose).toHaveBeenCalled()); const payload = captured as Record; expect(payload.on_stock_reorder_alert).toBe(true); }); it('persists on_stock_break_alert on save', async () => { let captured: unknown = null; server.use( http.patch('*/api/v1/notifications/1', async ({ request }) => { captured = await request.json(); return HttpResponse.json({ id: 1 }); }), ); const onClose = vi.fn(); const user = userEvent.setup(); render(); await screen.findByText(/inventory alerts/i); const switches = screen.getAllByRole('switch'); const breakSwitch = switches.find((s) => { const row = s.closest('div'); return row?.textContent?.match(/stock break alert/i); })!; await user.click(breakSwitch); await user.click(screen.getByRole('button', { name: /^save$/i })); await waitFor(() => expect(onClose).toHaveBeenCalled()); const payload = captured as Record; expect(payload.on_stock_break_alert).toBe(true); }); it('stock alert events appear in ntfy priority section when enabled', async () => { const user = userEvent.setup(); render( undefined} />, ); const priorityHeader = await screen.findByText(/ntfy priority/i); const priorityRoot = priorityHeader.closest('div')!; // Both stock alert events should appear in the priority list since they are enabled expect(within(priorityRoot).getByText('Reorder Alert')).toBeInTheDocument(); expect(within(priorityRoot).getByText('Stock Break Alert')).toBeInTheDocument(); void user; // referenced to avoid unused-var lint warning }); }); describe('AddNotificationModal — AI Failure Detection toggle (#1794)', () => { it('renders the toggle in the Printer Status section', async () => { render( undefined} />); expect(await screen.findByText('AI Failure Detection')).toBeInTheDocument(); }); it('persists on_ai_failure_detection on save (and does NOT touch on_printer_error)', async () => { let captured: Record | null = null; server.use( http.patch('*/api/v1/notifications/1', async ({ request }) => { captured = (await request.json()) as Record; return HttpResponse.json({ id: 1 }); }), ); const onClose = vi.fn(); const user = userEvent.setup(); render(); const label = await screen.findByText('AI Failure Detection'); const row = label.closest('div.flex')!; const toggle = within(row).getByRole('switch'); await user.click(toggle); await user.click(screen.getByRole('button', { name: /^save$/i })); await waitFor(() => expect(onClose).toHaveBeenCalled()); expect(captured).not.toBeNull(); expect(captured!.on_ai_failure_detection).toBe(true); // Critical regression guard: don't accidentally flip the legacy multiplexed field. expect(captured!.on_printer_error).toBe(false); }); it('AI Failure Detection appears in ntfy priority section when enabled', async () => { render( undefined} />, ); const priorityHeader = await screen.findByText(/ntfy priority/i); const priorityRoot = priorityHeader.closest('div')!; expect(within(priorityRoot).getByText('AI Failure Detection')).toBeInTheDocument(); }); }); describe('AddNotificationModal — Home Assistant custom data (#1441)', () => { const haProvider = () => buildProvider({ provider_type: 'homeassistant', config: { service: 'notify.mobile_app_myphone' }, }); it('renders the Data (JSON) textarea for the homeassistant provider', async () => { render( undefined} />); await screen.findByDisplayValue('My ntfy'); expect(screen.getByText(/data \(json, optional\)/i)).toBeInTheDocument(); expect(screen.getByPlaceholderText(/"priority": "high"/)).toBeInTheDocument(); }); it('rejects malformed JSON in the Data field on save', async () => { const patchSpy = vi.fn(); server.use( http.patch('*/api/v1/notifications/1', () => { patchSpy(); return HttpResponse.json({ id: 1 }); }), ); const onClose = vi.fn(); const user = userEvent.setup(); render(); const textarea = await screen.findByPlaceholderText(/"priority": "high"/); await user.type(textarea, '{{priority: high}'); await user.click(screen.getByRole('button', { name: /^save$/i })); expect(await screen.findByText(/must be a valid JSON object/i)).toBeInTheDocument(); expect(patchSpy).not.toHaveBeenCalled(); expect(onClose).not.toHaveBeenCalled(); }); it('round-trips valid Data JSON into config on save', async () => { let captured: { config: Record } | null = null; server.use( http.patch('*/api/v1/notifications/1', async ({ request }) => { captured = (await request.json()) as { config: Record }; return HttpResponse.json({ id: 1 }); }), ); const onClose = vi.fn(); const user = userEvent.setup(); render(); const textarea = await screen.findByPlaceholderText(/"priority": "high"/); await user.type(textarea, '{{"ttl": 0}'); await user.click(screen.getByRole('button', { name: /^save$/i })); await waitFor(() => expect(onClose).toHaveBeenCalled()); expect(captured).not.toBeNull(); expect(captured!.config).toMatchObject({ service: 'notify.mobile_app_myphone', data: '{"ttl": 0}', }); }); }); describe('AddNotificationModal — Bark provider (#1495)', () => { it('offers Bark in the provider select and renders its config fields', async () => { render( undefined} />, ); await screen.findByDisplayValue('My ntfy'); expect(screen.getByRole('option', { name: 'Bark' })).toBeInTheDocument(); expect(screen.getByText(/device key/i)).toBeInTheDocument(); expect(screen.getByPlaceholderText('https://api.day.app')).toBeInTheDocument(); expect(screen.getByText(/interruption level/i)).toBeInTheDocument(); }); it('round-trips Bark options into config on save', async () => { let captured: { config: Record } | null = null; server.use( http.patch('*/api/v1/notifications/1', async ({ request }) => { captured = (await request.json()) as { config: Record }; return HttpResponse.json({ id: 1 }); }), ); const onClose = vi.fn(); const user = userEvent.setup(); render( , ); const groupInput = await screen.findByPlaceholderText('Bambuddy'); await user.type(groupInput, 'Printers'); const levelRow = screen.getByText(/interruption level/i).closest('div')!; await user.selectOptions(within(levelRow).getByRole('combobox'), 'critical'); await user.click(screen.getByRole('button', { name: /^save$/i })); await waitFor(() => expect(onClose).toHaveBeenCalled()); expect(captured).not.toBeNull(); expect(captured!.config).toMatchObject({ device_key: 'abc123', group: 'Printers', level: 'critical', }); }); }); describe('AddNotificationModal — Telegram forum topic (#1518)', () => { const telegramProvider = (config: Record = { bot_token: 'x', chat_id: '-100123' }) => buildProvider({ provider_type: 'telegram', config }); it('offers the Forum Topic ID field as optional for telegram', async () => { render( undefined} />); const label = await screen.findByText(/forum topic id/i); // Required fields are marked with a trailing asterisk — this one must not be. expect(label.textContent).not.toContain('*'); expect(screen.getByText(/leave empty for the general topic/i)).toBeInTheDocument(); }); it('does not offer the field for other providers', async () => { render( undefined} />); await screen.findByDisplayValue('My ntfy'); expect(screen.queryByText(/forum topic id/i)).not.toBeInTheDocument(); }); it('round-trips the topic id into config on save', async () => { let captured: { config: Record } | null = null; server.use( http.patch('*/api/v1/notifications/1', async ({ request }) => { captured = (await request.json()) as { config: Record }; return HttpResponse.json({ id: 1 }); }), ); const onClose = vi.fn(); const user = userEvent.setup(); render(); await user.type(await screen.findByPlaceholderText('123'), '25'); await user.click(screen.getByRole('button', { name: /^save$/i })); await waitFor(() => expect(onClose).toHaveBeenCalled()); expect(captured).not.toBeNull(); expect(captured!.config).toMatchObject({ chat_id: '-100123', message_thread_id: '25' }); }); it('keeps the config free of the key when the field is left empty', async () => { let captured: { config: Record } | null = null; server.use( http.patch('*/api/v1/notifications/1', async ({ request }) => { captured = (await request.json()) as { config: Record }; return HttpResponse.json({ id: 1 }); }), ); const onClose = vi.fn(); const user = userEvent.setup(); render(); await screen.findByPlaceholderText('123'); await user.click(screen.getByRole('button', { name: /^save$/i })); await waitFor(() => expect(onClose).toHaveBeenCalled()); expect(captured!.config).not.toHaveProperty('message_thread_id'); }); it('blocks save on a non-numeric topic id', async () => { // Reaches the form via a config written by the API rather than the picker — // the number input itself already filters most junk out. let patched = false; server.use( http.patch('*/api/v1/notifications/1', async () => { patched = true; return HttpResponse.json({ id: 1 }); }), ); const onClose = vi.fn(); const user = userEvent.setup(); render( , ); await screen.findByText(/forum topic id/i); await user.click(screen.getByRole('button', { name: /^save$/i })); expect(await screen.findByText(/forum topic id must be a number/i)).toBeInTheDocument(); expect(patched).toBe(false); expect(onClose).not.toHaveBeenCalled(); }); });