Преглед изворни кода

chore(installer): add RunOnceId to UninstallRun entries

  Silences Inno Setup's "missing RunOnceId" warning. Both commands
  (stop service, remove firewall rule) are already idempotent, so the
  behavioural effect is nil — this is purely a cleanliness fix to keep
  the build log warning-free.
maziggy пре 2 месеци
родитељ
комит
106ba7938a
1 измењених фајлова са 5 додато и 3 уклоњено
  1. 5 3
      installers/windows/bambuddy.iss

+ 5 - 3
installers/windows/bambuddy.iss

@@ -110,11 +110,13 @@ Filename: "netsh.exe"; Parameters: "advfirewall firewall add rule name=""Bambudd
 Filename: "http://localhost:{#DefaultPort}"; Flags: shellexec postinstall nowait skipifsilent; Description: "Open Bambuddy Dashboard"
 Filename: "http://localhost:{#DefaultPort}"; Flags: shellexec postinstall nowait skipifsilent; Description: "Open Bambuddy Dashboard"
 
 
 [UninstallRun]
 [UninstallRun]
-; Stop + deregister the service before file removal
-Filename: "{app}\service\uninstall-service.bat"; Parameters: """{app}"""; Flags: runhidden waituntilterminated
+; Stop + deregister the service before file removal. RunOnceId makes the
+; entry run-once per uninstall pass (Inno Setup default is to re-run on
+; every pass, which can fire multiple times during upgrade flows).
+Filename: "{app}\service\uninstall-service.bat"; Parameters: """{app}"""; Flags: runhidden waituntilterminated; RunOnceId: "StopBambuddyService"
 
 
 ; Remove the firewall rule (silently — if it doesn't exist, netsh just complains)
 ; Remove the firewall rule (silently — if it doesn't exist, netsh just complains)
-Filename: "netsh.exe"; Parameters: "advfirewall firewall delete rule name=""Bambuddy Dashboard"""; Flags: runhidden waituntilterminated
+Filename: "netsh.exe"; Parameters: "advfirewall firewall delete rule name=""Bambuddy Dashboard"""; Flags: runhidden waituntilterminated; RunOnceId: "RemoveFirewallRule"
 
 
 [UninstallDelete]
 [UninstallDelete]
 ; Remove install dir contents; leave ProgramData\Bambuddy alone so the
 ; Remove install dir contents; leave ProgramData\Bambuddy alone so the