Просмотр исходного кода

fix(maintenance): Check Belt Tension on a P1 links to the belt guide (#3302)

- The P1 link went to Bambu Lab's general P1 maintenance
  recommendations. Bambu Lab has one belt page for both series, "X1/P1
  Series Belt tensioning procedure"; there is no P1 page of its own.
  P1 now falls through to it with X1.
maziggy 10 часов назад
Родитель
Сommit
03d95b1fd8

+ 1 - 0
CHANGELOG.md

@@ -174,6 +174,7 @@ All notable changes to Bambuddy will be documented in this file.
 - **The frontend build no longer warns about `path` and `crypto` being externalized for the STEP previewer (#2976)** — `occt-import-js`, the Emscripten build behind STEP previews, requires both modules, but only inside its `ENVIRONMENT_IS_NODE` branches; in the browser it loads its `.wasm` from the URL the preview worker passes and draws randomness from `crypto.getRandomValues`. Vite still externalized both and printed two warnings on every build. `vite.config.ts` now drops exactly those two warnings for that one package through `build.rolldownOptions.onLog`, so an externalization anywhere else, or of any other module, still shows.
 
 ### Fixed
+- **Check Belt Tension on a P1 printer links to Bambu Lab's belt tensioning guide (#3302)** — The maintenance task's help link on a P1P or P1S opened Bambu Lab's general P1 maintenance recommendations instead of a belt guide. It now opens the "X1/P1 Series Belt tensioning procedure" page, which covers both series.
 - **Searching "#123" in Assign Spool finds that spool whatever the slot holds (#3301)** — Searching for a spool's number with a `#` in front, as in `#123`, only looked among the spools matching the slot's material. A spool of another material came up empty unless **Show all spools** was ticked, as if it had been deleted.
   - **Now:** a `#` search shows exactly that spool, whatever its material. Assigning a spool of another material still asks first, as before. Any other search still lists only spools matching the slot.
   - **When the spool still can't be offered**, the list says why: it is already assigned to another slot, it is archived, or there is no spool with that number.

+ 11 - 0
frontend/src/__tests__/utils/maintenanceWikiUrls.test.ts

@@ -65,6 +65,17 @@ describe('getMaintenanceWikiUrl', () => {
     });
   });
 
+  describe('P1 belt tension (#3302)', () => {
+    // Bambu Lab's belt page covers X1 and P1 ("X1/P1 Series Belt tensioning
+    // procedure"); there is no P1 page of its own. The link went to the P1
+    // series' general maintenance recommendations instead.
+    it.each(['P1S', 'P1P', 'P1 S'])('%s links to the X1/P1 belt tensioning page', (model) => {
+      expect(getMaintenanceWikiUrl('Check Belt Tension', model)).toBe(
+        'https://wiki.bambulab.com/en/x1/maintenance/belt-tension',
+      );
+    });
+  });
+
   describe('regression: other families untouched', () => {
     it('X1C belt tension unchanged', () => {
       expect(getMaintenanceWikiUrl('Check Belt Tension', 'X1C')).toBe(

+ 2 - 2
frontend/src/utils/maintenanceWikiUrls.ts

@@ -51,14 +51,14 @@ export function getMaintenanceWikiUrl(typeName: string, printerModel: string | n
       return 'https://wiki.bambulab.com/en/x1/troubleshooting/nozzle-clog';
 
     case 'Check Belt Tension':
-      if (isX1) return 'https://wiki.bambulab.com/en/x1/maintenance/belt-tension';
-      if (isP1) return 'https://wiki.bambulab.com/en/p1/maintenance/p1p-maintenance';
       if (isA1Mini) return 'https://wiki.bambulab.com/en/a1-mini/maintenance/belt_tension';
       if (isA1) return 'https://wiki.bambulab.com/en/a1/maintenance/belt_tension';
       if (isH2D) return 'https://wiki.bambulab.com/en/h2/maintenance/belt-tension';
       if (isH2C) return 'https://wiki.bambulab.com/en/h2c/maintenance/belt-tension';
       if (isH2S) return 'https://wiki.bambulab.com/en/h2s/maintenance/belt-tension';
       if (isSteelRod) return 'https://wiki.bambulab.com/en/p2s/maintenance/belt-tension';
+      // X1 and P1 share one page, "X1/P1 Series Belt tensioning procedure";
+      // P1 has none of its own, so it must not get a branch above (#3302).
       return 'https://wiki.bambulab.com/en/x1/maintenance/belt-tension';
 
     case 'Clean Carbon Rods':

Разница между файлами не показана из-за своего большого размера
+ 0 - 0
static/assets/ArchivesPage-BK9OwB_q.js


Разница между файлами не показана из-за своего большого размера
+ 0 - 0
static/assets/CameraPage-14haujuN.js


Разница между файлами не показана из-за своего большого размера
+ 0 - 0
static/assets/FileManagerPage-B8h6rQf-.js


Разница между файлами не показана из-за своего большого размера
+ 0 - 0
static/assets/InventoryPage-Dl4gQUjs.js


Разница между файлами не показана из-за своего большого размера
+ 0 - 0
static/assets/MaintenancePage-BKNjosyr.js


Разница между файлами не показана из-за своего большого размера
+ 0 - 0
static/assets/MaintenancePage-Dhb0XdWr.js


Разница между файлами не показана из-за своего большого размера
+ 0 - 0
static/assets/ModelSourcesPage-CIMmaJuK.js


Разница между файлами не показана из-за своего большого размера
+ 0 - 0
static/assets/PhotoGalleryModal-ChJGAWjG.js


Разница между файлами не показана из-за своего большого размера
+ 0 - 0
static/assets/PrintersPage-BMqz0Ozs.js


Разница между файлами не показана из-за своего большого размера
+ 0 - 0
static/assets/SettingsPage-BUVSoK4T.js


Разница между файлами не показана из-за своего большого размера
+ 0 - 0
static/assets/SliceModal-Bn-G2mDO.js


Разница между файлами не показана из-за своего большого размера
+ 1 - 1
static/assets/SpoolBuddySettingsPage-C955a62v.js


Разница между файлами не показана из-за своего большого размера
+ 0 - 0
static/assets/index-DPuWk1vL.js


Разница между файлами не показана из-за своего большого размера
+ 0 - 0
static/assets/locationSensorDefaults-ld1lmb1K.js


+ 1 - 1
static/index.html

@@ -26,7 +26,7 @@
 
     <!-- Splash screens for iOS -->
     <link rel="apple-touch-startup-image" href="/img/android-chrome-512x512.png" />
-    <script type="module" crossorigin src="/assets/index-zDGNl2cU.js"></script>
+    <script type="module" crossorigin src="/assets/index-DPuWk1vL.js"></script>
     <link rel="modulepreload" crossorigin href="/assets/rolldown-runtime-aKtaBQYM.js">
     <link rel="modulepreload" crossorigin href="/assets/client-DSw2TdH4.js">
     <link rel="modulepreload" crossorigin href="/assets/react-dom-PmRWqOqI.js">

Некоторые файлы не были показаны из-за большого количества измененных файлов