Просмотр исходного кода

Adjust I2C pins configuration: disable pullup and set speed to low (#352)

* Adjust I2C pins configuration: disable pullup and set speed to low
* promote i2c owner

Co-authored-by: aanper <mail@s3f.ru>
あく 4 лет назад
Родитель
Сommit
a0db2986b5
3 измененных файлов с 7 добавлено и 4 удалено
  1. 3 0
      .github/CODEOWNERS
  2. 2 2
      firmware/targets/f4/Src/i2c.c
  3. 2 2
      firmware/targets/f5/Src/i2c.c

+ 3 - 0
.github/CODEOWNERS

@@ -50,6 +50,9 @@ firmware/targets/f4/api-hal/api-hal-vcp.c @skotopes
 firmware/targets/f4/api-hal/api-hal.c @DrZlo13
 firmware/targets/f4/api-hal/api-hal.c @DrZlo13
 firmware/targets/f4/api-hal/api-interrupts.c @DrZlo13
 firmware/targets/f4/api-hal/api-interrupts.c @DrZlo13
 
 
+firmware/targets/f4/Src/i2c.c @skotopes
+firmware/targets/f5/Src/i2c.c @skotopes
+
 # BLE
 # BLE
 
 
 firmware/targets/f4/ble-glue/** @skotopes
 firmware/targets/f4/ble-glue/** @skotopes

+ 2 - 2
firmware/targets/f4/Src/i2c.c

@@ -75,8 +75,8 @@ void HAL_I2C_MspInit(I2C_HandleTypeDef* i2cHandle)
     */
     */
     GPIO_InitStruct.Pin = I2C_SCL_Pin|I2C_SDA_Pin;
     GPIO_InitStruct.Pin = I2C_SCL_Pin|I2C_SDA_Pin;
     GPIO_InitStruct.Mode = GPIO_MODE_AF_OD;
     GPIO_InitStruct.Mode = GPIO_MODE_AF_OD;
-    GPIO_InitStruct.Pull = GPIO_PULLUP;
-    GPIO_InitStruct.Speed = GPIO_SPEED_FREQ_VERY_HIGH;
+    GPIO_InitStruct.Pull = GPIO_NOPULL;
+    GPIO_InitStruct.Speed = GPIO_SPEED_FREQ_LOW;
     GPIO_InitStruct.Alternate = GPIO_AF4_I2C1;
     GPIO_InitStruct.Alternate = GPIO_AF4_I2C1;
     HAL_GPIO_Init(GPIOA, &GPIO_InitStruct);
     HAL_GPIO_Init(GPIOA, &GPIO_InitStruct);
 
 

+ 2 - 2
firmware/targets/f5/Src/i2c.c

@@ -75,8 +75,8 @@ void HAL_I2C_MspInit(I2C_HandleTypeDef* i2cHandle)
     */
     */
     GPIO_InitStruct.Pin = I2C_SCL_Pin|I2C_SDA_Pin;
     GPIO_InitStruct.Pin = I2C_SCL_Pin|I2C_SDA_Pin;
     GPIO_InitStruct.Mode = GPIO_MODE_AF_OD;
     GPIO_InitStruct.Mode = GPIO_MODE_AF_OD;
-    GPIO_InitStruct.Pull = GPIO_PULLUP;
-    GPIO_InitStruct.Speed = GPIO_SPEED_FREQ_VERY_HIGH;
+    GPIO_InitStruct.Pull = GPIO_NOPULL;
+    GPIO_InitStruct.Speed = GPIO_SPEED_FREQ_LOW;
     GPIO_InitStruct.Alternate = GPIO_AF4_I2C1;
     GPIO_InitStruct.Alternate = GPIO_AF4_I2C1;
     HAL_GPIO_Init(GPIOA, &GPIO_InitStruct);
     HAL_GPIO_Init(GPIOA, &GPIO_InitStruct);