Просмотр исходного кода

[FL-3182] Fix typos in iButton (#2506)

* Fix a typo: right shift instead of greater than
* Fix a typo: proper iButton part number

Co-authored-by: あく <alleteam@gmail.com>
Georgii Surkov 2 лет назад
Родитель
Сommit
1d91a572cc

+ 1 - 1
documentation/file_formats/iButtonFileFormat.md

@@ -26,7 +26,7 @@ Changelog:
 
 | Name        | Type   | Description                                  |
 | ----------- | ------ | -------------------------------------------- |
-| Protocol    | string | Currently supported: DS1990, DS1992, DS1996, DS1997, DSGeneric*, Cyfral, Metakom |
+| Protocol    | string | Currently supported: DS1990, DS1992, DS1996, DS1971, DSGeneric*, Cyfral, Metakom |
 | Rom Data    | hex    | Read-only memory data (Dallas protocols only) |
 | Sram Data   | hex    | Static RAM data (DS1992 and DS1996 only)
 | Eeprom Data | hex    | EEPROM data (DS1971 only)

+ 1 - 1
lib/one_wire/ibutton/protocols/dallas/dallas_common.c

@@ -85,7 +85,7 @@ bool dallas_common_read_mem(OneWireHost* host, uint16_t address, uint8_t* data,
     onewire_host_write(host, DALLAS_COMMON_CMD_READ_MEM);
 
     onewire_host_write(host, (uint8_t)address);
-    onewire_host_write(host, (uint8_t)(address > BITS_IN_BYTE));
+    onewire_host_write(host, (uint8_t)(address >> BITS_IN_BYTE));
 
     onewire_host_read_bytes(host, data, (uint16_t)data_size);